diff options
| author | Geremia Taglialatela <[email protected]> | 2023-05-25 14:17:12 +0200 |
|---|---|---|
| committer | Geremia Taglialatela <[email protected]> | 2023-05-25 14:17:12 +0200 |
| commit | 2a70161abe24ae130041aaca3eec79e63d08a5f5 (patch) | |
| tree | 5dd5cbdfda525eaaaf857513dafc322096eeaf47 /test/doc_props | |
| parent | 14b7da239879d5299775c48666b43f3016add8ec (diff) | |
| download | caxlsx-2a70161abe24ae130041aaca3eec79e63d08a5f5.tar.gz caxlsx-2a70161abe24ae130041aaca3eec79e63d08a5f5.zip | |
Fix StringConcatenation offenses (non-production)
Prefer interpolation over concatenation
```
Comparison ("String#{'String'}" vs 'String' + 'String'):
interpolation: 11821321.0 i/s
concatenation: 8849491.7 i/s - 1.34x (± 0.00) slower
```
Diffstat (limited to 'test/doc_props')
| -rw-r--r-- | test/doc_props/tc_app.rb | 2 | ||||
| -rw-r--r-- | test/doc_props/tc_core.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/doc_props/tc_app.rb b/test/doc_props/tc_app.rb index 82e33f12..c066373c 100644 --- a/test/doc_props/tc_app.rb +++ b/test/doc_props/tc_app.rb @@ -41,6 +41,6 @@ class TestApp < Test::Unit::TestCase errors << error end - assert_equal(0, errors.size, "app.xml invalid" + errors.map(&:message).to_s) + assert_equal(0, errors.size, "app.xml invalid#{errors.map(&:message)}") end end diff --git a/test/doc_props/tc_core.rb b/test/doc_props/tc_core.rb index bfacab45..5a04a615 100644 --- a/test/doc_props/tc_core.rb +++ b/test/doc_props/tc_core.rb @@ -18,7 +18,7 @@ class TestCore < Test::Unit::TestCase errors << error end - assert_equal(0, errors.size, "core.xml Invalid" + errors.map(&:message).to_s) + assert_equal(0, errors.size, "core.xml Invalid#{errors.map(&:message)}") end def test_populates_created |
