Add RuboCop Minitest

1 files changed, 38 insertions, 15 deletions

diff --git a/test/workbook/tc_workbook.rb b/test/workbook/tc_workbook.rb
index f0a7ac19..1e8a35e4 100644
--- a/test/workbook/tc_workbook.rb
+++ b/test/workbook/tc_workbook.rb
@@ -11,37 +11,41 @@ class TestWorkbook < Test::Unit::TestCase
   def test_worksheet_users_xml_space
     sheet = @wb.add_worksheet(:name => 'foo')
     ws_xml = Nokogiri::XML(sheet.to_xml_string)
+
     assert(ws_xml.xpath("//xmlns:worksheet/@xml:space='preserve'"))
 
     @wb.xml_space = :default
     ws_xml = Nokogiri::XML(sheet.to_xml_string)
+
     assert(ws_xml.xpath("//xmlns:worksheet/@xml:space='default'"))
   end
 
   def test_xml_space
     assert_equal(:preserve, @wb.xml_space)
     @wb.xml_space = :default
+
     assert_equal(:default, @wb.xml_space)
     assert_raise(ArgumentError) { @wb.xml_space = :none }
   end
 
   def test_no_autowidth
-    assert_equal(@wb.use_autowidth, true)
+    assert(@wb.use_autowidth)
     assert_raise(ArgumentError) { @wb.use_autowidth = 0.1 }
     assert_nothing_raised { @wb.use_autowidth = false }
-    assert_equal(@wb.use_autowidth, false)
+    refute(@wb.use_autowidth)
   end
 
   def test_is_reversed
-    assert_equal(@wb.is_reversed, nil)
+    assert_nil(@wb.is_reversed)
     assert_raise(ArgumentError) { @wb.is_reversed = 0.1 }
     assert_nothing_raised { @wb.is_reversed = true }
-    assert_equal(@wb.use_autowidth, true)
+    assert(@wb.use_autowidth)
   end
 
   def test_sheet_by_name_retrieval
     @wb.add_worksheet(:name => 'foo')
     @wb.add_worksheet(:name => 'bar')
+
     assert_equal('foo', @wb.sheet_by_name('foo').name)
   end
 
@@ -52,49 +56,57 @@ class TestWorkbook < Test::Unit::TestCase
   def test_date1904
     assert_equal(Axlsx::Workbook.date1904, @wb.date1904)
     @wb.date1904 = :false
+
     assert_equal(Axlsx::Workbook.date1904, @wb.date1904)
     Axlsx::Workbook.date1904 = :true
+
     assert_equal(Axlsx::Workbook.date1904, @wb.date1904)
   end
 
   def test_add_defined_name
     @wb.add_defined_name 'Sheet1!1:1', :name => '_xlnm.Print_Titles', :hidden => true
+
     assert_equal(1, @wb.defined_names.size)
   end
 
   def test_add_view
     @wb.add_view visibility: :hidden, window_width: 800
+
     assert_equal(1, @wb.views.size)
   end
 
   def test_shared_strings
-    assert_equal(@wb.use_shared_strings, nil)
+    assert_nil(@wb.use_shared_strings)
     assert_raise(ArgumentError) { @wb.use_shared_strings = 'bpb' }
     assert_nothing_raised { @wb.use_shared_strings = :true }
   end
 
   def test_add_worksheet
-    assert(@wb.worksheets.empty?, "worbook has no worksheets by default")
+    assert_empty(@wb.worksheets, "worbook has no worksheets by default")
     ws = @wb.add_worksheet(:name => "bob")
-    assert_equal(@wb.worksheets.size, 1, "add_worksheet adds a worksheet!")
+
+    assert_equal(1, @wb.worksheets.size, "add_worksheet adds a worksheet!")
     assert_equal(@wb.worksheets.first, ws, "the worksheet returned is the worksheet added")
-    assert_equal(ws.name, "bob", "name option gets passed to worksheet")
+    assert_equal("bob", ws.name, "name option gets passed to worksheet")
   end
 
   def test_insert_worksheet
     @wb.add_worksheet(:name => 'A')
     @wb.add_worksheet(:name => 'B')
     ws3 = @wb.insert_worksheet(0, :name => 'C')
+
     assert_equal(ws3.name, @wb.worksheets.first.name)
   end
 
   def test_relationships
     # current relationship size is 1 due to style relation
-    assert(@wb.relationships.size == 1)
+    assert_equal(1, @wb.relationships.size)
     @wb.add_worksheet
-    assert(@wb.relationships.size == 2)
+
+    assert_equal(2, @wb.relationships.size)
     @wb.use_shared_strings = true
-    assert(@wb.relationships.size == 3)
+
+    assert_equal(3, @wb.relationships.size)
   end
 
   def test_to_xml
@@ -105,7 +117,8 @@ class TestWorkbook < Test::Unit::TestCase
       errors.push error
       puts error.message
     end
-    assert(errors.empty?, "error free validation")
+
+    assert_empty(errors, "error free validation")
   end
 
   def test_to_xml_reversed
@@ -113,6 +126,7 @@ class TestWorkbook < Test::Unit::TestCase
     @wb.add_worksheet(:name => 'first')
     second = @wb.add_worksheet(:name => 'second')
     doc = Nokogiri::XML(@wb.to_xml_string)
+
     assert_equal second.name, doc.xpath('//xmlns:workbook/xmlns:sheets/*[1]/@name').to_s
   end
 
@@ -121,13 +135,14 @@ class TestWorkbook < Test::Unit::TestCase
     ws.add_row [1, 2, 3]
     ws.add_row [4, 5, 6]
     assert_raise(ArgumentError, "no sheet name part") { @wb["A1:C2"] }
-    assert_equal @wb['fish!A1:C2'].size, 6
+    assert_equal(6, @wb['fish!A1:C2'].size)
   end
 
   def test_to_xml_adds_worksheet_when_worksheets_is_empty
-    assert(@wb.worksheets.empty?)
+    assert_empty(@wb.worksheets)
     @wb.to_xml_string
-    assert(@wb.worksheets.size == 1)
+
+    assert_equal(1, @wb.worksheets.size)
   end
 
   def test_to_xml_string_defined_names
@@ -136,6 +151,7 @@ class TestWorkbook < Test::Unit::TestCase
       sheet.auto_filter = "A1:B1"
     end
     doc = Nokogiri::XML(@wb.to_xml_string)
+
     assert_equal(doc.xpath('//xmlns:workbook/xmlns:definedNames/xmlns:definedName').inner_text, @wb.worksheets[0].auto_filter.defined_name)
   end
 
@@ -145,6 +161,7 @@ class TestWorkbook < Test::Unit::TestCase
     end
     @wb.add_view active_tab: 0, first_sheet: 0
     doc = Nokogiri::XML(@wb.to_xml_string)
+
     assert_equal(1, doc.xpath('//xmlns:workbook/xmlns:bookViews/xmlns:workbookView[@activeTab=0]').size)
   end
 
@@ -152,12 +169,14 @@ class TestWorkbook < Test::Unit::TestCase
     ws = @wb.add_worksheet
     pivot_table = ws.add_pivot_table('G5:G6', 'A1:D5')
     doc = Nokogiri::XML(@wb.to_xml_string)
+
     assert_equal pivot_table.cache_definition.rId, doc.xpath("//xmlns:pivotCache").first["r:id"]
   end
 
   def test_worksheet_name_is_intact_after_serialized_into_xml
     sheet = @wb.add_worksheet(:name => '_Example')
     wb_xml = Nokogiri::XML(@wb.to_xml_string)
+
     assert_equal sheet.name, wb_xml.xpath('//xmlns:workbook/xmlns:sheets/*[1]/@name').to_s
   end
 
@@ -165,6 +184,7 @@ class TestWorkbook < Test::Unit::TestCase
     Axlsx::escape_formulas = false
     p = Axlsx::Package.new
     @wb = p.workbook
+
     assert_false @wb.escape_formulas
     assert_false @wb.add_worksheet.escape_formulas
     assert_false @wb.add_worksheet(escape_formulas: false).escape_formulas
@@ -173,12 +193,14 @@ class TestWorkbook < Test::Unit::TestCase
     Axlsx::escape_formulas = true
     p = Axlsx::Package.new
     @wb = p.workbook
+
     assert @wb.escape_formulas
     assert @wb.add_worksheet.escape_formulas
     assert_false @wb.add_worksheet(escape_formulas: false).escape_formulas
     assert @wb.add_worksheet(escape_formulas: true).escape_formulas
 
     @wb.escape_formulas = false
+
     assert_false @wb.escape_formulas
     assert_false @wb.add_worksheet.escape_formulas
     assert_false @wb.add_worksheet(escape_formulas: false).escape_formulas
@@ -187,6 +209,7 @@ class TestWorkbook < Test::Unit::TestCase
     @wb.escape_formulas = true
     p = Axlsx::Package.new
     @wb = p.workbook
+
     assert @wb.escape_formulas
     assert @wb.add_worksheet.escape_formulas
     assert_false @wb.add_worksheet(escape_formulas: false).escape_formulas