summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
Diffstat
-rw-r--r--lib/axlsx.rb2
-rw-r--r--lib/axlsx/content_type/abstract_content_type.rb2
-rw-r--r--lib/axlsx/doc_props/app.rb2
-rw-r--r--lib/axlsx/drawing/d_lbls.rb2
-rw-r--r--lib/axlsx/drawing/view_3D.rb2
-rw-r--r--lib/axlsx/rels/relationship.rb2
-rw-r--r--lib/axlsx/stylesheet/font.rb2
-rw-r--r--lib/axlsx/stylesheet/styles.rb4
-rw-r--r--lib/axlsx/util/serialized_attributes.rb4
-rw-r--r--lib/axlsx/workbook/worksheet/cell_serializer.rb2
-rw-r--r--lib/axlsx/workbook/worksheet/data_validation.rb2
-rw-r--r--lib/axlsx/workbook/worksheet/rich_text_run.rb2
-rw-r--r--lib/axlsx/workbook/worksheet/worksheet.rb2
-rw-r--r--test/drawing/tc_chart.rb2
-rw-r--r--test/drawing/tc_d_lbls.rb2
-rw-r--r--test/drawing/tc_picture_locking.rb2
-rw-r--r--test/stylesheet/tc_styles.rb4
-rw-r--r--test/tc_package.rb8
-rw-r--r--test/workbook/worksheet/tc_worksheet_hyperlink.rb2
19 files changed, 25 insertions, 25 deletions
diff --git a/lib/axlsx.rb b/lib/axlsx.rb
index 4a7786ce..f2403893 100644
--- a/lib/axlsx.rb
+++ b/lib/axlsx.rb
@@ -41,7 +41,7 @@ module Axlsx
# library just for this one method.
#
# Defining as a class method on Axlsx to refrain from monkeypatching Object for all users of this gem.
- def self.instance_values(object)
+ def self.instance_values_for(object)
Hash[object.instance_variables.map { |name| [name.to_s[1..-1], object.instance_variable_get(name)] }]
end
diff --git a/lib/axlsx/content_type/abstract_content_type.rb b/lib/axlsx/content_type/abstract_content_type.rb
index 69fdcd31..82a659dd 100644
--- a/lib/axlsx/content_type/abstract_content_type.rb
+++ b/lib/axlsx/content_type/abstract_content_type.rb
@@ -24,7 +24,7 @@ module Axlsx
# Serialize the contenty type to xml
def to_xml_string(node_name = '', str = '')
str << "<#{node_name} "
- str << Axlsx.instance_values(self).map { |key, value| Axlsx::camel(key) << '="' << value.to_s << '"' }.join(' ')
+ str << Axlsx.instance_values_for(self).map { |key, value| Axlsx::camel(key) << '="' << value.to_s << '"' }.join(' ')
str << '/>'
end
diff --git a/lib/axlsx/doc_props/app.rb b/lib/axlsx/doc_props/app.rb
index d2421da7..c7df1fcb 100644
--- a/lib/axlsx/doc_props/app.rb
+++ b/lib/axlsx/doc_props/app.rb
@@ -223,7 +223,7 @@ module Axlsx
def to_xml_string(str = '')
str << '<?xml version="1.0" encoding="UTF-8"?>'
str << ('<Properties xmlns="' << APP_NS << '" xmlns:vt="' << APP_NS_VT << '">')
- Axlsx.instance_values(self).each do |key, value|
+ Axlsx.instance_values_for(self).each do |key, value|
node_name = Axlsx.camel(key)
str << "<#{node_name}>#{value}</#{node_name}>"
end
diff --git a/lib/axlsx/drawing/d_lbls.rb b/lib/axlsx/drawing/d_lbls.rb
index da696ef6..0fb3c6ad 100644
--- a/lib/axlsx/drawing/d_lbls.rb
+++ b/lib/axlsx/drawing/d_lbls.rb
@@ -71,7 +71,7 @@ module Axlsx
def to_xml_string(str = '')
validate_attributes_for_chart_type
str << '<c:dLbls>'
- instance_vals = Axlsx.instance_values(self)
+ instance_vals = Axlsx.instance_values_for(self)
%w(d_lbl_pos show_legend_key show_val show_cat_name show_ser_name show_percent show_bubble_size show_leader_lines).each do |key|
next unless instance_vals.keys.include?(key) && instance_vals[key] != nil
str << "<c:#{Axlsx::camel(key, false)} val='#{instance_vals[key]}' />"
diff --git a/lib/axlsx/drawing/view_3D.rb b/lib/axlsx/drawing/view_3D.rb
index b8f6aa79..2223d501 100644
--- a/lib/axlsx/drawing/view_3D.rb
+++ b/lib/axlsx/drawing/view_3D.rb
@@ -107,7 +107,7 @@ module Axlsx
private
# Note: move this to Axlsx module if we find the smae pattern elsewhere.
def element_for_attribute(name, namespace='')
- val = Axlsx.instance_values(self)[name]
+ val = Axlsx.instance_values_for(self)[name]
return "" if val == nil
"<%s:%s val='%s'/>" % [namespace, Axlsx::camel(name, false), val]
end
diff --git a/lib/axlsx/rels/relationship.rb b/lib/axlsx/rels/relationship.rb
index 4ff38702..157f316e 100644
--- a/lib/axlsx/rels/relationship.rb
+++ b/lib/axlsx/rels/relationship.rb
@@ -103,7 +103,7 @@ module Axlsx
# @param [String] str
# @return [String]
def to_xml_string(str = '')
- h = Axlsx.instance_values(self).reject{|k, _| k == "source_obj"}
+ h = Axlsx.instance_values_for(self).reject{|k, _| k == "source_obj"}
str << '<Relationship '
str << (h.map { |key, value| '' << key.to_s << '="' << Axlsx::coder.encode(value.to_s) << '"'}.join(' '))
str << '/>'
diff --git a/lib/axlsx/stylesheet/font.rb b/lib/axlsx/stylesheet/font.rb
index 093d160e..48d2b584 100644
--- a/lib/axlsx/stylesheet/font.rb
+++ b/lib/axlsx/stylesheet/font.rb
@@ -147,7 +147,7 @@ module Axlsx
# @return [String]
def to_xml_string(str = '')
str << '<font>'
- Axlsx.instance_values(self).each do |k, v|
+ Axlsx.instance_values_for(self).each do |k, v|
v.is_a?(Color) ? v.to_xml_string(str) : (str << ('<' << k.to_s << ' val="' << Axlsx.booleanize(v).to_s << '"/>'))
end
str << '</font>'
diff --git a/lib/axlsx/stylesheet/styles.rb b/lib/axlsx/stylesheet/styles.rb
index c9fdbf55..6bfd0a52 100644
--- a/lib/axlsx/stylesheet/styles.rb
+++ b/lib/axlsx/stylesheet/styles.rb
@@ -279,7 +279,7 @@ module Axlsx
# @return [Font|Integer]
def parse_font_options(options={})
return if (options.keys & [:fg_color, :sz, :b, :i, :u, :strike, :outline, :shadow, :charset, :family, :font_name]).empty?
- Axlsx.instance_values(fonts.first).each do |key, value|
+ Axlsx.instance_values_for(fonts.first).each do |key, value|
# Thanks for that 1.8.7 - cant do a simple merge...
options[key.to_sym] = value unless options.keys.include?(key.to_sym)
end
@@ -438,7 +438,7 @@ module Axlsx
# @return [String]
def to_xml_string(str = '')
str << ('<styleSheet xmlns="' << XML_NS << '">')
- instance_vals = Axlsx.instance_values(self)
+ instance_vals = Axlsx.instance_values_for(self)
[:numFmts, :fonts, :fills, :borders, :cellStyleXfs, :cellXfs, :cellStyles, :dxfs, :tableStyles].each do |key|
instance_vals[key.to_s].to_xml_string(str) unless instance_vals[key.to_s].nil?
end
diff --git a/lib/axlsx/util/serialized_attributes.rb b/lib/axlsx/util/serialized_attributes.rb
index 5dcb77fc..06d1697a 100644
--- a/lib/axlsx/util/serialized_attributes.rb
+++ b/lib/axlsx/util/serialized_attributes.rb
@@ -61,7 +61,7 @@ module Axlsx
# seraialized_attributes and are not nil.
# This requires ruby 1.9.3 or higher
def declared_attributes
- Axlsx.instance_values(self).select do |key, value|
+ Axlsx.instance_values_for(self).select do |key, value|
value != nil && self.class.xml_attributes.include?(key.to_sym)
end
end
@@ -75,7 +75,7 @@ module Axlsx
# @return [String] The serialized output.
def serialized_element_attributes(str='', additional_attributes=[], &block)
attrs = self.class.xml_element_attributes + additional_attributes
- values = Axlsx.instance_values(self)
+ values = Axlsx.instance_values_for(self)
attrs.each do |attribute_name|
value = values[attribute_name.to_s]
next if value.nil?
diff --git a/lib/axlsx/workbook/worksheet/cell_serializer.rb b/lib/axlsx/workbook/worksheet/cell_serializer.rb
index e51674bc..962b575d 100644
--- a/lib/axlsx/workbook/worksheet/cell_serializer.rb
+++ b/lib/axlsx/workbook/worksheet/cell_serializer.rb
@@ -22,7 +22,7 @@ module Axlsx
def run_xml_string(cell, str = '')
if cell.is_text_run?
valid = RichTextRun::INLINE_STYLES - [:value, :type]
- data = Hash[Axlsx.instance_values(cell).map{ |k, v| [k.to_sym, v] }]
+ data = Hash[Axlsx.instance_values_for(cell).map{ |k, v| [k.to_sym, v] }]
data = data.select { |key, value| valid.include?(key) && !value.nil? }
RichText.new(cell.value.to_s, data).to_xml_string(str)
elsif cell.contains_rich_text?
diff --git a/lib/axlsx/workbook/worksheet/data_validation.rb b/lib/axlsx/workbook/worksheet/data_validation.rb
index a9baca4c..835b5b33 100644
--- a/lib/axlsx/workbook/worksheet/data_validation.rb
+++ b/lib/axlsx/workbook/worksheet/data_validation.rb
@@ -216,7 +216,7 @@ module Axlsx
valid_attributes = get_valid_attributes
str << '<dataValidation '
- str << Axlsx.instance_values(self).map do |key, value|
+ str << Axlsx.instance_values_for(self).map do |key, value|
'' << key << '="' << Axlsx.booleanize(value).to_s << '"' if (valid_attributes.include?(key.to_sym) && !CHILD_ELEMENTS.include?(key.to_sym))
end.join(' ')
str << '>'
diff --git a/lib/axlsx/workbook/worksheet/rich_text_run.rb b/lib/axlsx/workbook/worksheet/rich_text_run.rb
index 7dcf28e9..b3870672 100644
--- a/lib/axlsx/workbook/worksheet/rich_text_run.rb
+++ b/lib/axlsx/workbook/worksheet/rich_text_run.rb
@@ -190,7 +190,7 @@ module Axlsx
# @return [String]
def to_xml_string(str = '')
valid = RichTextRun::INLINE_STYLES
- data = Hash[Axlsx.instance_values(self).map{ |k, v| [k.to_sym, v] }]
+ data = Hash[Axlsx.instance_values_for(self).map{ |k, v| [k.to_sym, v] }]
data = data.select { |key, value| valid.include?(key) && !value.nil? }
str << '<r><rPr>'
diff --git a/lib/axlsx/workbook/worksheet/worksheet.rb b/lib/axlsx/workbook/worksheet/worksheet.rb
index 7204cbf6..d782fefe 100644
--- a/lib/axlsx/workbook/worksheet/worksheet.rb
+++ b/lib/axlsx/workbook/worksheet/worksheet.rb
@@ -168,7 +168,7 @@ module Axlsx
# @return Boolean
# @see #page_setup
def fit_to_page?
- return false unless Axlsx.instance_values(self).keys.include?('page_setup')
+ return false unless Axlsx.instance_values_for(self).keys.include?('page_setup')
page_setup.fit_to_page?
end
diff --git a/test/drawing/tc_chart.rb b/test/drawing/tc_chart.rb
index 5aa2a809..302d13cd 100644
--- a/test/drawing/tc_chart.rb
+++ b/test/drawing/tc_chart.rb
@@ -104,7 +104,7 @@ class TestChart < Test::Unit::TestCase
def test_d_lbls
- assert_equal(nil, Axlsx.instance_values(@chart)[:d_lbls])
+ assert_equal(nil, Axlsx.instance_values_for(@chart)[:d_lbls])
@chart.d_lbls.d_lbl_pos = :t
assert(@chart.d_lbls.is_a?(Axlsx::DLbls), 'DLbls instantiated on access')
end
diff --git a/test/drawing/tc_d_lbls.rb b/test/drawing/tc_d_lbls.rb
index cddfec77..dddde3a1 100644
--- a/test/drawing/tc_d_lbls.rb
+++ b/test/drawing/tc_d_lbls.rb
@@ -50,7 +50,7 @@ class TestDLbls < Test::Unit::TestCase
@d_lbls.to_xml_string(str)
str << '</c:chartSpace>'
doc = Nokogiri::XML(str)
- Axlsx.instance_values(@d_lbls).each do |name, value|
+ Axlsx.instance_values_for(@d_lbls).each do |name, value|
assert(doc.xpath("//c:#{Axlsx::camel(name, false)}[@val='#{value}']"), "#{name} is properly serialized")
end
end
diff --git a/test/drawing/tc_picture_locking.rb b/test/drawing/tc_picture_locking.rb
index 2766026f..c0a828aa 100644
--- a/test/drawing/tc_picture_locking.rb
+++ b/test/drawing/tc_picture_locking.rb
@@ -8,7 +8,7 @@ class TestPictureLocking < Test::Unit::TestCase
end
def test_initialiation
- assert_equal(Axlsx.instance_values(@item).size, 1)
+ assert_equal(Axlsx.instance_values_for(@item).size, 1)
assert_equal(@item.noChangeAspect, true)
end
diff --git a/test/stylesheet/tc_styles.rb b/test/stylesheet/tc_styles.rb
index 1c04abd7..503068c0 100644
--- a/test/stylesheet/tc_styles.rb
+++ b/test/stylesheet/tc_styles.rb
@@ -136,11 +136,11 @@ class TestStyles < Test::Unit::TestCase
original = @styles.fonts.first
@styles.add_style :b => 1, :sz => 99
created = @styles.fonts.last
- original_attributes = Axlsx.instance_values(original)
+ original_attributes = Axlsx.instance_values_for(original)
assert_equal(1, created.b)
assert_equal(99, created.sz)
copied = original_attributes.reject{ |key, value| %w(b sz).include? key }
- instance_vals = Axlsx.instance_values(created)
+ instance_vals = Axlsx.instance_values_for(created)
copied.each do |key, value|
assert_equal(instance_vals[key], value)
end
diff --git a/test/tc_package.rb b/test/tc_package.rb
index aef90315..b07f0d2f 100644
--- a/test/tc_package.rb
+++ b/test/tc_package.rb
@@ -97,12 +97,12 @@ class TestPackage < Test::Unit::TestCase
end
def test_core_accessor
- assert_equal(@package.core, Axlsx.instance_values(@package)["core"])
+ assert_equal(@package.core, Axlsx.instance_values_for(@package)["core"])
assert_raise(NoMethodError) {@package.core = nil }
end
def test_app_accessor
- assert_equal(@package.app, Axlsx.instance_values(@package)["app"])
+ assert_equal(@package.app, Axlsx.instance_values_for(@package)["app"])
assert_raise(NoMethodError) {@package.app = nil }
end
@@ -114,8 +114,8 @@ class TestPackage < Test::Unit::TestCase
end
def test_default_objects_are_created
- assert(Axlsx.instance_values(@package)["app"].is_a?(Axlsx::App), 'App object not created')
- assert(Axlsx.instance_values(@package)["core"].is_a?(Axlsx::Core), 'Core object not created')
+ assert(Axlsx.instance_values_for(@package)["app"].is_a?(Axlsx::App), 'App object not created')
+ assert(Axlsx.instance_values_for(@package)["core"].is_a?(Axlsx::Core), 'Core object not created')
assert(@package.workbook.is_a?(Axlsx::Workbook), 'Workbook object not created')
assert(Axlsx::Package.new.workbook.worksheets.size == 0, 'Workbook should not have sheets by default')
end
diff --git a/test/workbook/worksheet/tc_worksheet_hyperlink.rb b/test/workbook/worksheet/tc_worksheet_hyperlink.rb
index 50ccc390..88a40bc6 100644
--- a/test/workbook/worksheet/tc_worksheet_hyperlink.rb
+++ b/test/workbook/worksheet/tc_worksheet_hyperlink.rb
@@ -23,7 +23,7 @@ class TestWorksheetHyperlink < Test::Unit::TestCase
def test_target
- assert_equal(@options[:target], Axlsx.instance_values(@a)['target'])
+ assert_equal(@options[:target], Axlsx.instance_values_for(@a)['target'])
end
def test_display
generated by cgit v1.2.3 (git 2.39.1) at 2026-04-14 20:15:39 +0000