| Age | Commit message (Collapse) | Author |
|---|
|
- Use literal syntax on single line
- Use lambda method on multiple lines
Ref: https://rubystyle.guide/#lambda-multi-line
|
|
Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke
methods on `Axlsx` module.
This commit standardizes the approach towards `.`, which will also allow
shorter lines.
Performance is not affected
```
Comparison:
Axlsx.validate: 8515252.3 i/s
Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error
```
|
|
This commit fixes cases that cannot be detected by RuboCop
Ref: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/FormatString
|
|
`%` is an operation on `String` that will return a new `String`, so
the interpolation is redundant
Also adds a missing spec on PivotTable#rels_pn
```
IPS:
uninterpolated: 4045715.7 i/s
interpolated: 2359775.6 i/s - 1.71x (± 0.00) slower
Memory:
uninterpolated: 160 allocated
interpolated: 232 allocated - 1.45x more
```
|
|
|
|
Currently, there are lots of examples of code like this,
```
str << ('<tag ' << foo << ' ' << bar << '/>')
```
which create the string for the tag in memory before piping to str.
We can avoid creating all of these intermediate strings by dropping
the paranthesis and piping directly to str.
This relies on the `str` passed around to handle lots of small
appends. This is a problem when using RubyZip, but that is solved
in the next commit.
|
|
|
|
|
|
- Lint/RedundantStringCoercion
- Style/CommentAnnotation offenses
- Style/DefWithParentheses
- Style/EvalWithLocation
- Style/MethodCallWithoutArgsParentheses
- Style/MethodDefParentheses
- Style/NilComparison
- Style/Semicolon
|
|
```
rubocop --only Layout/LeadingCommentSpace -a
```
|
|
- Layout/SpaceAfterComma
- Layout/SpaceAroundEqualsInParameterDefault
- Layout/SpaceAroundOperators
- Layout/SpaceBeforeBlockBraces
- Layout/SpaceInsideBlockBraces
- Layout/SpaceInsideHashLiteralBraces
- Layout/SpaceInsideParens
|
|
|
|
```
rubocop --only Style/Encoding -a
```
|
|
Until now this setting was not present in the generated XML. According to the ECMA spec the setting defaults to true, so charts always had rounded corners.
Now rounded corners can be disabled explicitly.
|
|
Until now this setting was hardcoded to `true`.
The setting affects whether data from hidden cells (cells width zero height or width) is used when plotting the chart.
|
|
Before this change, a chart with a blank title would show up in Excel with a default title like “Chart title” or “Diagrammtitel”.
It was not possible to completely hide a chart title: Setting it to an empty space would override Excel’s default, but the empty title did still occupy vertical space.
Per OOXML standard the `title` element is optional, so omitting it if the title is blank looks like the right thing to do and seems to work correctly in Excel.
|
|
|
|
Signed-off-by: Erik Veijola <[email protected]>
|
|
Background color option for charts
|
|
|
|
|
|
|
|
|
|
Do not create huge strings
Let Row inherit from SimpleTypedList
Optimized sanitizing
Optimized validation
And more..
|
|
Relationship instances now keep track of their own id – this should be much more reliable than the old way of more or less “guessing” the relationship id based on the position of some object in some array. Fixes https://github.com/randym/axlsx/issues/212, especially.
Each relationship now has its own, unique id – except for the cases when it doesn’t: Some relationships need to share the same id, see `Relation#should_use_same_id_as?` for the gory details.
All tests pass, and the full example.xlsx is generated without errors and looks fine in Excel for Mac 2011.
The pivot table example still has the problems mentioned in https://github.com/randym/axlsx/issues/168 – but as far as I can tell I didn’t make it worse (Excel is still be able to “repair” the file, and the repaired file then contains the pivot table).
|
|
makes it into XML)
This means there are many other test cases in the suite that are not verifying what they look like they're verifying.
|
|
|
|
This sets the proper default for each chart type and lets us change it
as we need.
|
|
This should fix #160
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
exporting to pdf from LibraOffice
|
|
|
|
|
|
sensible defaults. Improve chart positioning defaults.
|
|
|
|
|
|
|
|
prior to dropping Nokogiri dep in production.
|
|
two fold.
```
user system total real
axlsx_noautowidth 0.810000 0.020000 0.830000 ( 0.836274)
axlsx 1.430000 0.160000 1.590000 ( 1.776305)
axlsx_shared 9.360000 0.160000 9.520000 ( 9.662113)
axlsx_stream 1.320000 0.110000 1.430000 ( 1.429806)
csv 0.260000 0.020000 0.280000 ( 0.296828)
|
|
|
|
"Method calls with expanded arrays require parentheses"
Thanks rspec - I didn't know that.
|
|
allow us to inter-op properly with Numbers
|
|
https://github.com/randym/axlsx/issues/19
|
|
in excel 2011
|
