summaryrefslogtreecommitdiffhomepage
path: root/lib/axlsx/drawing/d_lbls.rb
AgeCommit message (Collapse)Author
2023-06-15Fix redundant self offensesGeremia Taglialatela
No performance gain, this can be seen as a cosmetic change to have shorter lines
2023-06-10Fix safe Style/ColonMethodCall offensesGeremia Taglialatela
Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke methods on `Axlsx` module. This commit standardizes the approach towards `.`, which will also allow shorter lines. Performance is not affected ``` Comparison: Axlsx.validate: 8515252.3 i/s Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error ```
2023-05-22Fix Style/NonNilCheck offensesGeremia Taglialatela
There were 8 occurrences of `!nil?` and 4 of `!= nil`. This change will standardize the usage of non-nil checks
2023-05-21Improve commentsGeremia Taglialatela
- Use https where possible - Capitalize Excel
2023-05-10Fix Inefficient Hash Search offensesGeremia Taglialatela
Use `key?` instead of `keys.include?` to improve performance
2023-05-04Fix tests / code to work with frozen string literalsPaul Kmiec
2023-05-04Enable Style/FrozenStringLiteralComment and autocorrectPaul Kmiec
2023-04-10Fix Layout/LeadingCommentSpace offensesGeremia Taglialatela
``` rubocop --only Layout/LeadingCommentSpace -a ```
2023-04-09Fix Layout/ExtraSpacing offensesGeremia Taglialatela
Configure with `AllowBeforeTrailingComments: true`
2023-04-08Fix Layout/EmptyLineAfterGuardClause offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLineAfterGuardClause -a ```
2023-04-08Fix space-related offensesGeremia Taglialatela
- Layout/SpaceAfterComma - Layout/SpaceAroundEqualsInParameterDefault - Layout/SpaceAroundOperators - Layout/SpaceBeforeBlockBraces - Layout/SpaceInsideBlockBraces - Layout/SpaceInsideHashLiteralBraces - Layout/SpaceInsideParens
2023-04-08Fix EmptyLines related offensesGeremia Taglialatela
2023-04-06Fix Layout/EmptyLines offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLines -a ```
2023-04-06Remove Layout/TrailingWhitespace offensesGeremia Taglialatela
``` rubocop --only Layout/TrailingWhitespace -a ```
2022-03-02instance_values -> instance_values_forpjskennedy
2022-03-02Update references to use new class methodpjskennedy
2020-07-09fix typo in documentation for label_position (#52)Viktor Polyakov
2015-08-07allow to use d_lbl_pos for LineChartRuslan Kornev
2013-03-17Fixed LineChart and refactored chart axes managementRandy Morgan
2012-10-14Refactored to use options parserRandy Morgan
2012-10-09extracted accessor methods into module that is scope because polluting ↵Randy Morgan
Module or Class is just not cool
2012-09-30Extracted STRING_ATTRIBUTES and BOOLEAN_ATTRIBUTES into mixin from moduleRandy Morgan
replaced with attr_accessor like methods: string_attr_accessor boolean_attr_accessor defined in module.rb
2012-09-30Extracted boolean attribute class method generation to module.Randy Morgan
2012-08-04pre-release prepRandy Morgan
clean up .yardops and basic documentation for serialization helpers
2012-08-02bring coverage up to 100% for d_lbls and defined namesRandy Morgan
release prep!
2012-07-31Adding in proper defined names so we can repeat header rows for each printed ↵Randy Morgan
page.
2012-07-23more cleanup for optional data label attributesRandy Morgan
2012-07-20data labels for bar and line chartsRandy Morgan
2012-07-20bring spec coverage back up to 100%Randy Morgan
2012-07-20specs for d_lbls and a patch to cover for nil relationships in a worksheet.Randy Morgan
2012-07-18dynamic docs… hmmmRandy Morgan
2012-07-18#113 implement data labels for pie chartsRandy Morgan