summaryrefslogtreecommitdiffhomepage
path: root/lib/axlsx/drawing/drawing.rb
AgeCommit message (Collapse)Author
2023-06-15Fix redundant self offensesGeremia Taglialatela
No performance gain, this can be seen as a cosmetic change to have shorter lines
2023-06-05Prefer `Kernel#format` to `String#%`Geremia Taglialatela
This commit fixes cases that cannot be detected by RuboCop Ref: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/FormatString
2023-06-05Fix Style/RedundantInterpolation offensesGeremia Taglialatela
`%` is an operation on `String` that will return a new `String`, so the interpolation is redundant Also adds a missing spec on PivotTable#rels_pn ``` IPS: uninterpolated: 4045715.7 i/s interpolated: 2359775.6 i/s - 1.71x (± 0.00) slower Memory: uninterpolated: 160 allocated interpolated: 232 allocated - 1.45x more ```
2023-05-31Fix Style/SymbolProc offensesGeremia Taglialatela
This also provides a performance improvement ``` Comparison (array of 4 elements): map(&): 3643131.4 i/s map {}: 3488052.5 i/s - 1.04x (± 0.00) slower Comparison (array of 20 elements): map(&): 466013.9 i/s map {}: 408447.2 i/s - 1.14x (± 0.00) slower ```
2023-05-24Fix Style/RedundantFileExtensionInRequire offensesGeremia Taglialatela
2023-05-05Pipe output directly to str and avoid additional memory allocationsPaul Kmiec
Currently, there are lots of examples of code like this, ``` str << ('<tag ' << foo << ' ' << bar << '/>') ``` which create the string for the tag in memory before piping to str. We can avoid creating all of these intermediate strings by dropping the paranthesis and piping directly to str. This relies on the `str` passed around to handle lots of small appends. This is a problem when using RubyZip, but that is solved in the next commit.
2023-05-04Fix tests / code to work with frozen string literalsPaul Kmiec
2023-05-04Enable Style/FrozenStringLiteralComment and autocorrectPaul Kmiec
2023-04-08Fix space-related offensesGeremia Taglialatela
- Layout/SpaceAfterComma - Layout/SpaceAroundEqualsInParameterDefault - Layout/SpaceAroundOperators - Layout/SpaceBeforeBlockBraces - Layout/SpaceInsideBlockBraces - Layout/SpaceInsideHashLiteralBraces - Layout/SpaceInsideParens
2023-04-08Fix EmptyLines related offensesGeremia Taglialatela
2023-04-06Fix Layout/EmptyLines offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLines -a ```
2023-04-06Fix Style/Encoding offensesGeremia Taglialatela
``` rubocop --only Style/Encoding -a ```
2017-11-17Add support for non-3D bar chartsDavid N. Robinson
2017-11-07Add support for area chartsDavid N. Robinson
2014-02-26Huge refactoringJurriaan Pruis
Do not create huge strings Let Row inherit from SimpleTypedList Optimized sanitizing Optimized validation And more..
2013-10-09Add support for bubble chartsJean-Philippe Moal
2013-09-13Fixes for anchor swapping when adding images. - Two -> One swap still pending.Randy Morgan
2013-07-08Make relationship ids more reliable.Stefan Daschek
Relationship instances now keep track of their own id – this should be much more reliable than the old way of more or less “guessing” the relationship id based on the position of some object in some array. Fixes https://github.com/randym/axlsx/issues/212, especially. Each relationship now has its own, unique id – except for the cases when it doesn’t: Some relationships need to share the same id, see `Relation#should_use_same_id_as?` for the gory details. All tests pass, and the full example.xlsx is generated without errors and looks fine in Excel for Mac 2011. The pivot table example still has the problems mentioned in https://github.com/randym/axlsx/issues/168 – but as far as I can tell I didn’t make it worse (Excel is still be able to “repair” the file, and the repaired file then contains the pivot table).
2013-03-17Fixed LineChart and refactored chart axes managementRandy Morgan
2013-03-14fix loading LineChartSergio Cambra
2013-02-04Added docs for Drawing#child_objectsRandy Morgan
2013-01-15Refactored relationship management for drawingsRandy Morgan
This should fix #160
2012-10-21Added index_of to drawing for finding the position of a chart, image or ↵Randy Morgan
hyperlink
2012-07-18#113 implement data labels for pie chartsRandy Morgan
2012-07-17MOAR cleanup for worksheet.Randy Morgan
2012-07-10more cleanupRandy Morgan
2012-06-02quick fix for chart rendering problem. Randy Morgan
Need to ensure that we are not pushing odd strings into a number data axis point. This should at least make sure we get a nice fat 0 for now, but it really needs a bit more than this.
2012-05-26add in two cell anchors for images.Randy Morgan
2012-05-08worksheet comments step 2. Needs docs and specs - but it works in ExcelRandy Morgan
2012-05-04remove unneeded namespace in drawing.Randy Morgan
2012-05-03rebuild series data base objects with full implementation.Randy Morgan
Address shape validation error.
2012-04-28val_axis_data removed so there is no point in trying to include it.Randy Morgan
2012-04-03pre-release cleanupRandy Morgan
2012-04-01rebuild all serialization to use string concatenation instead of nokogiri.Randy Morgan
2012-04-01part way through changing all serialization to use string concatenation ↵Randy Morgan
prior to dropping Nokogiri dep in production.
2012-03-22Add Scatter chartsJoe Kain
2012-02-12Adding in support for optionally using the shared strings table. This will ↵Randy Morgan
allow us to inter-op properly with Numbers
2012-02-02Adding in hyperlinking for images as per issue #22Randy Morgan
2012-01-18remove linebreaks/indentation when saving to encourage interop with rubyXLRandy Morgan
https://github.com/randym/axlsx/issues/19
2011-12-08cleaning up xml namespace usage in drawings and improving looks for charts ↵Randy Morgan
in excel 2011
2011-12-02Added locking attributes for pictures and some stubs for parsingRandy Morgan
2011-11-26adding in support for ruby 1.9.3Randy Morgan
release version 1.0.9
2011-11-23Adding image support and some document clean up for .8 releaseRandy Morgan
2011-11-23-refactoring chart position and axis data/category for chart.Randy Morgan
-additional specs and documentation improvements.
2011-11-21Adding in support for line charts, style attribute for all charts and minor ↵Randy Morgan
bug fixes.
2011-11-20first commitRandy Morgan
generated by cgit v1.2.3 (git 2.39.1) at 2026-04-17 05:53:26 +0000