summaryrefslogtreecommitdiffhomepage
path: root/lib/axlsx/workbook/defined_name.rb
AgeCommit message (Collapse)Author
2023-06-10Fix safe Style/ColonMethodCall offensesGeremia Taglialatela
Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke methods on `Axlsx` module. This commit standardizes the approach towards `.`, which will also allow shorter lines. Performance is not affected ``` Comparison: Axlsx.validate: 8515252.3 i/s Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error ```
2023-05-05Pipe output directly to str and avoid additional memory allocationsPaul Kmiec
Currently, there are lots of examples of code like this, ``` str << ('<tag ' << foo << ' ' << bar << '/>') ``` which create the string for the tag in memory before piping to str. We can avoid creating all of these intermediate strings by dropping the paranthesis and piping directly to str. This relies on the `str` passed around to handle lots of small appends. This is a problem when using RubyZip, but that is solved in the next commit.
2023-05-04Fix tests / code to work with frozen string literalsPaul Kmiec
2023-05-04Enable Style/FrozenStringLiteralComment and autocorrectPaul Kmiec
2023-04-10Fix Layout/LeadingCommentSpace offensesGeremia Taglialatela
``` rubocop --only Layout/LeadingCommentSpace -a ```
2023-04-09Fix Layout/ArgumentAlignment offensesGeremia Taglialatela
``` rubocop --only Layout/ArgumentAlignment -a ```
2023-04-08Fix Layout/EmptyLineAfterGuardClause offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLineAfterGuardClause -a ```
2023-04-08Fix space-related offensesGeremia Taglialatela
- Layout/SpaceAfterComma - Layout/SpaceAroundEqualsInParameterDefault - Layout/SpaceAroundOperators - Layout/SpaceBeforeBlockBraces - Layout/SpaceInsideBlockBraces - Layout/SpaceInsideHashLiteralBraces - Layout/SpaceInsideParens
2014-02-26Huge refactoringJurriaan Pruis
Do not create huge strings Let Row inherit from SimpleTypedList Optimized sanitizing Optimized validation And more..
2014-02-26Add missing change from 4400e233c (refs #285)Jonathan Tron
2014-02-26Do not put Axlsx::DefinedName#name in serialized_attributes (fixes #285)Jonathan Tron
When using serialized_attributes both attribute's name and value are camelcased, in `Axlsx::DefinedName` the values starts with `_xmln` which is then transformed in `Xmln`. The fix proposed on #285 does not work because then other `Axlsx::DefinedName` attributes name are no more camelcased (`localSheetId` become `local_sheet_id` for instance). As proposed by @randym in #285, this commit only make a special case of the name and let the other attributes go through serialized_attributes. Adding a test on it revealed a wrong test which would have catched similar error but was not because of value returned by `doc.xpath`.
2013-08-06Fix minor typosMartin madsen
2012-10-18Added support for custom defined names by removing _xlnm prefixed values ↵Randy Morgan
validation
2012-10-14Refactored to use options parser, accessors and serialization attributesRandy Morgan
2012-10-09extracted accessor methods into module that is scope because polluting ↵Randy Morgan
Module or Class is just not cool
2012-09-30Forgot to add these files to last commit!Randy Morgan
extraction refactoring
2012-09-30Extracted String Attribute method generation.Randy Morgan
2012-09-30Extracted boolean attribute class method generation to module.Randy Morgan
2012-08-02hmm…. ditch red carpet and do some docsRandy Morgan
2012-08-02bring coverage up to 100% for d_lbls and defined namesRandy Morgan
release prep!
2012-07-31fix typo and update readmeRandy Morgan
2012-07-31Adding in proper defined names so we can repeat header rows for each printed ↵Randy Morgan
page.