| Age | Commit message (Collapse) | Author |
|
Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke
methods on `Axlsx` module.
This commit standardizes the approach towards `.`, which will also allow
shorter lines.
Performance is not affected
```
Comparison:
Axlsx.validate: 8515252.3 i/s
Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error
```
|
|
Currently, there are lots of examples of code like this,
```
str << ('<tag ' << foo << ' ' << bar << '/>')
```
which create the string for the tag in memory before piping to str.
We can avoid creating all of these intermediate strings by dropping
the paranthesis and piping directly to str.
This relies on the `str` passed around to handle lots of small
appends. This is a problem when using RubyZip, but that is solved
in the next commit.
|
|
|
|
|
|
```
rubocop --only Layout/LeadingCommentSpace -a
```
|
|
```
rubocop --only Layout/ArgumentAlignment -a
```
|
|
```
rubocop --only Layout/EmptyLineAfterGuardClause -a
```
|
|
- Layout/SpaceAfterComma
- Layout/SpaceAroundEqualsInParameterDefault
- Layout/SpaceAroundOperators
- Layout/SpaceBeforeBlockBraces
- Layout/SpaceInsideBlockBraces
- Layout/SpaceInsideHashLiteralBraces
- Layout/SpaceInsideParens
|
|
Do not create huge strings
Let Row inherit from SimpleTypedList
Optimized sanitizing
Optimized validation
And more..
|
|
|
|
When using serialized_attributes both attribute's name and value are camelcased, in
`Axlsx::DefinedName` the values starts with `_xmln` which is then
transformed in `Xmln`.
The fix proposed on #285 does not work because then other `Axlsx::DefinedName`
attributes name are no more camelcased (`localSheetId` become
`local_sheet_id` for instance).
As proposed by @randym in #285, this commit only make a special case of
the name and let the other attributes go through serialized_attributes.
Adding a test on it revealed a wrong test which would have catched
similar error but was not because of value returned by `doc.xpath`.
|
|
|
|
validation
|
|
|
|
Module or Class is just not cool
|
|
extraction refactoring
|
|
|
|
|
|
|
|
release prep!
|
|
|
|
page.
|