summaryrefslogtreecommitdiffhomepage
path: root/lib/axlsx/workbook/worksheet/comment.rb
AgeCommit message (Collapse)Author
2023-06-10Fix safe Style/ColonMethodCall offensesGeremia Taglialatela
Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke methods on `Axlsx` module. This commit standardizes the approach towards `.`, which will also allow shorter lines. Performance is not affected ``` Comparison: Axlsx.validate: 8515252.3 i/s Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error ```
2023-05-31Use Ruby 1.9 hash syntaxGeremia Taglialatela
2023-05-05Pipe output directly to str and avoid additional memory allocationsPaul Kmiec
Currently, there are lots of examples of code like this, ``` str << ('<tag ' << foo << ' ' << bar << '/>') ``` which create the string for the tag in memory before piping to str. We can avoid creating all of these intermediate strings by dropping the paranthesis and piping directly to str. This relies on the `str` passed around to handle lots of small appends. This is a problem when using RubyZip, but that is solved in the next commit.
2023-05-04Fix tests / code to work with frozen string literalsPaul Kmiec
2023-05-04Enable Style/FrozenStringLiteralComment and autocorrectPaul Kmiec
2023-04-09Fix offenses related to indentation consistencyGeremia Taglialatela
2023-04-08Fix Layout/EmptyLineAfterGuardClause offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLineAfterGuardClause -a ```
2023-04-08Fix space-related offensesGeremia Taglialatela
- Layout/SpaceAfterComma - Layout/SpaceAroundEqualsInParameterDefault - Layout/SpaceAroundOperators - Layout/SpaceBeforeBlockBraces - Layout/SpaceInsideBlockBraces - Layout/SpaceInsideHashLiteralBraces - Layout/SpaceInsideParens
2023-04-08Fix EmptyLines related offensesGeremia Taglialatela
2023-04-06Remove Layout/TrailingWhitespace offensesGeremia Taglialatela
``` rubocop --only Layout/TrailingWhitespace -a ```
2014-02-26Huge refactoringJurriaan Pruis
Do not create huge strings Let Row inherit from SimpleTypedList Optimized sanitizing Optimized validation And more..
2013-07-03Do not start comment text with stray colon if author is blankStefan Daschek
2013-07-03Escape special chars for comments’ text and author.Stefan Daschek
2013-03-16First run at 'hidden' comments WIPRandy Morgan
The xml is genrated correcty, but the comment still shows until it is selected once in the excel ui - so I must be missing something.
2012-10-14Refactored to use options parser and serialized attributes.Randy Morgan
2012-05-19correct relation management for comments and some spec improvements for ↵Randy Morgan
package to provide more breadth in serialization integration testing.
2012-05-15bring coverage up to 100% and patch a few minor bugs in cell style overrides ↵Randy Morgan
and misnamed app attributes.
2012-05-13cleaning up comments for pre-releaseRandy Morgan
2012-05-09patch nil row style issueRandy Morgan
https://github.com/randym/axlsx/issues/91
2012-05-08documentation for comments.Randy Morgan