summaryrefslogtreecommitdiffhomepage
path: root/test/drawing
AgeCommit message (Collapse)Author
2023-10-19Fix frozen string error for scatter series with non-default markerKoza
2023-06-10Fix safe Style/ColonMethodCall offensesGeremia Taglialatela
Caxlsx is using both `.` and `::`, 220 occurrences vs 280 to invoke methods on `Axlsx` module. This commit standardizes the approach towards `.`, which will also allow shorter lines. Performance is not affected ``` Comparison: Axlsx.validate: 8515252.3 i/s Axlsx::validate: 8512863.7 i/s - same-ish: difference falls within error ```
2023-06-05Fix Style/FormatString offensesGeremia Taglialatela
`Kernel#format` is faster and will avoid to allocate an array compared to `String#%`. ``` IPS: kernel_format: 3877614.2 i/s string_percent: 3531475.0 i/s - 1.10x (± 0.00) slower Memory: kernel_format: 160 allocated string_percent: 200 allocated - 1.25x more ```
2023-05-25Fix StringConcatenation offenses (non-production)Geremia Taglialatela
Prefer interpolation over concatenation ``` Comparison ("String#{'String'}" vs 'String' + 'String'): interpolation: 11821321.0 i/s concatenation: 8849491.7 i/s - 1.34x (± 0.00) slower ```
2023-05-22Use Ruby 1.9 hash syntax (non-production code)Geremia Taglialatela
2023-05-04Fix tests / code to work with frozen string literalsPaul Kmiec
2023-05-04Enable Style/FrozenStringLiteralComment and autocorrectPaul Kmiec
2023-05-03Fix Style/MapToHash offense (unsafe)Geremia Taglialatela
2023-05-03Fix non-production Style/NumericLiterals offensesGeremia Taglialatela
2023-05-03Remove redundant load pathsGeremia Taglialatela
2023-05-03Fix Style/RedundantFileExtensionInRequire offenseGeremia Taglialatela
2023-05-03Add RuboCop MinitestGeremia Taglialatela
2023-05-03Fix offenses to non-production codeGeremia Taglialatela
- Lint/AmbiguousBlockAssociation - Lint/AmbiguousOperatorPrecedence - Lint/EmptyBlock - Lint/RedundantSplatExpansion - Lint/RedundantStringCoercion - Lint/SymbolConversion - Lint/UnusedBlockArgument - Style/BlockDelimiters - Style/CommentAnnotation - Style/EachForSimpleLoop - Style/EmptyMethod - Style/ExpandPathArguments - Style/FileWrite - Style/GlobalStdStream (UNSAFE) - Style/HashEachMethods (UNSAFE) - Style/NestedParenthesizedCalls - Style/NilComparison - Style/NumericLiteralPrefix (manually fixed) - Style/ParallelAssignment - Style/PreferredHashMethods (UNSAFE) - Style/RedundantInterpolation (UNSAFE) - Style/RedundantParentheses (UNSAFE) - Style/RegexpLiteral - Style/RescueStandardError - Style/SpecialGlobalVars (UNSAFE) - Style/SymbolProc (UNSAFE) - Style/ZeroLengthPredicate (UNSAFE)
2023-04-12Mock out external image requests to make the CI more stableKoza
2023-04-12Rubocop fixesKoza
2023-04-12improve testsSebastiano
2023-04-12improve validationSebastiano
add test cases
2023-04-10Fix Layout/LeadingCommentSpace offensesGeremia Taglialatela
``` rubocop --only Layout/LeadingCommentSpace -a ```
2023-04-09Fix Layout/ExtraSpacing offensesGeremia Taglialatela
Configure with `AllowBeforeTrailingComments: true`
2023-04-09Fix offenses related to indentation consistencyGeremia Taglialatela
2023-04-08Fix space-related offensesGeremia Taglialatela
- Layout/SpaceAfterComma - Layout/SpaceAroundEqualsInParameterDefault - Layout/SpaceAroundOperators - Layout/SpaceBeforeBlockBraces - Layout/SpaceInsideBlockBraces - Layout/SpaceInsideHashLiteralBraces - Layout/SpaceInsideParens
2023-04-08Fix EmptyLines related offensesGeremia Taglialatela
2023-04-07Fix Layout/SpaceInsideReferenceBrackets offenseGeremia Taglialatela
``` rubocop --only Layout/SpaceInsideReferenceBrackets -a ```
2023-04-06Fix Layout/EmptyLineBetweenDefs offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLineBetweenDefs -a ```
2023-04-06Fix Layout/EmptyLines offensesGeremia Taglialatela
``` rubocop --only Layout/EmptyLines -a ```
2023-04-06Fix Layout/InitialIndentation offenseGeremia Taglialatela
``` rubocop --only Layout/InitialIndentation -a ```
2023-04-06Fix Layout/TrailingEmptyLines offensesGeremia Taglialatela
``` rubocop --only Layout/TrailingEmptyLines -a ```
2023-04-06Remove Layout/TrailingWhitespace offensesGeremia Taglialatela
``` rubocop --only Layout/TrailingWhitespace -a ```
2022-06-05Implement “rounded corners” setting for chartsStefan
Until now this setting was not present in the generated XML. According to the ECMA spec the setting defaults to true, so charts always had rounded corners. Now rounded corners can be disabled explicitly.
2022-06-01Implement “plot visible only” setting for chartsStefan
Until now this setting was hardcoded to `true`. The setting affects whether data from hidden cells (cells width zero height or width) is used when plotting the chart.
2022-05-18Completely hide chart titles if blankStefan
Before this change, a chart with a blank title would show up in Excel with a default title like “Chart title” or “Diagrammtitel”. It was not possible to completely hide a chart title: Setting it to an empty space would override Excel’s default, but the empty title did still occupy vertical space. Per OOXML standard the `title` element is optional, so omitting it if the title is blank looks like the right thing to do and seems to work correctly in Excel.
2022-05-18Fix missing cell reference for chart title when cell emptyStefan
Before this change, creating a chart title referencing an empty cell would lose the cell reference. If the cell was later set to a non-blank value (either during generating the file, or while editing it in a spreadsheet app), the chart title would stay blank.
2022-03-02instance_values -> instance_values_forpjskennedy
2022-03-02Update references to use new class methodpjskennedy
2022-02-07Merge branch 'master' into feature/manageable-scatter-markersOleg Yakovenko
2021-07-25Fix gap width validator for bar charts (#108)Zsolt Kozaroczy
`gap_width` and `gap_depth` now allow only integers in the range of 0–500. The previous behaviour (requiring a percentage value) was according to the current version of the OOXML spec, but Excel seems to rely on an older version, where the gap amount was required to be a simple integer. Also, `gapDepth` is only allowed in 3D bar charts, so it is now no longer available for 2D bar charts.
2021-07-24Add overlap to bar charts (#107)Zsolt Kozaroczy
2021-04-26Add option to define a series color for the BarSeries (#81)Zsolt Kozaroczy
2021-03-01feature: spec cleanupOleg Yakovenko
2021-03-01feature: marker symbol management for scatter seriesOleg Yakovenko
2021-03-01feature: scatter series should respect marker preference of parent chartOleg Yakovenko
2020-09-11Restructure examples folder (#47)Zsolt Kozaroczy
Split examples into separate markdown files, each containing a description, sample code, and a screenshot of the resulting xlsx document. The script `generate.rb` is provided to actually generate the example documents by executing the sample code contained in the markdown files.
2020-08-24Explosion explosion fixed - issue 58Noel Peden
2019-12-29Escape special characters in charts (#40)Zsolt Kozaroczy
Fixes #37
2018-02-08chore(coverage): 100% coverage, 100% docsrandym
2018-02-08chore(coverage) increase coverage and cleanuprandym
2018-02-06Merge branch 'master' into release-3.0.0randym
2017-11-17Add support for non-3D bar chartsDavid N. Robinson
2017-11-07Add support for area chartsDavid N. Robinson
2017-04-01chore(test): update tests for depreciated methodsrandym