1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
import type { Workspace, WorkspaceEntry } from "@dispatch/wire";
import { describe, expect, it, vi } from "vitest";
import type { WorkspaceResult } from "./adapter/http";
import { createWorkspaceStore } from "./store.svelte";
function entry(overrides: Partial<WorkspaceEntry> = {}): WorkspaceEntry {
return {
id: "a",
title: "A",
defaultCwd: null,
defaultComputerId: null,
starred: false,
createdAt: 1,
lastActivityAt: 2,
conversationCount: 0,
...overrides,
};
}
/** A fake `WorkspaceHttp` with stubbed star/unstar + a controllable list. */
function fakeHttp(opts: {
list?: readonly WorkspaceEntry[];
star?: (id: string) => Promise<WorkspaceResult<Workspace>>;
unstar?: (id: string) => Promise<WorkspaceResult<Workspace>>;
}) {
return {
list: vi.fn(async (): Promise<readonly WorkspaceEntry[]> => opts.list ?? []),
ensure: vi.fn(),
get: vi.fn(),
setTitle: vi.fn(),
setDefaultCwd: vi.fn(),
setDefaultComputer: vi.fn(),
star:
opts.star ??
vi.fn(
async (id: string): Promise<WorkspaceResult<Workspace>> => ({
ok: true,
value: entry({ id, starred: true }),
}),
),
unstar:
opts.unstar ??
vi.fn(
async (id: string): Promise<WorkspaceResult<Workspace>> => ({
ok: true,
value: entry({ id, starred: false }),
}),
),
delete: vi.fn(),
};
}
describe("createWorkspaceStore — setStarred", () => {
it("optimistically flips starred to true before the request resolves", async () => {
const http = fakeHttp({ list: [entry({ id: "a", starred: false })] });
const store = createWorkspaceStore(http);
await store.refresh();
let observedDuringCall = false;
http.star = vi.fn(async (_id: string): Promise<WorkspaceResult<Workspace>> => {
// While the request is in flight, the store already shows the new state.
observedDuringCall = store.list[0]?.starred === true;
return { ok: true, value: entry({ id: "a", starred: true }) };
});
await store.setStarred("a", true);
expect(observedDuringCall).toBe(true);
expect(http.star).toHaveBeenCalledWith("a");
expect(store.list[0]?.starred).toBe(true);
});
it("calls unstar (DELETE) when starring false", async () => {
const http = fakeHttp({ list: [entry({ id: "a", starred: true })] });
const store = createWorkspaceStore(http);
await store.refresh();
await store.setStarred("a", false);
expect(http.unstar).toHaveBeenCalledWith("a");
expect(http.star).not.toHaveBeenCalled();
expect(store.list[0]?.starred).toBe(false);
});
it("reverts the optimistic flip on error", async () => {
const http = fakeHttp({ list: [entry({ id: "a", starred: false })] });
const store = createWorkspaceStore(http);
await store.refresh();
http.star = vi.fn(
async (): Promise<WorkspaceResult<Workspace>> => ({ ok: false, error: "boom" }),
);
const result = await store.setStarred("a", true);
expect(result).toEqual({ ok: false, error: "boom" });
// Reverted to the prior value.
expect(store.list[0]?.starred).toBe(false);
});
it("does not set the store-wide load error on a star failure", async () => {
const http = fakeHttp({ list: [entry({ id: "a", starred: false })] });
const store = createWorkspaceStore(http);
await store.refresh();
http.star = vi.fn(
async (): Promise<WorkspaceResult<Workspace>> => ({ ok: false, error: "boom" }),
);
await store.setStarred("a", true);
expect(store.error).toBeNull();
});
it("re-sorts so starred workspaces bubble to the top", async () => {
const http = fakeHttp({
list: [
entry({ id: "plain", starred: false, lastActivityAt: 9_000 }),
entry({ id: "star", starred: false, lastActivityAt: 1_000 }),
],
});
const store = createWorkspaceStore(http);
await store.refresh();
// Before: backend order (most-active first).
expect(store.list.map((w) => w.id)).toEqual(["plain", "star"]);
await store.setStarred("star", true);
// After: starred jumps above the more-recent unstarred workspace.
expect(store.list.map((w) => w.id)).toEqual(["star", "plain"]);
});
it("treats a missing id as not-starred and still calls through (create-on-miss)", async () => {
const http = fakeHttp({ list: [] });
const store = createWorkspaceStore(http);
await store.refresh();
const result = await store.setStarred("ghost", true);
expect(result.ok).toBe(true);
expect(http.star).toHaveBeenCalledWith("ghost");
// The list is unchanged (the workspace wasn't loaded); a refresh reconciles.
expect(store.list).toHaveLength(0);
});
});
|