diff options
| author | Adam Malczewski <[email protected]> | 2026-06-05 01:35:50 +0900 |
|---|---|---|
| committer | Adam Malczewski <[email protected]> | 2026-06-05 01:35:50 +0900 |
| commit | 94dd5334b0277f3cf3b0588150a6615af86a32b3 (patch) | |
| tree | 53b1b327790ae43bd3b7cbabe555b832f3e27248 /GLOSSARY.md | |
| parent | 977ca522736bba53172e010494de5ac59fdb2a4a (diff) | |
| download | dispatch-94dd5334b0277f3cf3b0588150a6615af86a32b3.tar.gz dispatch-94dd5334b0277f3cf3b0588150a6615af86a32b3.zip | |
refactor(kernel): rename tabId → conversationId across contracts + consumers (218 tests)
Step 4 of the post-MVP backlog: resolve the last vocab drift. The canonical
term for a thread of turns is `conversationId` (GLOSSARY), but `AgentEvent`
variants and `RunTurnInput` still used the legacy `tabId` from the old frontend
"tab" concept, with session-orchestrator bridging `conversationId → tabId`.
Atomic, type-driven rename across the full 10-file consumer set:
- contracts/events.ts: all 11 AgentEvent variants tabId → conversationId
- contracts/runtime.ts: RunTurnInput.tabId → conversationId
- runtime/{events,run-turn,dispatch}.ts: factory params, ctx field, locals
- session-orchestrator: drop the redundant `tabId: conversationId` bridge line
- transport-http: emit wiring; external /chat field + X-Conversation-Id header
unchanged (already canonical) — only the emitted NDJSON event field flips
- tests (run-turn, app, logic): inputs + assertions now use conversationId
Pure rename, zero behavior change: typecheck clean, 218 tests pass (unchanged
count), biome clean, `grep tabId packages/` → zero matches. Verified live:
multi-turn curl emits conversationId-keyed NDJSON and threads history correctly.
GLOSSARY drift note removed. Closes the post-MVP backlog (Steps 1–4).
Diffstat (limited to 'GLOSSARY.md')
| -rw-r--r-- | GLOSSARY.md | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/GLOSSARY.md b/GLOSSARY.md index 8ead590..dade3c2 100644 --- a/GLOSSARY.md +++ b/GLOSSARY.md @@ -29,12 +29,9 @@ | **provider** | An extension wrapping an LLM backend (`stream(messages, tools)`), provider-agnostic to the kernel. | — | | **AgentEvent** | An outward event the runtime emits during a turn (text-delta, tool-call, usage, done, etc.). Carries `conversationId` + `turnId`. | — | -## Known vocabulary drift (tracked, not yet fixed) +## Known vocabulary drift -- **`tabId` in `AgentEvent`s and `runTurn` input.** The events contract - (`packages/kernel/src/contracts/events.ts`) and `RunTurnInput` still use - **`tabId`** where the canonical term is now **`conversationId`**. The - session-orchestrator maps `conversationId → tabId` as a bridge. This is a - CONTRACT change (kernel + every consumer) — to be done as a scoped fan-out via - `lsp references` (see HANDOFF.md), not a silent edit. Until then, `tabId` in - emitted events == the `conversationId`. +- _None._ The former `tabId` drift in `AgentEvent`s and `RunTurnInput` was fully + resolved (renamed to `conversationId` across contracts + every consumer; see + tasks.md Step 4). `tabId` is retained only in the "Aliases to avoid" column + above so it is never reintroduced. |