diff options
| author | Adam Malczewski <[email protected]> | 2026-06-01 11:35:26 +0900 |
|---|---|---|
| committer | Adam Malczewski <[email protected]> | 2026-06-01 11:35:26 +0900 |
| commit | 9ce127e558e0a77f1441b1242ce0a6ee7836bb76 (patch) | |
| tree | 37be2156dcc3e1127344299bdc449464d929df02 /packaging/[email protected] | |
| parent | f60aceec5fd77bbd1efcdfc2c907dd4e61a00469 (diff) | |
| download | dispatch-9ce127e558e0a77f1441b1242ce0a6ee7836bb76.tar.gz dispatch-9ce127e558e0a77f1441b1242ce0a6ee7836bb76.zip | |
docs: HANDOFF round-2 review followup + move review 2 into notes/
Append a 'Review followup — Round 2' section to HANDOFF.md documenting
the round-2 Gemini-review fixes:
- Critical: request-reorder desync (SnapshotSequencer assumed client send
order == server processing order; not true on the wire). Fixed by
promoting the per-hour pendingHours Set to a single global pendingHour
mutation lock — serializing toggle POSTs eliminates the reorder window
entirely.
- High: toggle endpoint guessed user intent from server state, which
combined with any desync to invert clicks. Fixed by requiring an
explicit action: 'on' | 'off' field on every request.
- Low: round-2 R2-3 (retry storm re-probes succeeded accounts) noted as
a deliberate trade-off, not fixed.
Move the round-2 review report from the project root into
notes/claude-reset-review-2.md to match the convention established for
the round-1 report.
Net delta vs branch base: 431 tests (was 427 after round 1; +4 contract
tests for the explicit-action endpoint). Biome and svelte-check clean.
Diffstat (limited to 'packaging/[email protected]')
0 files changed, 0 insertions, 0 deletions
