1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
|
import * as fs from "node:fs";
import * as os from "node:os";
import * as path from "node:path";
import { afterEach, beforeEach, describe, expect, it } from "vitest";
import {
expandAgentToolNames,
getAgentDirPaths,
loadAgent,
saveAgent,
} from "../../src/agents/loader.js";
describe("expandAgentToolNames", () => {
it("expands 'read' into the granular read tools", () => {
const out = expandAgentToolNames(["read"]);
expect(out).toContain("read_file");
expect(out).toContain("read_file_slice");
expect(out).toContain("list_files");
});
it("expands 'edit' into write_file", () => {
const out = expandAgentToolNames(["edit"]);
expect(out).toContain("write_file");
});
it("expands 'bash' into run_shell", () => {
const out = expandAgentToolNames(["bash"]);
expect(out).toContain("run_shell");
});
it("passes through the tab tools as independent names (no tab_comm group)", () => {
const out = expandAgentToolNames(["send_to_tab", "read_tab"]);
expect(out).toContain("send_to_tab");
expect(out).toContain("read_tab");
// Granting only one must not pull in the other.
const onlySend = expandAgentToolNames(["send_to_tab"]);
expect(onlySend).toContain("send_to_tab");
expect(onlySend).not.toContain("read_tab");
});
it("passes through non-group tool names unchanged", () => {
const out = expandAgentToolNames([
"summon",
"retrieve",
"web_search",
"youtube_transcribe",
"search_code",
"send_to_tab",
"read_tab",
]);
expect(out).toEqual(
expect.arrayContaining([
"summon",
"retrieve",
"web_search",
"youtube_transcribe",
"search_code",
"send_to_tab",
"read_tab",
]),
);
});
it("always includes 'todo' even when not requested", () => {
expect(expandAgentToolNames([])).toContain("todo");
expect(expandAgentToolNames(["read"])).toContain("todo");
expect(expandAgentToolNames(["summon"])).toContain("todo");
});
it("deduplicates when groups overlap with explicit names", () => {
const out = expandAgentToolNames(["read", "read_file"]);
// Each name should appear at most once
const counts = new Map<string, number>();
for (const t of out) counts.set(t, (counts.get(t) ?? 0) + 1);
for (const [, c] of counts) expect(c).toBe(1);
});
});
describe("getAgentDirPaths", () => {
it("returns just the global dir when no projectDir is supplied", () => {
const paths = getAgentDirPaths();
expect(paths).toHaveLength(1);
expect(paths[0]).toContain(".config/dispatch/agents");
});
it("appends the project-scoped dir when projectDir is supplied", () => {
const paths = getAgentDirPaths("/some/project");
expect(paths).toHaveLength(2);
expect(paths[1]).toBe("/some/project/.dispatch/agents");
});
});
describe("loadAgent — project-scoped sandbox", () => {
// `GLOBAL_AGENTS_DIR` is captured at module load via `os.homedir()`
// and can't be redirected at runtime. The project-scoped path,
// however, is computed per-call from the `projectDir` argument, so
// we exercise that branch instead. This is also the more common
// real-world case (per-project agent definitions).
let tmpProject: string;
beforeEach(() => {
tmpProject = fs.mkdtempSync(path.join(os.tmpdir(), "dispatch-loader-test-"));
});
afterEach(() => {
fs.rmSync(tmpProject, { recursive: true, force: true });
});
function writeAgentToml(slug: string, body: string): void {
const agentsDir = path.join(tmpProject, ".dispatch", "agents");
fs.mkdirSync(agentsDir, { recursive: true });
fs.writeFileSync(path.join(agentsDir, `${slug}.toml`), body, "utf-8");
}
// Uses a slug unlikely to collide with anything the user might
// already have in ~/.config/dispatch/agents. `loadAgent` returns
// the FIRST match it finds across all scanned directories, and
// the global scope is scanned before the project scope — a slug
// that exists in both would resolve to the global one (which is
// real, not under our control). The "z-dispatch-test-*" prefix
// gives this fixture exclusive ownership of the slug.
const TEST_SLUG = "z-dispatch-test-fixture";
it("returns null for an unknown slug within the project scope", () => {
const agent = loadAgent("z-dispatch-test-does-not-exist", tmpProject);
expect(agent).toBeNull();
});
it("loads a TOML definition written to the project's .dispatch/agents", () => {
writeAgentToml(
TEST_SLUG,
[
'name = "Fixture"',
'description = "Sandbox fixture for loadAgent test."',
"skills = []",
'tools = ["read", "bash"]',
"is_subagent = true",
"",
"[[models]]",
'key_id = "opencode-1"',
'model_id = "deepseek-v4-flash"',
"",
].join("\n"),
);
const agent = loadAgent(TEST_SLUG, tmpProject);
expect(agent).not.toBeNull();
expect(agent?.slug).toBe(TEST_SLUG);
expect(agent?.name).toBe("Fixture");
expect(agent?.tools).toEqual(["read", "bash"]);
expect(agent?.is_subagent).toBe(true);
expect(agent?.models).toEqual([{ key_id: "opencode-1", model_id: "deepseek-v4-flash" }]);
expect(agent?.scope).toBe(tmpProject);
});
it("parses a per-model effort when it is a recognised level", () => {
writeAgentToml(
TEST_SLUG,
[
'name = "Fixture"',
"skills = []",
'tools = ["read"]',
"",
"[[models]]",
'key_id = "opencode-1"',
'model_id = "deepseek-v4-flash"',
'effort = "low"',
"",
"[[models]]",
'key_id = "claude-max"',
'model_id = "claude-opus-4-8"',
'effort = "xhigh"',
"",
].join("\n"),
);
const agent = loadAgent(TEST_SLUG, tmpProject);
expect(agent?.models).toEqual([
{ key_id: "opencode-1", model_id: "deepseek-v4-flash", effort: "low" },
{ key_id: "claude-max", model_id: "claude-opus-4-8", effort: "xhigh" },
]);
});
it("drops an invalid effort value so the call site falls back to the default", () => {
writeAgentToml(
TEST_SLUG,
[
'name = "Fixture"',
"skills = []",
'tools = ["read"]',
"",
"[[models]]",
'key_id = "opencode-1"',
'model_id = "deepseek-v4-flash"',
'effort = "turbo"',
"",
].join("\n"),
);
const agent = loadAgent(TEST_SLUG, tmpProject);
expect(agent?.models).toEqual([{ key_id: "opencode-1", model_id: "deepseek-v4-flash" }]);
expect(agent?.models[0]).not.toHaveProperty("effort");
});
it("round-trips effort through saveAgent → loadAgent", () => {
saveAgent({
name: "Fixture",
description: "",
skills: [],
tools: ["read"],
models: [
{ key_id: "opencode-1", model_id: "deepseek-v4-flash", effort: "medium" },
{ key_id: "claude-max", model_id: "claude-opus-4-8" },
],
scope: tmpProject,
slug: TEST_SLUG,
});
const agent = loadAgent(TEST_SLUG, tmpProject);
expect(agent?.models).toEqual([
{ key_id: "opencode-1", model_id: "deepseek-v4-flash", effort: "medium" },
{ key_id: "claude-max", model_id: "claude-opus-4-8" },
]);
});
it("sanitizes the slug so path traversal can't reach outside the agents dir", () => {
// Even if a caller passes something gnarly, the lookup is by
// sanitized slug — no file outside the configured dirs should
// ever be opened. The sanitized form ("etc-passwd") obviously
// doesn't exist in the temp project, so the result is null.
const agent = loadAgent("../../../etc/passwd", tmpProject);
expect(agent).toBeNull();
});
});
|
