summaryrefslogtreecommitdiffhomepage
path: root/packages/heartbeat/src/scheduler.test.ts
blob: 82e5c4d8b0773a38248d435cabf7c6a99b0a8c7c (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
import { describe, expect, it } from "vitest";
import { HeartbeatScheduler, type Timers } from "./scheduler.js";

interface FakeTimer {
  readonly fn: () => void;
  readonly firesAt: number;
}

/**
 * A controllable fake clock: `advance(ms)` moves virtual time forward and runs
 * any timers that became due. The injected `fire` returns a deferred the test
 * resolves manually, so we can assert the "running" state and the re-arm that
 * happens only AFTER the run completes.
 */
function createFakeTimers() {
  let now = 0;
  let nextId = 1;
  const timers = new Map<number, FakeTimer>();
  const timersApi: Timers = {
    now: () => now,
    setTimeout: (fn, ms) => {
      const id = nextId++;
      timers.set(id, { fn, firesAt: now + ms });
      return id as unknown as ReturnType<typeof setTimeout>;
    },
    clearTimeout: (handle) => {
      if (handle !== undefined) timers.delete(handle as unknown as number);
    },
  };
  return {
    timers: timersApi,
    advance(ms: number): number {
      now += ms;
      let fired = 0;
      const due = [...timers.entries()]
        .filter(([, t]) => t.firesAt <= now)
        .sort((a, b) => a[0] - b[0]);
      for (const [id, t] of due) {
        timers.delete(id);
        t.fn();
        fired++;
      }
      return fired;
    },
    pendingCount(): number {
      return timers.size;
    },
  };
}

/** A deferred promise the test resolves to signal run completion. */
function createDeferred(): { promise: Promise<void>; resolve: () => void } {
  let resolve!: () => void;
  const promise = new Promise<void>((r) => {
    resolve = r;
  });
  return { promise, resolve };
}

// Flush pending microtasks (the scheduler's .finally re-arm runs as a microtask
// after the fire promise resolves).
const flush = async (): Promise<void> => {
  await new Promise((r) => queueMicrotask(r));
};

describe("HeartbeatScheduler", () => {
  it("arms a timer that fires after intervalMinutes", () => {
    const fake = createFakeTimers();
    const fires: string[] = [];
    const deferreds: Array<{ resolve: () => void }> = [];
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: (ws) => {
        fires.push(ws);
        const d = createDeferred();
        deferreds.push(d);
        return d.promise;
      },
    });

    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    expect(scheduler.isArmed("ws-1")).toBe(true);
    expect(fake.pendingCount()).toBe(1);

    // Just shy of the interval → no fire.
    expect(fake.advance(59_999)).toBe(0);
    expect(fires).toEqual([]);

    // Exactly the interval (1 minute = 60_000ms) → fires.
    expect(fake.advance(1)).toBe(1);
    expect(fires).toEqual(["ws-1"]);
    // While the run is in progress: running, no pending timer.
    expect(scheduler.isRunning("ws-1")).toBe(true);
    expect(fake.pendingCount()).toBe(0);
  });

  it("re-arms only after the run completes (reset timer after each run)", async () => {
    const fake = createFakeTimers();
    const fires: string[] = [];
    const deferreds: Array<{ resolve: () => void }> = [];
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: (ws) => {
        fires.push(ws);
        const d = createDeferred();
        deferreds.push(d);
        return d.promise;
      },
    });

    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    fake.advance(60_000); // first fire
    expect(fires).toEqual(["ws-1"]);
    // Run in progress — no new timer yet.
    expect(fake.pendingCount()).toBe(0);

    // Completing the run schedules the next fire.
    deferreds[0]?.resolve();
    await flush();
    expect(scheduler.isRunning("ws-1")).toBe(false);
    expect(fake.pendingCount()).toBe(1);

    // Next fire after another interval.
    fake.advance(60_000);
    expect(fires).toEqual(["ws-1", "ws-1"]);
  });

  it("uses a longer interval for a higher intervalMinutes", () => {
    const fake = createFakeTimers();
    let fireCount = 0;
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => {
        fireCount++;
        return createDeferred().promise;
      },
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 30 });
    // 1 minute wouldn't fire a 30-minute schedule.
    expect(fake.advance(60_000)).toBe(0);
    // 28 more minutes (29 total) still wouldn't fire.
    expect(fake.advance(28 * 60_000)).toBe(0);
    // The remaining minute completes the 30 minutes → fires.
    expect(fake.advance(60_000)).toBe(1);
    expect(fireCount).toBe(1);
  });

  it("disarms (clears the pending timer) when disabled", () => {
    const fake = createFakeTimers();
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => createDeferred().promise,
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    expect(fake.pendingCount()).toBe(1);
    scheduler.arm("ws-1", { enabled: false, intervalMinutes: 1 });
    expect(scheduler.isArmed("ws-1")).toBe(false);
    expect(fake.pendingCount()).toBe(0);
  });

  it("disarmAll stops every schedule", () => {
    const fake = createFakeTimers();
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => createDeferred().promise,
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    scheduler.arm("ws-2", { enabled: true, intervalMinutes: 1 });
    expect(fake.pendingCount()).toBe(2);
    scheduler.disarmAll();
    expect(fake.pendingCount()).toBe(0);
    expect(scheduler.isArmed("ws-1")).toBe(false);
    expect(scheduler.isArmed("ws-2")).toBe(false);
  });

  it("does not re-arm after a disarm during a run", async () => {
    const fake = createFakeTimers();
    const deferreds: Array<{ resolve: () => void }> = [];
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => {
        const d = createDeferred();
        deferreds.push(d);
        return d.promise;
      },
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    fake.advance(60_000); // fire in progress
    scheduler.disarm("ws-1"); // disarm mid-run
    deferreds[0]?.resolve();
    await flush();
    // Disarmed → no re-arm scheduled.
    expect(fake.pendingCount()).toBe(0);
    expect(scheduler.isArmed("ws-1")).toBe(false);
  });

  it("a config update during a run applies the new interval on the next re-arm", async () => {
    const fake = createFakeTimers();
    const deferreds: Array<{ resolve: () => void }> = [];
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => {
        const d = createDeferred();
        deferreds.push(d);
        return d.promise;
      },
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    fake.advance(60_000); // first fire (interval=1m)
    // Update interval to 5m while the run is in progress.
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 5 });
    expect(scheduler.isRunning("ws-1")).toBe(true);
    expect(fake.pendingCount()).toBe(0); // no new timer while running
    deferreds[0]?.resolve();
    await flush();
    // Re-armed with the NEW 5-minute interval.
    expect(fake.advance(60_000)).toBe(0); // 1 minute isn't enough now
    expect(fake.advance(4 * 60_000)).toBe(1); // completes 5 minutes → fires
  });

  it("a thrown fire is swallowed and the loop continues", async () => {
    const fake = createFakeTimers();
    let fireCount = 0;
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => {
        fireCount++;
        return Promise.reject(new Error("boom"));
      },
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    fake.advance(60_000);
    await flush();
    expect(fireCount).toBe(1);
    // Loop continues: next fire scheduled.
    expect(fake.pendingCount()).toBe(1);
    fake.advance(60_000);
    expect(fireCount).toBe(2);
  });

  // ─── nextFireAt (CR-HB-3: server-authoritative next-run time) ──────────────

  it("nextFireAt returns null for a workspace with no schedule", () => {
    const fake = createFakeTimers();
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => createDeferred().promise,
    });
    expect(scheduler.nextFireAt("unknown")).toBeNull();
  });

  it("nextFireAt returns the absolute fire time when armed (now + intervalMs)", () => {
    const fake = createFakeTimers();
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => createDeferred().promise,
    });
    // now=0, interval=1m → next fire at epoch-ms 60_000.
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    expect(scheduler.nextFireAt("ws-1")).toBe(60_000);
  });

  it("nextFireAt reflects a longer interval", () => {
    const fake = createFakeTimers();
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => createDeferred().promise,
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 30 });
    expect(scheduler.nextFireAt("ws-1")).toBe(30 * 60_000);
  });

  it("nextFireAt reflects a new interval on re-arm (not running)", () => {
    const fake = createFakeTimers();
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => createDeferred().promise,
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    expect(scheduler.nextFireAt("ws-1")).toBe(60_000);
    // Re-arm with a 5-minute interval (armed, not running) → recomputed.
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 5 });
    expect(scheduler.nextFireAt("ws-1")).toBe(5 * 60_000);
  });

  it("nextFireAt returns null when disarmed", () => {
    const fake = createFakeTimers();
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => createDeferred().promise,
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    expect(scheduler.nextFireAt("ws-1")).toBe(60_000);
    scheduler.disarm("ws-1");
    expect(scheduler.nextFireAt("ws-1")).toBeNull();
  });

  it("nextFireAt returns null while a run is in progress, then the next fire after it completes", async () => {
    const fake = createFakeTimers();
    const deferreds: Array<{ resolve: () => void }> = [];
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => {
        const d = createDeferred();
        deferreds.push(d);
        return d.promise;
      },
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    expect(scheduler.nextFireAt("ws-1")).toBe(60_000);

    fake.advance(60_000); // fire → run in progress
    expect(scheduler.isRunning("ws-1")).toBe(true);
    // In flight → no next run queued yet.
    expect(scheduler.nextFireAt("ws-1")).toBeNull();

    deferreds[0]?.resolve();
    await flush();
    // Re-armed at completion-time (60_000) + interval (60_000) = 120_000.
    expect(scheduler.nextFireAt("ws-1")).toBe(120_000);
  });

  it("nextFireAt returns null after disarming mid-run (no re-arm)", async () => {
    const fake = createFakeTimers();
    const deferreds: Array<{ resolve: () => void }> = [];
    const scheduler = new HeartbeatScheduler({
      timers: fake.timers,
      fire: () => {
        const d = createDeferred();
        deferreds.push(d);
        return d.promise;
      },
    });
    scheduler.arm("ws-1", { enabled: true, intervalMinutes: 1 });
    fake.advance(60_000); // fire in progress
    expect(scheduler.nextFireAt("ws-1")).toBeNull(); // running
    scheduler.disarm("ws-1"); // disarm mid-run
    deferreds[0]?.resolve();
    await flush();
    // Disarmed → no re-arm, no fire time.
    expect(scheduler.nextFireAt("ws-1")).toBeNull();
  });
});