1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
|
import { beforeEach, describe, expect, it } from "vitest";
import { defineEventHook, defineFilter, defineService } from "../contracts/hooks.js";
import type { Logger, Span } from "../contracts/logging.js";
import { type Bus, createBus } from "./bus.js";
import { applyFilterChain, dispatchEventSync, sortFilters } from "./pure.js";
interface FakeLogger extends Logger {
readonly errors: Array<{ message: string; args: unknown[] }>;
}
function createFakeLogger(): FakeLogger {
const errors: Array<{ message: string; args: unknown[] }> = [];
const logger: FakeLogger = {
errors,
debug: () => {},
info: () => {},
warn: () => {},
error: (message, attrs) => {
errors.push({ message, args: attrs === undefined ? [] : [attrs] });
},
child: () => logger,
span: () => makeNoopSpan(logger),
};
return logger;
}
function makeNoopSpan(log: Logger): Span {
const span: Span = {
id: "noop",
log,
setAttributes: () => {},
addLink: () => {},
child: () => span,
end: () => {},
};
return span;
}
describe("event hooks", () => {
let logger: FakeLogger;
let bus: Bus;
beforeEach(() => {
logger = createFakeLogger();
bus = createBus(logger);
});
it("fires all registered listeners", () => {
const hook = defineEventHook<{ value: number }>("test/event");
const received: number[] = [];
bus.on(hook, (payload) => {
received.push(payload.value);
});
bus.on(hook, (payload) => {
received.push(payload.value * 10);
});
bus.emit(hook, { value: 3 });
expect(received).toEqual([3, 30]);
});
it("isolates a throwing listener (others still run, error logged)", () => {
const hook = defineEventHook<string>("test/isolate");
const received: string[] = [];
bus.on(hook, () => {
throw new Error("boom");
});
bus.on(hook, (payload) => {
received.push(payload);
});
bus.emit(hook, "hello");
expect(received).toEqual(["hello"]);
expect(logger.errors).toHaveLength(1);
expect(logger.errors[0]?.message).toContain("test/isolate");
});
it("isolates an async handler rejection", async () => {
const hook = defineEventHook<string>("test/async-reject");
const received: string[] = [];
bus.on(hook, async () => {
throw new Error("async boom");
});
bus.on(hook, async (payload) => {
received.push(payload);
});
bus.emit(hook, "data");
await new Promise((resolve) => {
setTimeout(resolve, 10);
});
expect(received).toEqual(["data"]);
expect(logger.errors).toHaveLength(1);
expect(logger.errors[0]?.message).toContain("test/async-reject");
});
it("unsubscribe removes the handler", () => {
const hook = defineEventHook<void>("test/unsub");
let count = 0;
const unsub = bus.on(hook, () => {
count++;
});
bus.emit(hook, undefined);
expect(count).toBe(1);
unsub();
bus.emit(hook, undefined);
expect(count).toBe(1);
});
it("emit with no handlers is a no-op", () => {
const hook = defineEventHook<string>("test/empty");
expect(() => bus.emit(hook, "nothing")).not.toThrow();
});
it("emitAsync awaits all handlers", async () => {
const hook = defineEventHook<number>("test/async");
const received: number[] = [];
bus.on(hook, async (payload) => {
await new Promise((resolve) => {
setTimeout(resolve, 5);
});
received.push(payload);
});
bus.on(hook, async (payload) => {
received.push(payload * 2);
});
await bus.emitAsync(hook, 5);
expect(received).toEqual([10, 5]);
});
it("emitAsync respects timeout", async () => {
const hook = defineEventHook<void>("test/timeout");
let completed = false;
bus.on(hook, async () => {
await new Promise((resolve) => {
setTimeout(resolve, 100);
});
completed = true;
});
await bus.emitAsync(hook, undefined, 10);
expect(completed).toBe(false);
});
});
describe("filter hooks", () => {
let logger: FakeLogger;
let bus: Bus;
beforeEach(() => {
logger = createFakeLogger();
bus = createBus(logger);
});
it("chains filters in registration order", async () => {
const hook = defineFilter<string>("test/chain");
bus.addFilter(hook, (value) => `${value}-a`);
bus.addFilter(hook, (value) => `${value}-b`);
const result = await bus.applyFilters(hook, "start");
expect(result).toBe("start-a-b");
});
it("respects priority ordering (lower runs first)", async () => {
const hook = defineFilter<string>("test/priority");
bus.addFilter(hook, (value) => `${value}-second`);
bus.addFilter(hook, (value) => `${value}-first`, { priority: -1 });
const result = await bus.applyFilters(hook, "start");
expect(result).toBe("start-first-second");
});
it("fail-open passes value through on throw", async () => {
const hook = defineFilter<number>("test/fail-open");
bus.addFilter(hook, (value) => value + 1);
bus.addFilter(hook, () => {
throw new Error("filter boom");
});
bus.addFilter(hook, (value) => value * 2);
const result = await bus.applyFilters(hook, 5);
expect(result).toBe(12);
expect(logger.errors).toHaveLength(1);
expect(logger.errors[0]?.message).toContain("test/fail-open");
});
it("fail-closed propagates the error", async () => {
const hook = defineFilter<number>("test/fail-closed");
bus.addFilter(hook, () => {
throw new Error("closed boom");
});
await expect(bus.applyFilters(hook, 5, { failClosed: true })).rejects.toThrow("closed boom");
});
it("applyFilters with no filters returns value unchanged", async () => {
const hook = defineFilter<string>("test/no-filters");
const result = await bus.applyFilters(hook, "unchanged");
expect(result).toBe("unchanged");
});
it("unsubscribe removes a filter from the chain", async () => {
const hook = defineFilter<string>("test/filter-unsub");
const unsub = bus.addFilter(hook, (value) => `${value}-removed`);
bus.addFilter(hook, (value) => `${value}-kept`);
unsub();
const result = await bus.applyFilters(hook, "start");
expect(result).toBe("start-kept");
});
});
describe("services", () => {
let logger: FakeLogger;
let bus: Bus;
beforeEach(() => {
logger = createFakeLogger();
bus = createBus(logger);
});
it("provide and get round-trips", () => {
const handle = defineService<{ greet: (name: string) => string }>("test/service");
const impl = { greet: (name: string) => `hello ${name}` };
bus.provideService(handle, impl);
const retrieved = bus.getService(handle);
expect(retrieved.greet("world")).toBe("hello world");
});
it("getService on missing service throws", () => {
const handle = defineService<string>("test/missing");
expect(() => bus.getService(handle)).toThrow("test/missing");
});
it("double-provide throws", () => {
const handle = defineService<number>("test/double");
bus.provideService(handle, 1);
expect(() => bus.provideService(handle, 2)).toThrow("test/double");
});
});
describe("pure functions", () => {
describe("dispatchEventSync", () => {
it("calls all handlers with the payload", () => {
const logger = createFakeLogger();
const received: number[] = [];
dispatchEventSync(
[
(payload) => {
received.push(payload);
},
(payload) => {
received.push(payload * 2);
},
],
5,
logger,
"test",
);
expect(received).toEqual([5, 10]);
});
it("catches sync throws and logs them", () => {
const logger = createFakeLogger();
const received: number[] = [];
dispatchEventSync(
[
() => {
throw new Error("sync boom");
},
(payload) => {
received.push(payload);
},
],
42,
logger,
"test/sync",
);
expect(received).toEqual([42]);
expect(logger.errors).toHaveLength(1);
});
});
describe("sortFilters", () => {
it("sorts by priority ascending, then by order ascending", () => {
const entries = [
{ fn: async (v: number) => v, priority: 10, order: 0 },
{ fn: async (v: number) => v, priority: -1, order: 1 },
{ fn: async (v: number) => v, priority: 10, order: 2 },
{ fn: async (v: number) => v, priority: 0, order: 3 },
];
const sorted = sortFilters(entries);
expect(sorted.map((e) => e.order)).toEqual([1, 3, 0, 2]);
});
it("preserves registration order when priorities are equal", () => {
const entries = [
{ fn: async (v: string) => v, priority: 0, order: 0 },
{ fn: async (v: string) => v, priority: 0, order: 1 },
{ fn: async (v: string) => v, priority: 0, order: 2 },
];
const sorted = sortFilters(entries);
expect(sorted.map((e) => e.order)).toEqual([0, 1, 2]);
});
});
describe("applyFilterChain", () => {
it("applies filters in order", async () => {
const logger = createFakeLogger();
const result = await applyFilterChain([(v) => v + 1, (v) => v * 3], 2, logger, "test", false);
expect(result).toBe(9);
});
it("fail-open skips the throwing filter", async () => {
const logger = createFakeLogger();
const result = await applyFilterChain(
[
(v) => v + 10,
() => {
throw new Error("skip me");
},
(v) => v + 1,
],
0,
logger,
"test",
false,
);
expect(result).toBe(11);
expect(logger.errors).toHaveLength(1);
});
it("fail-closed throws on error", async () => {
const logger = createFakeLogger();
await expect(
applyFilterChain(
[
() => {
throw new Error("closed");
},
],
0,
logger,
"test",
true,
),
).rejects.toThrow("closed");
});
});
});
|