summaryrefslogtreecommitdiffhomepage
path: root/packages/lsp/src/client.test.ts
blob: 338ef0bd30377ea9fb47471572d9465701a9ba79 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
import { describe, expect, it } from "vitest";
import {
	type FileWatcher,
	type FsAccess,
	LanguageServerClient,
	type ProcessExitHandler,
	type SpawnProcess,
} from "./client.js";
import { encode } from "./framing.js";

function makeClient(overrides?: {
	readonly spawn?: SpawnProcess;
	readonly fileWatcher?: FileWatcher;
	readonly fs?: FsAccess;
	readonly initialization?: Record<string, unknown>;
}): {
	client: LanguageServerClient;
	stdinChunks: Uint8Array[];
	serverResponses: (msg: string) => void;
} {
	const stdinChunks: Uint8Array[] = [];
	let serverMessageHandler: ((msg: string) => void) | null = null;

	const mockSpawn: SpawnProcess = () => ({
		stdin: { write: (bytes) => stdinChunks.push(bytes) },
		stdout: {
			on: (_event: string, cb: (data: Uint8Array) => void) => {
				// We'll feed messages through serverResponses
				serverMessageHandler = (msg: string) => {
					cb(encode(msg));
				};
			},
		},
		pid: 123,
		kill: () => {},
	});

	const mockFileWatcher: FileWatcher = (_root, _onEvent) => ({
		close: () => {},
	});

	const mockFs: FsAccess = {
		readText: async (path) => `// content of ${path}`,
		exists: async () => true,
	};

	const client = new LanguageServerClient({
		spawn: overrides?.spawn ?? mockSpawn,
		fileWatcher: overrides?.fileWatcher ?? mockFileWatcher,
		fs: overrides?.fs ?? mockFs,
		command: ["test-lsp"],
		root: "/project",
		serverId: "test",
		...(overrides?.initialization ? { initialization: overrides.initialization } : {}),
	});

	return {
		client,
		stdinChunks,
		serverResponses: (msg: string) => serverMessageHandler?.(msg),
	};
}

describe("client", () => {
	it("initialize declares didChangeWatchedFiles.dynamicRegistration true", async () => {
		const { client, stdinChunks, serverResponses } = makeClient();

		const startPromise = client.start();

		// Wait for the initialize message to be sent
		await new Promise((r) => setTimeout(r, 50));

		// Parse the sent messages to find initialize
		const sentMessages = stdinChunks.map((chunk) => {
			const decoded = new TextDecoder().decode(chunk);
			const headerEnd = decoded.indexOf("\r\n\r\n");
			return JSON.parse(decoded.slice(headerEnd + 4));
		});

		const initMsg = sentMessages.find((m: { method?: string }) => m.method === "initialize");
		expect(initMsg).toBeDefined();
		expect(initMsg.params.capabilities.workspace.didChangeWatchedFiles.dynamicRegistration).toBe(
			true,
		);

		// Send initialize response
		serverResponses(
			JSON.stringify({
				jsonrpc: "2.0",
				id: initMsg.id,
				result: { capabilities: {} },
			}),
		);

		await startPromise;
		expect(client.getState()).toBe("connected");
	});

	it("honors registerCapability for BOTH textDocument/diagnostic and workspace/didChangeWatchedFiles", async () => {
		const { client, serverResponses } = makeClient();
		const startPromise = client.start();

		await new Promise((r) => setTimeout(r, 50));

		serverResponses(
			JSON.stringify({
				jsonrpc: "2.0",
				id: 1,
				result: { capabilities: {} },
			}),
		);

		await startPromise;

		// Register workspace/didChangeWatchedFiles
		serverResponses(
			JSON.stringify({
				jsonrpc: "2.0",
				id: 100,
				method: "client/registerCapability",
				params: {
					registrations: [
						{
							id: "reg-watched",
							method: "workspace/didChangeWatchedFiles",
							registerOptions: {
								watchers: [{ globPattern: "**/*.luau" }],
							},
						},
						{
							id: "reg-diag",
							method: "textDocument/diagnostic",
							registerOptions: {},
						},
					],
				},
			}),
		);

		await new Promise((r) => setTimeout(r, 50));

		const registry = client.getWatchedFilesRegistry();
		expect(registry.matches("src/main.luau")).toBe(true);
		expect(registry.matches("src/main.ts")).toBe(false);
	});

	it("an injected fs change for a registered glob sends workspace/didChangeWatchedFiles type=Changed (opencode-bug regression)", async () => {
		const callbackHolder: {
			cb:
				| ((e: { readonly type: "create" | "change" | "delete"; readonly path: string }) => void)
				| null;
		} = { cb: null };

		const trackingFileWatcher: FileWatcher = (_root, onEvent) => {
			callbackHolder.cb = onEvent;
			return { close: () => {} };
		};

		const { client, stdinChunks, serverResponses } = makeClient({
			fileWatcher: trackingFileWatcher,
		});

		const startPromise = client.start();
		await new Promise((r) => setTimeout(r, 50));

		serverResponses(
			JSON.stringify({
				jsonrpc: "2.0",
				id: 1,
				result: { capabilities: {} },
			}),
		);

		await startPromise;

		// Register a watcher for sourcemap.json
		serverResponses(
			JSON.stringify({
				jsonrpc: "2.0",
				id: 100,
				method: "client/registerCapability",
				params: {
					registrations: [
						{
							id: "reg-1",
							method: "workspace/didChangeWatchedFiles",
							registerOptions: {
								watchers: [{ globPattern: "sourcemap.json" }],
							},
						},
					],
				},
			}),
		);

		await new Promise((r) => setTimeout(r, 100));

		// Simulate a file change
		const onFsEvent = callbackHolder.cb;
		if (!onFsEvent) throw new Error("file watcher callback was never registered");
		onFsEvent({ type: "change", path: "/project/sourcemap.json" });

		await new Promise((r) => setTimeout(r, 100));

		// Check that the notification was sent
		const sentMessages = stdinChunks.map((chunk) => {
			const decoded = new TextDecoder().decode(chunk);
			const headerEnd = decoded.indexOf("\r\n\r\n");
			return JSON.parse(decoded.slice(headerEnd + 4));
		});

		const didChangeMsg = sentMessages.find(
			(m: { method?: string }) => m.method === "workspace/didChangeWatchedFiles",
		);
		expect(didChangeMsg).toBeDefined();
		expect(didChangeMsg.params.changes[0].uri).toBe("file:///project/sourcemap.json");
		expect(didChangeMsg.params.changes[0].type).toBe(2); // Changed
	});

	it("publishDiagnostics are stored + returned", async () => {
		const { client, serverResponses } = makeClient();
		const startPromise = client.start();
		await new Promise((r) => setTimeout(r, 50));

		serverResponses(
			JSON.stringify({
				jsonrpc: "2.0",
				id: 1,
				result: { capabilities: {} },
			}),
		);

		await startPromise;

		// Send diagnostics
		serverResponses(
			JSON.stringify({
				jsonrpc: "2.0",
				method: "textDocument/publishDiagnostics",
				params: {
					uri: "file:///project/test.ts",
					diagnostics: [
						{
							range: { start: { line: 0, character: 0 }, end: { line: 0, character: 5 } },
							severity: 1,
							message: "Test error",
						},
					],
				},
			}),
		);

		await new Promise((r) => setTimeout(r, 50));

		const store = client.getDiagnosticsStore();
		const formatted = store.format("file:///project/test.ts");
		expect(formatted).toContain("ERROR");
		expect(formatted).toContain("Test error");
	});

	it("shutdown kills the process", async () => {
		const state = { killed: false };
		const stdoutHolder: { cb: ((data: Uint8Array) => void) | null } = { cb: null };
		const killableSpawn: SpawnProcess = () => ({
			stdin: { write: () => {} },
			stdout: {
				on: (_event: string, cb: (data: Uint8Array) => void) => {
					stdoutHolder.cb = cb;
				},
			},
			pid: 123,
			kill: () => {
				state.killed = true;
			},
		});

		const { client } = makeClient({ spawn: killableSpawn });
		const startPromise = client.start();
		await new Promise((r) => setTimeout(r, 50));

		// Deliver the initialize response through the spawned process's own
		// stdout (the real read path), so start() can complete the handshake.
		stdoutHolder.cb?.(
			encode(JSON.stringify({ jsonrpc: "2.0", id: 1, result: { capabilities: {} } })),
		);

		await startPromise;

		client.shutdown();
		expect(state.killed).toBe(true);
	});

	it("onExit marks the client broken (error) so callers stop querying a corpse", async () => {
		const state = { killed: false };
		let exitCb: ProcessExitHandler | null = null;
		const stdoutHolder: { cb: ((data: Uint8Array) => void) | null } = { cb: null };

		const spawnWithExit: SpawnProcess = () => ({
			stdin: { write: () => {} },
			stdout: {
				on: (_event: string, cb: (data: Uint8Array) => void) => {
					stdoutHolder.cb = cb;
				},
			},
			pid: 999,
			kill: () => {
				state.killed = true;
			},
			onExit: (handler) => {
				exitCb = handler;
			},
		});

		const { client } = makeClient({ spawn: spawnWithExit });
		const startPromise = client.start();
		await new Promise((r) => setTimeout(r, 50));
		stdoutHolder.cb?.(
			encode(JSON.stringify({ jsonrpc: "2.0", id: 1, result: { capabilities: {} } })),
		);
		await startPromise;
		expect(client.getState()).toBe("connected");

		// Simulate the process dying (user kill / crash).
		exitCb?.({ code: 1 });

		expect(client.getState()).toBe("error");
		expect(client.getStateError()).toMatch(/process exited/);
		// The (still-alive-in-test) process was killed to avoid a zombie.
		expect(state.killed).toBe(true);
	});

	it("a dead client is skipped by waitForDiagnostics callers (state !== connected)", async () => {
		// Build a client, connect, kill via onExit, then assert a diagnostics
		// query would not block: getState() is "error" so the matching filter
		// (state === "connected") excludes it. We assert the state guard.
		const stdoutHolder: { cb: ((data: Uint8Array) => void) | null } = { cb: null };
		let exitCb: ProcessExitHandler | null = null;
		const spawnWithExit: SpawnProcess = () => ({
			stdin: { write: () => {} },
			stdout: {
				on: (_e, cb) => {
					stdoutHolder.cb = cb;
				},
			},
			pid: 1,
			kill: () => {},
			onExit: (handler) => {
				exitCb = handler;
			},
		});

		const { client } = makeClient({ spawn: spawnWithExit });
		const startPromise = client.start();
		await new Promise((r) => setTimeout(r, 50));
		stdoutHolder.cb?.(
			encode(JSON.stringify({ jsonrpc: "2.0", id: 1, result: { capabilities: {} } })),
		);
		await startPromise;

		exitCb?.({ code: null });
		expect(client.getState()).toBe("error");
		// The aggregate / getDiagnostics matching filter requires "connected".
		expect(client.getState() === "connected").toBe(false);
	});

	it("corruption detector marks the client broken after repeated identical diagnostics despite text changes", async () => {
		// A healthy server would change diagnostics as the file changes; a
		// corrupted one re-emits the SAME non-empty set. Drive 5 edits with
		// different text but identical diagnostics → client flips to error.
		const { client, serverResponses } = makeClient();
		const startPromise = client.start();
		await new Promise((r) => setTimeout(r, 50));
		serverResponses(JSON.stringify({ jsonrpc: "2.0", id: 1, result: { capabilities: {} } }));
		await startPromise;

		const phantom = JSON.stringify({
			jsonrpc: "2.0",
			method: "textDocument/publishDiagnostics",
			params: {
				uri: "file:///project/game.rb",
				diagnostics: [
					{
						range: { start: { line: 0, character: 27 }, end: { line: 0, character: 28 } },
						severity: 1,
						message: "SyntaxError: unexpected token",
					},
				],
			},
		});

		const path = "/project/game.rb";
		// The first call establishes the baseline snapshot (no increment).
		// Each subsequent call with identical diagnostics + changed text
		// increments; the 6th call (5th increment) trips the threshold.
		for (let i = 1; i <= 5; i++) {
			const p = client.waitForDiagnostics(path, { text: `buf-v${i}`, timeoutMs: 2000 });
			// Push the identical phantom diagnostics so the poll resolves.
			await new Promise((r) => setTimeout(r, 30));
			serverResponses(phantom);
			await p;
			expect(client.getState()).toBe("connected");
		}
		// 6th identical-across-changed-text repeat trips the threshold.
		const p6 = client.waitForDiagnostics(path, { text: "buf-v6", timeoutMs: 2000 });
		await new Promise((r) => setTimeout(r, 30));
		serverResponses(phantom);
		await p6;

		expect(client.getState()).toBe("error");
		expect(client.getStateError()).toMatch(/repeated stale diagnostics/i);
	});

	it("corruption detector does NOT trip on a clean file (empty diagnostics stay identical)", async () => {
		const { client, serverResponses } = makeClient();
		const startPromise = client.start();
		await new Promise((r) => setTimeout(r, 50));
		serverResponses(JSON.stringify({ jsonrpc: "2.0", id: 1, result: { capabilities: {} } }));
		await startPromise;

		const clean = JSON.stringify({
			jsonrpc: "2.0",
			method: "textDocument/publishDiagnostics",
			params: { uri: "file:///project/game.rb", diagnostics: [] },
		});
		const path = "/project/game.rb";

		for (let i = 1; i <= 6; i++) {
			const p = client.waitForDiagnostics(path, { text: `clean-v${i}`, timeoutMs: 2000 });
			await new Promise((r) => setTimeout(r, 30));
			serverResponses(clean);
			await p;
		}
		// Empty diagnostics never count as "stale" — a clean file staying clean
		// is normal, not corruption.
		expect(client.getState()).toBe("connected");
	});
});