summaryrefslogtreecommitdiffhomepage
path: root/packages/provider-concurrency/src/provider-wrapper.test.ts
blob: 7554e649c27cfdf602bf42c8c3146a89fdf58a9d (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
import type { ProviderContract, ProviderEvent } from "@dispatch/kernel";
import { describe, expect, it } from "vitest";
import type { ConcurrencyLimiter } from "./concurrency-manager.js";
import { wrapProviderWithConcurrency } from "./provider-wrapper.js";

/** Build a fake provider that yields a sequence of events. */
function fakeProvider(events: ProviderEvent[]): ProviderContract {
  return {
    id: "test-provider",
    stream: async function* (): AsyncIterable<ProviderEvent> {
      for (const e of events) {
        yield e;
      }
    },
  };
}

/** A fake limiter that records acquire/release calls. */
function recordingLimiter(): ConcurrencyLimiter & {
  acquireCalls: {
    providerId: string;
    conversationId: string;
    workspaceId: string;
    promptStartedAt: number;
  }[];
  releaseCalls: number;
  rateLimitReports: string[];
} {
  const acquireCalls: {
    providerId: string;
    conversationId: string;
    workspaceId: string;
    promptStartedAt: number;
  }[] = [];
  const releaseCalls: { count: number } = { count: 0 };
  const rateLimitReports: string[] = [];

  return {
    acquireCalls,
    get releaseCalls() {
      return releaseCalls.count;
    },
    rateLimitReports,
    acquire(providerId, conversationId, workspaceId, promptStartedAt) {
      acquireCalls.push({ providerId, conversationId, workspaceId, promptStartedAt });
      return Promise.resolve(() => {
        releaseCalls.count++;
      });
    },
    reportRateLimit(providerId) {
      rateLimitReports.push(providerId);
    },
  };
}

describe("wrapProviderWithConcurrency", () => {
  it("acquires a slot before streaming and releases after the stream completes", async () => {
    const provider = fakeProvider([
      { type: "text-delta", delta: "hello" },
      { type: "finish", reason: "stop" },
    ]);
    const limiter = recordingLimiter();

    const wrapped = wrapProviderWithConcurrency(provider, limiter, "conv1", "default", 12345);

    const events: ProviderEvent[] = [];
    for await (const e of wrapped.stream([], [])) {
      events.push(e);
    }

    // Slot acquired before stream, released after.
    expect(limiter.acquireCalls).toEqual([
      {
        providerId: "test-provider",
        conversationId: "conv1",
        workspaceId: "default",
        promptStartedAt: 12345,
      },
    ]);
    expect(limiter.releaseCalls).toBe(1);
    expect(events).toEqual([
      { type: "text-delta", delta: "hello" },
      { type: "finish", reason: "stop" },
    ]);
  });

  it("releases the slot even when the stream throws", async () => {
    const provider: ProviderContract = {
      id: "err-provider",
      stream: async function* (): AsyncIterable<ProviderEvent> {
        yield { type: "text-delta", delta: "partial" };
        throw new Error("stream exploded");
      },
    };
    const limiter = recordingLimiter();
    const wrapped = wrapProviderWithConcurrency(provider, limiter, "conv1", "default", 0);

    await expect(async () => {
      for await (const _e of wrapped.stream([], [])) {
        // consume
      }
    }).rejects.toThrow("stream exploded");

    expect(limiter.releaseCalls).toBe(1);
  });

  it("reports 429 errors to the limiter", async () => {
    const provider = fakeProvider([
      { type: "error", message: "Too many requests", code: "429", retryable: true },
    ]);
    const limiter = recordingLimiter();
    const wrapped = wrapProviderWithConcurrency(provider, limiter, "conv1", "default", 0);

    const events: ProviderEvent[] = [];
    for await (const e of wrapped.stream([], [])) {
      events.push(e);
    }

    expect(limiter.rateLimitReports).toEqual(["test-provider"]);
    // The 429 error event is still yielded to the consumer (kernel handles retry).
    expect(events).toHaveLength(1);
    expect(events[0]?.type).toBe("error");
  });

  it("does not report non-429 errors", async () => {
    const provider = fakeProvider([
      { type: "error", message: "Internal error", code: "500", retryable: true },
    ]);
    const limiter = recordingLimiter();
    const wrapped = wrapProviderWithConcurrency(provider, limiter, "conv1", "default", 0);

    for await (const _e of wrapped.stream([], [])) {
      // consume
    }

    expect(limiter.rateLimitReports).toEqual([]);
  });

  it("preserves the provider id and listModels", async () => {
    const provider: ProviderContract = {
      id: "my-provider",
      stream: async function* (): AsyncIterable<ProviderEvent> {
        yield { type: "finish", reason: "stop" };
      },
      listModels: async () => [{ id: "model-1" }],
    };
    const limiter = recordingLimiter();
    const wrapped = wrapProviderWithConcurrency(provider, limiter, "conv1", "default", 0);

    expect(wrapped.id).toBe("my-provider");
    expect(wrapped.listModels).toBeDefined();
    const models = await wrapped.listModels?.();
    expect(models).toEqual([{ id: "model-1" }]);
  });

  it("calls onQueued when the request blocks and onAcquired when the slot is granted", async () => {
    let queuedCalled = false;
    let acquiredCalled = false;

    const blockingLimiter: ConcurrencyLimiter = {
      acquire(_providerId, _convId, _wsId, _promptAt, onQueued) {
        // Simulate a queued request: call onQueued, then resolve on next tick.
        onQueued?.();
        return new Promise((resolve) => {
          setTimeout(() => {
            resolve(() => {});
          }, 0);
        });
      },
      reportRateLimit() {},
    };

    const provider = fakeProvider([{ type: "finish", reason: "stop" }]);
    const wrapped = wrapProviderWithConcurrency(
      provider,
      blockingLimiter,
      "conv1",
      "default",
      0,
      () => {
        queuedCalled = true;
      },
      () => {
        acquiredCalled = true;
      },
    );

    for await (const _e of wrapped.stream([], [])) {
      // consume
    }

    expect(queuedCalled).toBe(true);
    expect(acquiredCalled).toBe(true);
  });

  it("does NOT call onQueued when the slot is granted immediately", async () => {
    let queuedCalled = false;
    let acquiredCalled = false;

    const immediateLimiter: ConcurrencyLimiter = {
      acquire(_providerId, _convId, _wsId, _promptAt, _onQueued) {
        // Grant immediately — do NOT call onQueued.
        return Promise.resolve(() => {});
      },
      reportRateLimit() {},
    };

    const provider = fakeProvider([{ type: "finish", reason: "stop" }]);
    const wrapped = wrapProviderWithConcurrency(
      provider,
      immediateLimiter,
      "conv1",
      "default",
      0,
      () => {
        queuedCalled = true;
      },
      () => {
        acquiredCalled = true;
      },
    );

    for await (const _e of wrapped.stream([], [])) {
      // consume
    }

    expect(queuedCalled).toBe(false);
    expect(acquiredCalled).toBe(true);
  });

  it("passes through messages, tools, and opts to the inner stream", async () => {
    let receivedArgs:
      | {
          messages: unknown;
          tools: unknown;
          opts: unknown;
        }
      | undefined;

    const provider: ProviderContract = {
      id: "passthrough",
      stream: async function* (messages, tools, opts): AsyncIterable<ProviderEvent> {
        receivedArgs = { messages, tools, opts };
        yield { type: "finish", reason: "stop" };
      },
    };
    const limiter = recordingLimiter();
    const wrapped = wrapProviderWithConcurrency(provider, limiter, "conv1", "default", 0);

    const messages = [{ role: "user" as const, chunks: [{ type: "text" as const, text: "hi" }] }];
    const tools = [{ name: "test_tool", description: "test", parameters: {} }];
    const opts = { model: "gpt-4" };

    for await (const _e of wrapped.stream(messages, tools, opts)) {
      // consume
    }

    expect(receivedArgs?.messages).toBe(messages);
    expect(receivedArgs?.tools).toBe(tools);
    expect(receivedArgs?.opts).toBe(opts);
  });
});