diff options
| author | Yukihiro "Matz" Matsumoto <[email protected]> | 2019-02-08 07:19:40 +0900 |
|---|---|---|
| committer | GitHub <[email protected]> | 2019-02-08 07:19:40 +0900 |
| commit | 687a4d961f74d45afd8db715e5eaafba96457441 (patch) | |
| tree | 4147b7197e61a4c1f6746785b2c45c507fb9e4f9 | |
| parent | bdc9de875f5545d4dbf8136dbfb576a0caacf7e3 (diff) | |
| parent | 12ba571a1385dd83bdccb63aab3b0ce34720c694 (diff) | |
| download | mruby-687a4d961f74d45afd8db715e5eaafba96457441.tar.gz mruby-687a4d961f74d45afd8db715e5eaafba96457441.zip | |
Merge pull request #4251 from shuujii/remove-no-meaning-statements-in-mruby-io-tests
Remove no meaning statements in `mruby-io` tests
| -rw-r--r-- | mrbgems/mruby-io/test/file.rb | 1 | ||||
| -rw-r--r-- | mrbgems/mruby-io/test/file_test.rb | 8 | ||||
| -rw-r--r-- | mrbgems/mruby-io/test/io.rb | 23 |
3 files changed, 4 insertions, 28 deletions
diff --git a/mrbgems/mruby-io/test/file.rb b/mrbgems/mruby-io/test/file.rb index 7b67ded26..539e25047 100644 --- a/mrbgems/mruby-io/test/file.rb +++ b/mrbgems/mruby-io/test/file.rb @@ -177,7 +177,6 @@ assert('File.path') do assert_equal "a/../b/./c", File.path("a/../b/./c") assert_raise(TypeError) { File.path(nil) } assert_raise(TypeError) { File.path(123) } - end assert('File.symlink') do diff --git a/mrbgems/mruby-io/test/file_test.rb b/mrbgems/mruby-io/test/file_test.rb index 2c831f0d5..04e10e0c8 100644 --- a/mrbgems/mruby-io/test/file_test.rb +++ b/mrbgems/mruby-io/test/file_test.rb @@ -67,11 +67,11 @@ assert("FileTest.size?") do assert_raise IOError do FileTest.size?(fp1) end + assert_true fp1.closed? assert_raise IOError do FileTest.size?(fp2) end - - fp1.closed? && fp2.closed? + assert_true fp2.closed? end assert("FileTest.socket?") do @@ -105,11 +105,11 @@ assert("FileTest.zero?") do assert_raise IOError do FileTest.zero?(fp1) end + assert_true fp1.closed? assert_raise IOError do FileTest.zero?(fp2) end - - fp1.closed? && fp2.closed? + assert_true fp2.closed? end assert('FileTest TEST CLEANUP') do diff --git a/mrbgems/mruby-io/test/io.rb b/mrbgems/mruby-io/test/io.rb index 881e94185..85852c179 100644 --- a/mrbgems/mruby-io/test/io.rb +++ b/mrbgems/mruby-io/test/io.rb @@ -30,8 +30,6 @@ assert('IO.open', '15.2.20.4.1') do IO.open(fd) do |io| assert_equal $mrbtest_io_msg, io.read end - - true end assert('IO#close', '15.2.20.5.1') do @@ -72,8 +70,6 @@ assert('IO#eof?', '15.2.20.5.6') do io.read assert_true io.eof? io.close - - true end assert('IO#flush', '15.2.20.5.7') do @@ -93,7 +89,6 @@ assert('IO#getc', '15.2.20.5.8') do } assert_equal nil, io.getc io.close - true end #assert('IO#gets', '15.2.20.5.9') do @@ -179,8 +174,6 @@ assert('IO#write', '15.2.20.5.20') do io.rewind assert_equal "ab123fg", io.read io.close - - true end assert('IO#<<') do @@ -188,7 +181,6 @@ assert('IO#<<') do io << "" << "" assert_equal 0, io.pos io.close - true end assert('IO#dup for readable') do @@ -208,7 +200,6 @@ assert('IO#dup for readable') do dup.close assert_false io.closed? io.close - true end assert('IO#dup for writable') do @@ -221,7 +212,6 @@ assert('IO#dup for writable') do assert_equal "mruby", dup.sysread(5) dup.close io.close - true end assert('IO.for_fd') do @@ -229,13 +219,11 @@ assert('IO.for_fd') do io = IO.for_fd(fd) assert_equal $mrbtest_io_msg, io.read io.close - true end assert('IO.new') do io = IO.new(0) io.close - true end assert('IO gc check') do @@ -280,7 +268,6 @@ assert('IO.sysopen, IO#sysread') do io = IO.new fd, "w" assert_raise(IOError) { io.sysread(1) } io.close - true end assert('IO.sysopen, IO#syswrite') do @@ -294,8 +281,6 @@ assert('IO.sysopen, IO#syswrite') do io = IO.new(IO.sysopen($mrbtest_io_rfname), "r") assert_raise(IOError) { io.syswrite("a") } io.close - - true end assert('IO#_read_buf') do @@ -319,7 +304,6 @@ assert('IO#_read_buf') do assert_equal true, io.eof assert_equal true, io.eof? io.close - io.closed? end assert('IO#isatty') do @@ -352,7 +336,6 @@ assert('IO#pos=, IO#seek') do assert_equal 0, io.seek(0) assert_equal 0, io.pos io.close - io.closed? end assert('IO#rewind') do @@ -363,7 +346,6 @@ assert('IO#rewind') do assert_equal 0, io.rewind assert_equal 0, io.pos io.close - io.closed? end assert('IO#gets') do @@ -412,7 +394,6 @@ assert('IO#gets') do assert_equal nil, io.gets, "gets third line; returns nil" io.close - io.closed? end assert('IO#gets - paragraph mode') do @@ -423,7 +404,6 @@ assert('IO#gets - paragraph mode') do io.write "2" * 10 + "\n" assert_equal 34 + $cr * 4, io.pos io.close - assert_equal true, io.closed? fd = IO.sysopen $mrbtest_io_wfname io = IO.new fd @@ -434,7 +414,6 @@ assert('IO#gets - paragraph mode') do text2 = io.gets("") assert_equal para2, text2 io.close - io.closed? end assert('IO.popen') do @@ -528,7 +507,6 @@ assert('IO#fileno') do assert_equal io.fileno, fd assert_equal io.to_i, fd io.close - io.closed? end assert('IO#close_on_exec') do @@ -550,7 +528,6 @@ assert('IO#close_on_exec') do assert_equal(false, io.close_on_exec?) io.close - io.closed? begin r, w = IO.pipe |
