summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorYukihiro "Matz" Matsumoto <[email protected]>2019-07-27 21:38:20 +0900
committerGitHub <[email protected]>2019-07-27 21:38:20 +0900
commit8c6cd2da762e124a26b370636dc22d970e9d084e (patch)
treeae0b282c3adafa014fdcc5c803289b7f8fea5bc0
parent2f0a95768b8753448eb819e1bd3d250b69844828 (diff)
parentfe9a58c193f73c85d79de214152b2444b7cfe483 (diff)
downloadmruby-8c6cd2da762e124a26b370636dc22d970e9d084e.tar.gz
mruby-8c6cd2da762e124a26b370636dc22d970e9d084e.zip
Merge pull request #4599 from shuujii/drop-dependency-from-mruby-enum-chain-to-mruby-enum-ext
Drop dependency from `mruby-enum-chain` to `mruby-enum-ext`
-rw-r--r--mrbgems/mruby-enum-chain/mrblib/chain.rb5
-rw-r--r--mrbgems/mruby-enum-chain/test/enum_chain.rb24
2 files changed, 21 insertions, 8 deletions
diff --git a/mrbgems/mruby-enum-chain/mrblib/chain.rb b/mrbgems/mruby-enum-chain/mrblib/chain.rb
index 98515ea14..52f5f0656 100644
--- a/mrbgems/mruby-enum-chain/mrblib/chain.rb
+++ b/mrbgems/mruby-enum-chain/mrblib/chain.rb
@@ -40,8 +40,11 @@ class Enumerator
end
def rewind
- @enums.reverse_each do |e|
+ i = @enums.size - 1
+ while 0 <= i
+ e = @enums[i]
e.rewind if e.respond_to?(:rewind)
+ i -= 1
end
self
diff --git a/mrbgems/mruby-enum-chain/test/enum_chain.rb b/mrbgems/mruby-enum-chain/test/enum_chain.rb
index 4dd59bd37..9aea783b9 100644
--- a/mrbgems/mruby-enum-chain/test/enum_chain.rb
+++ b/mrbgems/mruby-enum-chain/test/enum_chain.rb
@@ -14,7 +14,7 @@ end
assert("Enumerable#+") do
a = [].each
- b = {}.reverse_each
+ b = {}.each
c = Object.new # not has #each method
assert_kind_of Enumerator::Chain, a + b
@@ -46,13 +46,13 @@ assert("Enumerator::Chain#each") do
assert_kind_of Enumerator, aa.each
assert_equal [1, 2, 3, 1, 2, 3], aa.each.to_a
- aa = a.chain(a.reverse_each)
+ aa = a.chain(6..9)
assert_kind_of Enumerator, aa.each
- assert_equal [1, 2, 3, 3, 2, 1], aa.each.to_a
+ assert_equal [1, 2, 3, 6, 7, 8, 9], aa.each.to_a
- aa = a.chain(a.reverse_each, a)
+ aa = a.chain((-3..-2).each_with_index, a)
assert_kind_of Enumerator, aa.each
- assert_equal [1, 2, 3, 3, 2, 1, 1, 2, 3], aa.each.to_a
+ assert_equal [1, 2, 3, [-3, 0], [-2, 1], 1, 2, 3], aa.each.to_a
aa = a.chain(Object.new)
assert_kind_of Enumerator, aa.each
@@ -65,12 +65,22 @@ assert("Enumerator::Chain#size") do
aa = a.chain(a)
assert_equal 6, aa.size
- aa = a.chain(a.reverse_each)
+ aa = a.chain(3..4)
assert_nil aa.size
- aa = a.chain(a.reverse_each, a)
+ aa = a.chain(3..4, a)
assert_nil aa.size
aa = a.chain(Object.new)
assert_nil aa.size
end
+
+assert("Enumerator::Chain#rewind") do
+ rewound = []
+ e1 = [1, 2]
+ e2 = (4..6)
+ (class << e1; self end).define_method(:rewind) { rewound << __id__ }
+ (class << e2; self end).define_method(:rewind) { rewound << __id__ }
+ c = e1.chain(e2).each{}.rewind
+ assert_equal [e2.__id__, e1.__id__], rewound
+end