summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorYukihiro "Matz" Matsumoto <[email protected]>2012-06-02 01:29:42 -0700
committerYukihiro "Matz" Matsumoto <[email protected]>2012-06-02 01:29:42 -0700
commit92f192521865137c7e457b4a54c5df4ad2fbb049 (patch)
treeeb8e416b2fc5f22c86078d6068dba138dccf8550
parent8dc9e0d8ec0cd0daeeea80425534a9a4d367e3f9 (diff)
parente473ce1ac4cd2d08f25a5f4eee7e64db99f7f2e4 (diff)
downloadmruby-92f192521865137c7e457b4a54c5df4ad2fbb049.tar.gz
mruby-92f192521865137c7e457b4a54c5df4ad2fbb049.zip
Merge pull request #225 from MobiRuby/fixed_const_missing
fixed const_get && const_missing issue
-rw-r--r--src/variable.c35
1 files changed, 6 insertions, 29 deletions
diff --git a/src/variable.c b/src/variable.c
index a17484903..33cd6ba14 100644
--- a/src/variable.c
+++ b/src/variable.c
@@ -186,7 +186,7 @@ mrb_vm_cv_set(mrb_state *mrb, mrb_sym sym, mrb_value v)
if (k != kh_end(h)) {
k = kh_put(iv, h, sym);
kh_value(h, k) = v;
- return;
+ return;
}
}
c = c->super;
@@ -233,26 +233,8 @@ const_get(mrb_state *mrb, struct RClass *base, mrb_sym sym)
struct RClass *c = base;
khash_t(iv) *h;
khiter_t k;
+ mrb_sym cm = mrb_intern(mrb, "const_missing");
- if (c->iv) {
- h = c->iv;
- k = kh_get(iv, h, sym);
- if (k != kh_end(h)) {
- return kh_value(h, k);
- }
- }
- for (;;) {
- c = mrb_class_outer_module(mrb, c);
- if (!c) break;
- if (c->iv) {
- h = c->iv;
- k = kh_get(iv, h, sym);
- if (k != kh_end(h)) {
- return kh_value(h, k);
- }
- }
- }
- c = base->super;
while (c) {
if (c->iv) {
h = c->iv;
@@ -260,19 +242,14 @@ const_get(mrb_state *mrb, struct RClass *base, mrb_sym sym)
if (k != kh_end(h)) {
return kh_value(h, k);
}
+ if (mrb_respond_to(mrb, mrb_obj_value(c), cm)) {
+ mrb_value argv = mrb_symbol_value(sym);
+ return mrb_funcall_argv(mrb, mrb_obj_value(c), "const_missing", 1, &argv);
+ }
}
c = c->super;
}
- if (!c) {
- c = mrb->object_class;
- }
-
- if (mrb_respond_to(mrb, mrb_obj_value(c), mrb_intern(mrb, "const_missing"))) {
- mrb_value argv = mrb_symbol_value(sym);
- return mrb_funcall_argv(mrb, mrb_obj_value(c), "const_missing", 1, &argv);
- }
-
mrb_raise(mrb, E_NAME_ERROR, "uninitialized constant %s",
mrb_sym2name(mrb, sym));
/* not reached */