diff options
| author | Lothar Scholz <[email protected]> | 2017-12-24 06:28:38 +0100 |
|---|---|---|
| committer | Lothar Scholz <[email protected]> | 2017-12-24 06:28:38 +0100 |
| commit | a9d0d90f7417007db510b77caa6098ebcb6d5b7a (patch) | |
| tree | 2fc260a1e37f288dda0ad4f06d9e7ab0ad6147a3 | |
| parent | 06f90a3b45fa4f241bbc43e91287aa9a127dc8c3 (diff) | |
| download | mruby-a9d0d90f7417007db510b77caa6098ebcb6d5b7a.tar.gz mruby-a9d0d90f7417007db510b77caa6098ebcb6d5b7a.zip | |
Removed the Visual Studio Version Check because it does not
work with internationalized versions of Visual Studio. It will capture
the returned string in the local codepage encoding and make ruby exits
with an invalid UTF8 error message.
Also "Version" might be translated and not appear in the output.
| -rw-r--r-- | tasks/toolchains/visualcpp.rake | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/tasks/toolchains/visualcpp.rake b/tasks/toolchains/visualcpp.rake index 5bc24a73a..b008273a2 100644 --- a/tasks/toolchains/visualcpp.rake +++ b/tasks/toolchains/visualcpp.rake @@ -55,14 +55,15 @@ MRuby::Toolchain.new(:visualcpp) do |conf, _params| conf.file_separator = '\\' - if require 'open3' - Open3.popen3 conf.cc.command do |_, _, e, _| - if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17 - m = "# VS2010/2012 support will be dropped after the next release! #" - h = "#" * m.length - puts h, m, h - end - end - end + # Unreliable detection and will result in invalid encoding errors for localized versions of Visual C++ + # if require 'open3' + # Open3.popen3 conf.cc.command do |_, _, e, _| + # if /Version (\d{2})\.\d{2}\.\d{5}/ =~ e.gets && $1.to_i <= 17 + # m = "# VS2010/2012 support will be dropped after the next release! #" + # h = "#" * m.length + # puts h, m, h + # end + # end + # end end |