summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorTomoyuki Sahara <[email protected]>2017-06-05 16:21:30 +0900
committerGitHub <[email protected]>2017-06-05 16:21:30 +0900
commitdab87cf96016aa245a0d5b1ac29559672966c377 (patch)
treeeab3f3fe0b03cef0e9db381fbef3c732b4baa565
parent0c0b34136e17b2452e3122f22813ca71d75434fd (diff)
parenta3a4f4d061ed4fc1debbee0fe172a786c7c152d5 (diff)
downloadmruby-dab87cf96016aa245a0d5b1ac29559672966c377.tar.gz
mruby-dab87cf96016aa245a0d5b1ac29559672966c377.zip
Merge pull request #80 from ksss/sysread
IO#sysread Check for readable
-rw-r--r--src/io.c3
-rw-r--r--test/io.rb5
2 files changed, 8 insertions, 0 deletions
diff --git a/src/io.c b/src/io.c
index 6d1b39cc5..e0de0ca36 100644
--- a/src/io.c
+++ b/src/io.c
@@ -637,6 +637,9 @@ mrb_io_sysread(mrb_state *mrb, mrb_value io)
}
fptr = (struct mrb_io *)io_get_open_fptr(mrb, io);
+ if (!fptr->readable) {
+ mrb_raise(mrb, E_IO_ERROR, "not opened for reading");
+ }
ret = read(fptr->fd, RSTRING_PTR(buf), maxlen);
switch (ret) {
case 0: /* EOF */
diff --git a/test/io.rb b/test/io.rb
index 9ce8985f7..ee4309b57 100644
--- a/test/io.rb
+++ b/test/io.rb
@@ -238,6 +238,11 @@ assert('IO.sysopen, IO#sysread') do
assert_raise(IOError) { io.sysread(1) }
assert_raise(ArgumentError) { io.sysread(-1) }
io.closed?
+
+ fd = IO.sysopen $mrbtest_io_wfname, "w"
+ io = IO.new fd, "w"
+ assert_raise(IOError) { io.sysread(1) }
+ io.close
end
assert('IO.sysopen, IO#syswrite') do