diff options
| author | Yukihiro "Matz" Matsumoto <[email protected]> | 2020-04-28 22:36:32 +0900 |
|---|---|---|
| committer | Yukihiro "Matz" Matsumoto <[email protected]> | 2020-04-28 22:37:14 +0900 |
| commit | e2ac2a82a5c344de3369a6f988ec40bb5510ab45 (patch) | |
| tree | a4d7b37e43e9d0d5705ee81ed61176a73341e37c | |
| parent | bb6290a5d581ffe9c663725374ad3e220996e26c (diff) | |
| download | mruby-e2ac2a82a5c344de3369a6f988ec40bb5510ab45.tar.gz mruby-e2ac2a82a5c344de3369a6f988ec40bb5510ab45.zip | |
Should not use `assert` with expressions with side-effect; ref #4981
`assert()` can be completely removed when `NDEBUG` is set.
| -rw-r--r-- | mrbgems/mruby-io/test/mruby_io_test.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/mrbgems/mruby-io/test/mruby_io_test.c b/mrbgems/mruby-io/test/mruby_io_test.c index 7165d09cc..4dce48c26 100644 --- a/mrbgems/mruby-io/test/mruby_io_test.c +++ b/mrbgems/mruby-io/test/mruby_io_test.c @@ -53,7 +53,6 @@ mkdtemp(char *temp) #include <sys/socket.h> #include <unistd.h> #include <sys/un.h> - #include <assert.h> #include <fcntl.h> #endif @@ -117,10 +116,8 @@ mrb_io_test_io_setup(mrb_state *mrb, mrb_value self) char *tmpdir; wd_save = open(".", O_DIRECTORY); tmpdir = getenv("TMPDIR"); - if (tmpdir) - assert(!chdir(tmpdir)); - else - assert(!chdir("/tmp")); + if (tmpdir) chdir(tmpdir); + else chdir("/tmp"); } #endif @@ -220,7 +217,7 @@ mrb_io_test_io_cleanup(mrb_state *mrb, mrb_value self) #if !defined(_WIN32) && !defined(_WIN64) if(!socket_available_p) { - assert(!fchdir(wd_save)); + fchdir(wd_save); close(wd_save); } #endif |