summaryrefslogtreecommitdiffhomepage
path: root/mrbgems/mruby-binding/test
diff options
context:
space:
mode:
authordearblue <[email protected]>2021-06-26 10:52:56 +0900
committerdearblue <[email protected]>2021-06-26 13:43:36 +0900
commitc182903ea0ee5c904725f336373f608962059996 (patch)
tree9ec19890875f891f287d002664699ccdfb12318b /mrbgems/mruby-binding/test
parent5fc301f07d0ce26ab93ff237d15fa81894c9f1d6 (diff)
downloadmruby-c182903ea0ee5c904725f336373f608962059996.tar.gz
mruby-c182903ea0ee5c904725f336373f608962059996.zip
Fixed finding variables from `proc` in `binding.eval` failed
Previously the following code did not produce the expected results: ```ruby bx = binding block = bx.eval("a = 1; proc { a }") bx.eval("a = 2") p block.call # Expect 2 but return 1 due to a bug ``` The previous implementation of `Binding#eval` evaluated the code and then merged the top layer variables. This patch will parse and expand the variable space before making a call to `eval`. This means that the call to `Binding#eval` will do the parsing twice. In addition, the following changes will be made: - Make `mrb_parser_foreach_top_variable()`, `mrb_binding_extract_proc()` and `mrb_binding_extract_env()` functions private global functions. - Remove the `posthook` argument from `mrb_exec_irep()`. The `posthook` argument was introduced to implement the `binding` method. This patch is unnecessary because it uses a different implementation method. ref #5362 fixed #5491
Diffstat (limited to 'mrbgems/mruby-binding/test')
-rw-r--r--mrbgems/mruby-binding/test/binding.rb7
1 files changed, 7 insertions, 0 deletions
diff --git a/mrbgems/mruby-binding/test/binding.rb b/mrbgems/mruby-binding/test/binding.rb
index 7dd3fd1dd..296fb48d4 100644
--- a/mrbgems/mruby-binding/test/binding.rb
+++ b/mrbgems/mruby-binding/test/binding.rb
@@ -68,3 +68,10 @@ assert "Binding#eval with Binding.new via Method" do
assert_true true
end
+
+assert "access local variables into procs" do
+ bx = binding
+ block = bx.eval("a = 1; proc { a }")
+ bx.eval("a = 2")
+ assert_equal 2, block.call
+end