Merge pull request #5045 from dearblue/memsize_of

Improve `mruby-os-memsize`

1 files changed, 16 insertions, 2 deletions

diff --git a/mrbgems/mruby-os-memsize/src/memsize.c b/mrbgems/mruby-os-memsize/src/memsize.c
index d82c6b7ed..14f90109d 100644
--- a/mrbgems/mruby-os-memsize/src/memsize.c
+++ b/mrbgems/mruby-os-memsize/src/memsize.c
@@ -44,6 +44,19 @@ os_memsize_of_method(mrb_state* mrb, mrb_value method_obj)
   return size;
 }
 
+static mrb_bool
+obj_is_kind_of_checked(mrb_state *mrb, mrb_value obj, const char *classname)
+{
+  mrb_value objclass = mrb_obj_value(mrb->object_class);
+
+  if (mrb_const_defined(mrb, objclass, mrb_intern_cstr(mrb, classname))) {
+    struct RClass *klass = mrb_class_get(mrb, classname);
+    return mrb_obj_is_kind_of(mrb, obj, klass);
+  }
+
+  return FALSE;
+}
+
 static mrb_int
 os_memsize_of_object(mrb_state* mrb, mrb_value obj)
 {
@@ -54,6 +67,7 @@ os_memsize_of_object(mrb_state* mrb, mrb_value obj)
       size += mrb_objspace_page_slot_size();
       if (!RSTR_EMBED_P(RSTRING(obj)) && !RSTR_SHARED_P(RSTRING(obj))) {
         size += RSTRING_CAPA(obj);
+        size++; /* NUL terminator */
       }
       break;
     case MRB_TT_CLASS:
@@ -66,8 +80,8 @@ os_memsize_of_object(mrb_state* mrb, mrb_value obj)
     case MRB_TT_OBJECT: {
       size += mrb_objspace_page_slot_size();
       size += os_memsize_of_ivars(mrb, obj);
-      if (mrb_obj_is_kind_of(mrb, obj, mrb_class_get(mrb, "UnboundMethod")) ||
-          mrb_obj_is_kind_of(mrb, obj, mrb_class_get(mrb, "Method"))){
+      if (obj_is_kind_of_checked(mrb, obj, "UnboundMethod") ||
+          obj_is_kind_of_checked(mrb, obj, "Method")) {
         size += os_memsize_of_method(mrb, obj);
       }
       break;