summaryrefslogtreecommitdiffhomepage
path: root/mrbgems/mruby-rational
diff options
context:
space:
mode:
authorKOBAYASHI Shuji <[email protected]>2019-07-30 12:46:24 +0900
committerKOBAYASHI Shuji <[email protected]>2019-07-30 13:05:01 +0900
commit44381f0a0c306a8c778f546926d3febfdf981b45 (patch)
tree4dab936e4d182906b3c32a3c810f09d1f4add693 /mrbgems/mruby-rational
parentff43b2b97c77812abbcbfe14da4582c6c209be9b (diff)
downloadmruby-44381f0a0c306a8c778f546926d3febfdf981b45.tar.gz
mruby-44381f0a0c306a8c778f546926d3febfdf981b45.zip
Refine message to `skip` in nested `assert`
- I think "Info" is used only to `skip`, so change to "Skip". - Changed the default value of `assert` and specify the argument explicitly at the caller of `assert` because it is unnatural "Assertion failed" is output even though the assertion doesn't fail. == Example: def assert_foo(exp, act) assert do assert_equal exp[0], act[0] assert_equal exp[1], act[1] end end def assert_bar(exp, act) assert do skip end end def assert_baz(exp, act) assert do assert_equal exp, act assert_bar exp, act end end assert 'test#skip_in_nested_assert' do assert_baz 1, 1 end === Before this patch: ?.. Info: test#skip_in_nested_assert (core) - Assertion[1] Info: Assertion failed (core) - Assertion[1-2] Skip: Assertion failed (core) Total: 3 OK: 2 KO: 0 Crash: 0 Warning: 0 Skip: 1 === After this patch: ??? Skip: test#skip_in_nested_assert (core) - Assertion[1] Skip: assert (core) - Assertion[1-2] Skip: assert (core) Total: 3 OK: 0 KO: 0 Crash: 0 Warning: 0 Skip: 3
Diffstat (limited to 'mrbgems/mruby-rational')
-rw-r--r--mrbgems/mruby-rational/test/rational.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/mrbgems/mruby-rational/test/rational.rb b/mrbgems/mruby-rational/test/rational.rb
index 11737034b..a8ebb8ea2 100644
--- a/mrbgems/mruby-rational/test/rational.rb
+++ b/mrbgems/mruby-rational/test/rational.rb
@@ -23,14 +23,14 @@ class ComplexLikeNumeric < UserDefinedNumeric
end
def assert_rational(exp, real)
- assert do
+ assert "assert_rational" do
assert_float exp.numerator, real.numerator
assert_float exp.denominator, real.denominator
end
end
def assert_equal_rational(exp, o1, o2)
- assert do
+ assert "assert_equal_rational" do
if exp
assert_operator(o1, :==, o2)
assert_not_operator(o1, :!=, o2)