summaryrefslogtreecommitdiffhomepage
path: root/src/vm.c
diff options
context:
space:
mode:
authorcremno <[email protected]>2014-05-05 15:24:22 +0200
committercremno <[email protected]>2014-05-05 15:24:22 +0200
commit0f3930426515848be755c5480df354fa9e2109f4 (patch)
tree55997d13d181d852b2522aa0b3b69831b384e352 /src/vm.c
parentff03cea79b710913af1f5decec1952c14ba67812 (diff)
downloadmruby-0f3930426515848be755c5480df354fa9e2109f4.tar.gz
mruby-0f3930426515848be755c5480df354fa9e2109f4.zip
add function for checked mrb_int addition
Diffstat (limited to 'src/vm.c')
-rw-r--r--src/vm.c13
1 files changed, 4 insertions, 9 deletions
diff --git a/src/vm.c b/src/vm.c
index 0e3c0a81e..85a121f2c 100644
--- a/src/vm.c
+++ b/src/vm.c
@@ -12,6 +12,7 @@
#include "mruby/class.h"
#include "mruby/hash.h"
#include "mruby/irep.h"
+#include "mruby/numeric.h"
#include "mruby/proc.h"
#include "mruby/range.h"
#include "mruby/string.h"
@@ -1610,12 +1611,7 @@ RETRY_TRY_BLOCK:
x = mrb_fixnum(regs_a[0]);
y = mrb_fixnum(regs_a[1]);
- z = x + y;
-#ifdef MRB_WORD_BOXING
- z = (z << MRB_FIXNUM_SHIFT) / (1 << MRB_FIXNUM_SHIFT);
-#endif
- if ((x < 0) != (z < 0) && ((x < 0) ^ (y < 0)) == 0) {
- /* integer overflow */
+ if (mrb_int_add_overflow(x, y, &z)) {
SET_FLT_VALUE(mrb, regs_a[0], (mrb_float)x + (mrb_float)y);
break;
}
@@ -1842,10 +1838,9 @@ RETRY_TRY_BLOCK:
{
mrb_int x = regs[a].attr_i;
mrb_int y = GETARG_C(i);
- mrb_int z = x + y;
+ mrb_int z;
- if (((x < 0) ^ (y < 0)) == 0 && (x < 0) != (z < 0)) {
- /* integer overflow */
+ if (mrb_int_add_overflow(x, y, &z)) {
SET_FLT_VALUE(mrb, regs[a], (mrb_float)x + (mrb_float)y);
break;
}