| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2021-11-12 | test/syntax.rb: test argument forwarding without parentheses. | Yukihiro "Matz" Matsumoto | |
| 2021-10-12 | Support Ruby3.0 keyword arguments. | Yukihiro "Matz" Matsumoto | |
| The Difference Since Ruby1.9, the keyword arguments were emulated by Ruby using the hash object at the bottom of the arguments. But we have gradually moved toward keyword arguments separated from normal (positinal) arguments. At the same time, we value compatibility, so that Ruby3.0 keyword arguments are somewhat compromise. Basically, keyword arguments are separated from positional arguments, except when the method does not take any formal keyword arguments, given keyword arguments (packed in the hash object) are considered as the last argument. And we also allow non symbol keys in the keyword arguments. In that case, those keys are just passed in the `**` hash (or raise `ArgumentError` for unknown keys). The Instruction Changes We have changed `OP_SEND` instruction. `OP_SEND` instruction used to take 3 operands, the register, the symbol, the number of (positional) arguments. The meaning of the third operand has been changed. It is now considered as `n|(nk<<4)`, where `n` is the number of positional arguments, and `nk` is the number of keyword arguments, both occupies 4 bits in the operand. The number `15` in both `n` and `nk` means variable sized arguments are packed in the object. Positional arguments will be packed in the array, and keyword arguments will be packed in the hash object. That means arguments more than 14 values are always packed in the object. Arguments information for other instructions (`OP_SENDB` and `OP_SUPER`) are also changed. It works as the third operand of `OP_SEND`. the difference between `OP_SEND` and `OP_SENDB` is just trivial. It assigns `nil` to the block hidden arguments (right after arguments). The instruction `OP_SENDV` and `OP_SENDVB` are removed. Those instructions are replaced by `OP_SEND` and `OP_SENDB` respectively with the `15` (variable sized) argument information. Calling Convention When calling a method, the stack elements shall be in the order of the receiver of the method, positional arguments, keyword arguments and the block argument. If the number of positional or keyword arugument (`n` or `nk`) is zero, corresponding arguments will be empty. So when `n=0` and `nk=0` the stack layout (from bottom to top) will be: +-----------------------+ | recv | block (or nil) | +-----------------------+ The last elements `block` should be explicitly filled before `OP_SEND` or assigned to `nil` by `OP_SENDB` internally. In other words, the following have exactly same behavior: OP_SENDB clears `block` implicitly: ``` OP_SENDB reg sym 0 ``` OP_SEND clears `block` implicitly: ``` OP_LOADNIL R2 OP_SEND R2 sym 0 ``` When calling a method with only positional arguments (n=0..14) without keyword arguments, the stack layout will be like following: +--------------------------------------------+ | recv | arg1 | ... | arg_n | block (or nil) | +--------------------------------------------+ When calling a method with arguments packed in the array (n=15) which means argument splat (*) is used in the actual arguments, or more than 14 arguments are passed the stack layout will be like following: +-------------------------------+ | recv | array | block (or nil) | +-------------------------------+ The number of the actual arguments is determined by the length of the argument array. When keyword arguments are given (nk>0), keyword arguments are passed between positional arguments and the block argument. For example, when we pass one positional argument `1` and one keyword argument `a: 2`, the stack layout will be like: +------------------------------------+ | recv | 1 | :a | 2 | block (or nil) | +------------------------------------+ Note that keyword arguments consume `2*nk` elements in the stack when `nk=0..14` (unpacked). When calling a method with keyword arguments packed in the hash object (nk=15) which means keyword argument splat (**) is used or more than 14 keyword arguments in the actual arguments, the stack layout will be like: +------------------------------+ | recv | hash | block (or nil) | +------------------------------+ Note for mruby/c When mruby/c authors try to support new keyword arguments, they need to handle the new meaning of the argument information operand. If they choose not to support keyword arguments in mruby/c, it just raise error when `nk` (taken by `(c>>4)&0xf`) is not zero. And combine `OP_SENDV` behavior with `OP_SEND` when `n` is `15`. If they want to support keyword arguments seriously, contact me at <[email protected]> or `@yukihiro_matz`. I can help you. | |||
| 2021-07-15 | test/syntax.rb: add tests for `break` and `redo`. | Yukihiro "Matz" Matsumoto | |
| 2021-07-15 | Merge pull request #4141 from udzura/add-test-for-attr-nil-guard | Yukihiro "Matz" Matsumoto | |
| Add a testcase of #4137 fix | |||
| 2021-05-21 | test/syntax.rb: fix endless def warning (no assertion). | Yukihiro "Matz" Matsumoto | |
| 2021-05-18 | parse.y: allow "command" syntax in endless method definition. | Yukihiro "Matz" Matsumoto | |
| This change allows `def hello = puts "Hello"` without parentheses. This syntax has been introduced since Ruby3.1. | |||
| 2021-03-31 | codegen.c: `yield` outside of method is now `SyntaxError`. | Yukihiro "Matz" Matsumoto | |
| 2020-12-09 | Argument forwarding with `...` now supports leading arguments. | Yukihiro "Matz" Matsumoto | |
| ```ruby def method_missing(meth, ...) send(:"do_#{meth}", ...) end ``` | |||
| 2020-11-02 | Replace `R-assignment` by `single-line pattern matching`. | Yukihiro "Matz" Matsumoto | |
| Since `R-assignment` in CRuby is abandoned. Single-line pattern matching in `mruby` only matches single local variable at the moment. Currently it works as a right assignment to a local variable. It will be enhanced in the future. | |||
| 2020-10-12 | Rightward-assign by ASSOC. | Yukihiro "Matz" Matsumoto | |
| [ruby-bugs:15921] | |||
| 2019-12-21 | Numbered parameters should not be available in the lambda bodies. | Yukihiro "Matz" Matsumoto | |
| `mruby` does not warn like `CRuby` for cases like #4893. Fix #4890, fix #4891, fix #4893. | |||
| 2019-12-21 | `_0` is not numbered parameter | KOBAYASHI Shuji | |
| #### Before this patch: ```console $ bin/mruby rb -e '_0=:l; p ->{_0}.()' -e:1:13: _0 is not available -e:1:13: syntax error, unexpected $end, expecting '}' ``` #### After this patch (same as Ruby): ```console $ bin/mruby rb -e '_0=:l; p ->{_0}.()' :l ``` | |||
| 2019-12-09 | Support new numbered parameter syntax `_1` instead of `@1`. | Yukihiro "Matz" Matsumoto | |
| 2019-12-09 | Implement numbered parameters | Ukrainskiy Sergey | |
| 2019-10-03 | Add tests for #4746 | KOBAYASHI Shuji | |
| 2019-06-09 | Fix missing assertions in `test/t/syntax.rb` | KOBAYASHI Shuji | |
| 2018-11-05 | Fixed a bug in argument number check with kwargs; fix #4159 | Yukihiro "Matz" Matsumoto | |
| 2018-10-15 | Add a testcase of #4137 fix | Uchio KONDO | |
| 2018-09-07 | Clear terminated space | dearblue | |
| 2018-07-31 | Add test case corresponding to 53e2723. | Yukihiro "Matz" Matsumoto | |
| 2018-07-30 | Keyword argument implemented. | Yukihiro "Matz" Matsumoto | |
| 2017-04-13 | Update NODE_XSTR, NODE_DSXTR tests; ref #3605 | Yukihiro "Matz" Matsumoto | |
| 2016-12-01 | Add test for recently fixed bugs | Yutaka HARA | |
| 2016-09-08 | Add testing for regression | ksss | |
| 2016-07-14 | Should raise LocalJumpError when no block given | ksss | |
| 2015-11-17 | mruby-1.2.01.2.0 | mimaki | |
| 2015-09-02 | Make travis happy | Zachary Scott | |
| We have do this because mruby's test files are found using MRUBY_ROOT, like this: mrbs = Dir.glob("#{MRUBY_ROOT}/test/t/*.rb") | |||
| 2015-05-31 | fix masgn nosplat array rhs bug | cremno | |
| The rest lhs variable has to be an empty array if rhs is an array with less elements than pre + post lhs variables. The codegen generated OP_ARRAY with an invalid length (such as 127 for *a, b = []) because rn was negative. | |||
| 2015-05-31 | update test/t/syntax.rb to success on CRuby | Yukihiro "Matz" Matsumoto | |
| 2015-05-29 | add multiple assignment with rest tests | cremno | |
| 2015-05-07 | fix splat without assignment; fix #2781 | cremno | |
| The parser generates NODE_NIL for tSTAR without argument in masgns. The codegen didn't handle that. | |||
| 2015-02-24 | Fix a bug that no expression case doesn't return valid value | Kouhei Sutou | |
| Here is a script that reproduces this problem: x = case when true; 1 end p x # => main # 1 is expected | |||
| 2015-02-24 | Fix a bug that if and no return value case can't return true clause value | Kouhei Sutou | |
| Here is a script that reproduce this problem: x = if true 1 else case 2 when 3 end 4 end p x # => nil # 1 is expected | |||
| 2014-12-23 | Fix splat and multiple assignments | Kouhei Sutou | |
| Case1: From variable Code: a = [1, 2, 3, 4, 5] b, c, *d = a p [a, b, c, d] Before: [[1, 2, 3, 4, 5], 1, 2, []] After: [[1, 2, 3, 4, 5], 1, 2, [3, 4, 5]] Ruby: [[1, 2, 3, 4, 5], 1, 2, [3, 4, 5]] Case2: From variables Code: a = [1, 2, 3] b = [4, 5, 6, 7] c, d, *e, f, g = *a, *b p [a, b, c, d, e, f, g] Before: [[1, 2, 3], [4, 5, 6, 7], 1, 2, [], 6, 7] After: [[1, 2, 3], [4, 5, 6, 7], 1, 2, [3, 4, 5], 6, 7] Ruby: [[1, 2, 3], [4, 5, 6, 7], 1, 2, [3, 4, 5], 6, 7] Case 3: "for" Code: a = [1, 2, 3, 4, 5, 6, 7] for b, c, *d, e, f in [a] do p [a, b, c, d, e, f] end Before: [[1, 2, 3, 4, 5, 6, 7], 1, 2, [], nil, nil] After: [[1, 2, 3, 4, 5, 6, 7], 1, 2, [3, 4, 5], 6, 7] Ruby: [[1, 2, 3, 4, 5, 6, 7], 1, 2, [3, 4, 5], 6, 7] | |||
| 2014-11-27 | add multiple assignment decomposition test | Yukihiro "Matz" Matsumoto | |
| 2014-05-03 | count skipped line numbers | Nobuyoshi Nakada | |
| 2014-05-03 | skip to the next line and reset column after `=end` | Nobuyoshi Nakada | |
| 2014-05-03 | fix embedded documents | Nobuyoshi Nakada | |
| tabs are allowed after `=begin` and `=end`. raise `SyntaxError` if no =end is found. | |||
| 2014-04-28 | Add tests for multiline comment parsing | Carson McDonald | |
| 2014-04-21 | tests should not depend on `mruby-proc-ext` | cremno | |
| 2014-04-21 | fix optional block arguments in rhs | Nobuyoshi Nakada | |
| define optional block arguments as argument variables in the rhs default expressions, as same as mere assignment expressions. Import ruby/ruby@01740f0c273c89f7bcff3d5014d73c8ff6fb1986 | |||
| 2014-04-21 | fix optional arguments in rhs | Nobuyoshi Nakada | |
| define optional arguments as argument variables in the rhs default expressions, as same as mere assignment expressions. Import ruby/ruby@01740f0c273c89f7bcff3d5014d73c8ff6fb1986 | |||
| 2014-04-21 | allow method definition in cmdarg | Nobuyoshi Nakada | |
| save cmdarg_stack and isolate command argument state from outer scope to allow method definition in cmdarg import from ruby/ruby@04bb9d6b75a55d4000700769eead5a5cb942c25b | |||
| 2014-04-19 | Allow parenthesed do-block in cmdarg | Nobuyoshi Nakada | |
| Flush cmdarg flags inside left-paren in a command argument, to allow parenthesed `do-block` as an argument without arguments parentheses. `CMDARG_PUSH(0)` for tLPAREN_ARG is before `CMDARG_PUSH(1)` in `command_args` due to look-ahead. | |||
| 2014-03-28 | Add test for backquote. | take_cheeze | |
| * Implement code generation of NODE_DXSTR. * Fix NOVAL NODE_XSTR. | |||
| 2014-03-05 | __FILE__ test: add support for \ as separator | cremno | |
| 2014-02-26 | add test for __LINE__ and __FILE__ | take_cheeze | |
| 2014-01-06 | tests for "case" expression. | Tomoyuki Sahara | |
| 2014-01-04 | Test case statement with splat | Carson McDonald | |
| 2013-12-20 | add some tests for case statements | h2so5 | |
