diff options
| author | Aiden Cline <[email protected]> | 2025-12-03 21:08:12 -0600 |
|---|---|---|
| committer | Aiden Cline <[email protected]> | 2025-12-03 21:08:12 -0600 |
| commit | 88cfb979bec05d31ad01be9ccc3fd998a4429987 (patch) | |
| tree | a05eea96dcf7e3ff75900f44ce1f2ee10d410104 /.github/workflows | |
| parent | 32b5db754e948e010db8b010ba26d3331a747d77 (diff) | |
| download | opencode-88cfb979bec05d31ad01be9ccc3fd998a4429987.tar.gz opencode-88cfb979bec05d31ad01be9ccc3fd998a4429987.zip | |
ci: add note about iife
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/review.yml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/.github/workflows/review.yml b/.github/workflows/review.yml index c726081fc..32c7c7b11 100644 --- a/.github/workflows/review.yml +++ b/.github/workflows/review.yml @@ -74,7 +74,9 @@ jobs: </pr-description> Please check all the code changes in this pull request against the style guide, also look for any bugs if they exist. Diffs are important but make sure you read the entire file to get proper context. Make it clear the suggestions are merely suggestions and the human can decide what to do + When critiquing code against the style guide, be sure that the code is ACTUALLY in violation, don't complain about else statements if they already use early returns there. You may complain about excessive nesting though, regardless of else statement usage. + When critiquing code style don't be a zealot, we don't like "let" statements but sometimes they are the simpliest option, if someone does a bunch of nesting with let, they should consider using iife (see packages/opencode/src/util.iife.ts) Use the gh cli to create comments on the files for the violations. Try to leave the comment on the exact line number. If you have a suggested fix include it in a suggestion code block. |