diff options
| author | Kit Langton <[email protected]> | 2026-03-27 13:32:05 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2026-03-27 17:32:05 +0000 |
| commit | d36b38e4a6f5b778644669ba281fb5a35cf2f028 (patch) | |
| tree | f22f6b49cb1141aa90388f1fbf5de6a76ad5fb69 | |
| parent | bdd7829c689830668ae9a6026f3187196774797c (diff) | |
| download | opencode-d36b38e4a6f5b778644669ba281fb5a35cf2f028.tar.gz opencode-d36b38e4a6f5b778644669ba281fb5a35cf2f028.zip | |
fix(desktop-electron): match dev dock icon inset on macOS (#19429)
| -rw-r--r-- | packages/desktop-electron/icons/README.md | 3 | ||||
| -rw-r--r-- | packages/desktop-electron/icons/beta/dock.png | bin | 0 -> 33332 bytes | |||
| -rw-r--r-- | packages/desktop-electron/icons/dev/dock.png | bin | 0 -> 50483 bytes | |||
| -rw-r--r-- | packages/desktop-electron/icons/prod/dock.png | bin | 0 -> 38916 bytes | |||
| -rw-r--r-- | packages/desktop-electron/src/main/windows.ts | 3 |
5 files changed, 5 insertions, 1 deletions
diff --git a/packages/desktop-electron/icons/README.md b/packages/desktop-electron/icons/README.md index fa219a77e..cf2f8e24c 100644 --- a/packages/desktop-electron/icons/README.md +++ b/packages/desktop-electron/icons/README.md @@ -9,3 +9,6 @@ Here's the process I've been using to create icons: The Image2Icon step is necessary as the `icon.icns` generated by `app-icon.png` does not apply the shadow/padding expected by macOS, so app icons appear larger than expected. + +For unpackaged Electron on macOS, `app.dock.setIcon()` should use a PNG. Keep `dock.png` in each channel folder synced with the +extracted `[email protected]` from that channel's `icon.icns` so the dev Dock icon matches the packaged app inset. diff --git a/packages/desktop-electron/icons/beta/dock.png b/packages/desktop-electron/icons/beta/dock.png Binary files differnew file mode 100644 index 000000000..f274ef645 --- /dev/null +++ b/packages/desktop-electron/icons/beta/dock.png diff --git a/packages/desktop-electron/icons/dev/dock.png b/packages/desktop-electron/icons/dev/dock.png Binary files differnew file mode 100644 index 000000000..4953d5531 --- /dev/null +++ b/packages/desktop-electron/icons/dev/dock.png diff --git a/packages/desktop-electron/icons/prod/dock.png b/packages/desktop-electron/icons/prod/dock.png Binary files differnew file mode 100644 index 000000000..f2ab694e9 --- /dev/null +++ b/packages/desktop-electron/icons/prod/dock.png diff --git a/packages/desktop-electron/src/main/windows.ts b/packages/desktop-electron/src/main/windows.ts index 0b7783f28..170cd877c 100644 --- a/packages/desktop-electron/src/main/windows.ts +++ b/packages/desktop-electron/src/main/windows.ts @@ -50,7 +50,8 @@ export function setTitlebar(win: BrowserWindow, theme: Partial<TitlebarTheme> = export function setDockIcon() { if (process.platform !== "darwin") return - app.dock?.setIcon(nativeImage.createFromPath(join(iconsDir(), "[email protected]"))) + const icon = nativeImage.createFromPath(join(iconsDir(), "dock.png")) + if (!icon.isEmpty()) app.dock?.setIcon(icon) } export function createMainWindow(globals: Globals) { |
