summaryrefslogtreecommitdiffhomepage
path: root/packages/app
diff options
context:
space:
mode:
authorDavid Hill <[email protected]>2026-03-06 22:33:34 +0000
committerGitHub <[email protected]>2026-03-06 16:33:34 -0600
commitb0bc3d87f59fb28340fc4c047131919031890898 (patch)
tree35c56cbdb069fb720de642d7a4cc0bd6332e3747 /packages/app
parenta2634337b84643c08df5337243e8f82399c85615 (diff)
downloadopencode-b0bc3d87f59fb28340fc4c047131919031890898.tar.gz
opencode-b0bc3d87f59fb28340fc4c047131919031890898.zip
feat(app): sidebar reveal animation, hover peek overlay, and weaker dividers (#16374)
Co-authored-by: Adam <[email protected]>
Diffstat (limited to 'packages/app')
-rw-r--r--packages/app/e2e/actions.ts93
-rw-r--r--packages/app/e2e/app/titlebar-history.spec.ts4
-rw-r--r--packages/app/e2e/projects/project-edit.spec.ts18
-rw-r--r--packages/app/e2e/projects/projects-switch.spec.ts46
-rw-r--r--packages/app/e2e/projects/workspaces.spec.ts3
-rw-r--r--packages/app/e2e/settings/settings-keybinds.spec.ts15
-rw-r--r--packages/app/e2e/sidebar/sidebar-popover-actions.spec.ts11
-rw-r--r--packages/app/e2e/sidebar/sidebar-session-links.spec.ts1
-rw-r--r--packages/app/e2e/sidebar/sidebar.spec.ts13
-rw-r--r--packages/app/src/pages/layout.tsx200
-rw-r--r--packages/app/src/pages/layout/sidebar-shell.tsx26
-rw-r--r--packages/app/src/pages/layout/sidebar-workspace.tsx4
-rw-r--r--packages/app/src/pages/session/session-side-panel.tsx4
-rw-r--r--packages/app/src/pages/session/terminal-panel.tsx4
14 files changed, 301 insertions, 141 deletions
diff --git a/packages/app/e2e/actions.ts b/packages/app/e2e/actions.ts
index 919a1add8..5d244ba02 100644
--- a/packages/app/e2e/actions.ts
+++ b/packages/app/e2e/actions.ts
@@ -5,10 +5,10 @@ import path from "node:path"
import { execSync } from "node:child_process"
import { modKey, serverUrl } from "./utils"
import {
- sessionItemSelector,
dropdownMenuTriggerSelector,
dropdownMenuContentSelector,
projectMenuTriggerSelector,
+ projectCloseMenuSelector,
projectWorkspacesToggleSelector,
titlebarRightSelector,
popoverBodySelector,
@@ -61,9 +61,9 @@ export async function closeDialog(page: Page, dialog: Locator) {
}
export async function isSidebarClosed(page: Page) {
- const main = page.locator("main")
- const classes = (await main.getAttribute("class")) ?? ""
- return classes.includes("xl:border-l")
+ const button = page.getByRole("button", { name: /toggle sidebar/i }).first()
+ await expect(button).toBeVisible()
+ return (await button.getAttribute("aria-expanded")) !== "true"
}
export async function toggleSidebar(page: Page) {
@@ -75,48 +75,34 @@ export async function openSidebar(page: Page) {
if (!(await isSidebarClosed(page))) return
const button = page.getByRole("button", { name: /toggle sidebar/i }).first()
- const visible = await button
- .isVisible()
- .then((x) => x)
- .catch(() => false)
-
- if (visible) await button.click()
- if (!visible) await toggleSidebar(page)
+ await button.click()
- const main = page.locator("main")
- const opened = await expect(main)
- .not.toHaveClass(/xl:border-l/, { timeout: 1500 })
+ const opened = await expect(button)
+ .toHaveAttribute("aria-expanded", "true", { timeout: 1500 })
.then(() => true)
.catch(() => false)
if (opened) return
await toggleSidebar(page)
- await expect(main).not.toHaveClass(/xl:border-l/)
+ await expect(button).toHaveAttribute("aria-expanded", "true")
}
export async function closeSidebar(page: Page) {
if (await isSidebarClosed(page)) return
const button = page.getByRole("button", { name: /toggle sidebar/i }).first()
- const visible = await button
- .isVisible()
- .then((x) => x)
- .catch(() => false)
-
- if (visible) await button.click()
- if (!visible) await toggleSidebar(page)
+ await button.click()
- const main = page.locator("main")
- const closed = await expect(main)
- .toHaveClass(/xl:border-l/, { timeout: 1500 })
+ const closed = await expect(button)
+ .toHaveAttribute("aria-expanded", "false", { timeout: 1500 })
.then(() => true)
.catch(() => false)
if (closed) return
await toggleSidebar(page)
- await expect(main).toHaveClass(/xl:border-l/)
+ await expect(button).toHaveAttribute("aria-expanded", "false")
}
export async function openSettings(page: Page) {
@@ -220,7 +206,7 @@ export function sessionIDFromUrl(url: string) {
}
export async function hoverSessionItem(page: Page, sessionID: string) {
- const sessionEl = page.locator(sessionItemSelector(sessionID)).first()
+ const sessionEl = page.locator(`[data-session-id="${sessionID}"]`).last()
await expect(sessionEl).toBeVisible()
await sessionEl.hover()
return sessionEl
@@ -570,32 +556,42 @@ export async function openProjectMenu(page: Page, projectSlug: string) {
const trigger = page.locator(projectMenuTriggerSelector(projectSlug)).first()
await expect(trigger).toHaveCount(1)
+ const menu = page
+ .locator(dropdownMenuContentSelector)
+ .filter({ has: page.locator(projectCloseMenuSelector(projectSlug)) })
+ .first()
+ const close = menu.locator(projectCloseMenuSelector(projectSlug)).first()
+
+ const clicked = await trigger
+ .click({ timeout: 1500 })
+ .then(() => true)
+ .catch(() => false)
+
+ if (clicked) {
+ const opened = await menu
+ .waitFor({ state: "visible", timeout: 1500 })
+ .then(() => true)
+ .catch(() => false)
+ if (opened) {
+ await expect(close).toBeVisible()
+ return menu
+ }
+ }
+
await trigger.focus()
await page.keyboard.press("Enter")
- const menu = page.locator(dropdownMenuContentSelector).first()
const opened = await menu
.waitFor({ state: "visible", timeout: 1500 })
.then(() => true)
.catch(() => false)
if (opened) {
- const viewport = page.viewportSize()
- const x = viewport ? Math.max(viewport.width - 5, 0) : 1200
- const y = viewport ? Math.max(viewport.height - 5, 0) : 800
- await page.mouse.move(x, y)
+ await expect(close).toBeVisible()
return menu
}
- await trigger.click({ force: true })
-
- await expect(menu).toBeVisible()
-
- const viewport = page.viewportSize()
- const x = viewport ? Math.max(viewport.width - 5, 0) : 1200
- const y = viewport ? Math.max(viewport.height - 5, 0) : 800
- await page.mouse.move(x, y)
- return menu
+ throw new Error(`Failed to open project menu: ${projectSlug}`)
}
export async function setWorkspacesEnabled(page: Page, projectSlug: string, enabled: boolean) {
@@ -608,11 +604,18 @@ export async function setWorkspacesEnabled(page: Page, projectSlug: string, enab
if (current === enabled) return
- await openProjectMenu(page, projectSlug)
+ const flip = async (timeout?: number) => {
+ const menu = await openProjectMenu(page, projectSlug)
+ const toggle = menu.locator(projectWorkspacesToggleSelector(projectSlug)).first()
+ await expect(toggle).toBeVisible()
+ return toggle.click({ force: true, timeout })
+ }
+
+ const flipped = await flip(1500)
+ .then(() => true)
+ .catch(() => false)
- const toggle = page.locator(projectWorkspacesToggleSelector(projectSlug)).first()
- await expect(toggle).toBeVisible()
- await toggle.click({ force: true })
+ if (!flipped) await flip()
const expected = enabled ? "New workspace" : "New session"
await expect(page.getByRole("button", { name: expected }).first()).toBeVisible()
diff --git a/packages/app/e2e/app/titlebar-history.spec.ts b/packages/app/e2e/app/titlebar-history.spec.ts
index 9d6091176..a4592ff1d 100644
--- a/packages/app/e2e/app/titlebar-history.spec.ts
+++ b/packages/app/e2e/app/titlebar-history.spec.ts
@@ -16,7 +16,6 @@ test("titlebar back/forward navigates between sessions", async ({ page, slug, sd
const link = page.locator(`[data-session-id="${two.id}"] a`).first()
await expect(link).toBeVisible()
- await link.scrollIntoViewIfNeeded()
await link.click()
await expect(page).toHaveURL(new RegExp(`/${slug}/session/${two.id}(?:\\?|#|$)`))
@@ -56,7 +55,6 @@ test("titlebar forward is cleared after branching history from sidebar", async (
const second = page.locator(`[data-session-id="${b.id}"] a`).first()
await expect(second).toBeVisible()
- await second.scrollIntoViewIfNeeded()
await second.click()
await expect(page).toHaveURL(new RegExp(`/${slug}/session/${b.id}(?:\\?|#|$)`))
@@ -76,7 +74,6 @@ test("titlebar forward is cleared after branching history from sidebar", async (
const third = page.locator(`[data-session-id="${c.id}"] a`).first()
await expect(third).toBeVisible()
- await third.scrollIntoViewIfNeeded()
await third.click()
await expect(page).toHaveURL(new RegExp(`/${slug}/session/${c.id}(?:\\?|#|$)`))
@@ -102,7 +99,6 @@ test("keyboard shortcuts navigate titlebar history", async ({ page, slug, sdk, g
const link = page.locator(`[data-session-id="${two.id}"] a`).first()
await expect(link).toBeVisible()
- await link.scrollIntoViewIfNeeded()
await link.click()
await expect(page).toHaveURL(new RegExp(`/${slug}/session/${two.id}(?:\\?|#|$)`))
diff --git a/packages/app/e2e/projects/project-edit.spec.ts b/packages/app/e2e/projects/project-edit.spec.ts
index 4a286fea7..7c20f29ec 100644
--- a/packages/app/e2e/projects/project-edit.spec.ts
+++ b/packages/app/e2e/projects/project-edit.spec.ts
@@ -1,25 +1,15 @@
import { test, expect } from "../fixtures"
-import { openSidebar } from "../actions"
+import { clickMenuItem, openProjectMenu, openSidebar } from "../actions"
test("dialog edit project updates name and startup script", async ({ page, withProject }) => {
await page.setViewportSize({ width: 1400, height: 800 })
- await withProject(async () => {
+ await withProject(async ({ slug }) => {
await openSidebar(page)
const open = async () => {
- const header = page.locator(".group\\/project").first()
- await header.hover()
- const trigger = header.getByRole("button", { name: "More options" }).first()
- await expect(trigger).toBeVisible()
- await trigger.click({ force: true })
-
- const menu = page.locator('[data-component="dropdown-menu-content"]').first()
- await expect(menu).toBeVisible()
-
- const editItem = menu.getByRole("menuitem", { name: "Edit" }).first()
- await expect(editItem).toBeVisible()
- await editItem.click({ force: true })
+ const menu = await openProjectMenu(page, slug)
+ await clickMenuItem(menu, /^Edit$/i, { force: true })
const dialog = page.getByRole("dialog")
await expect(dialog).toBeVisible()
diff --git a/packages/app/e2e/projects/projects-switch.spec.ts b/packages/app/e2e/projects/projects-switch.spec.ts
index 81cca6988..2725100f4 100644
--- a/packages/app/e2e/projects/projects-switch.spec.ts
+++ b/packages/app/e2e/projects/projects-switch.spec.ts
@@ -1,13 +1,7 @@
import { base64Decode } from "@opencode-ai/util/encode"
+import type { Page } from "@playwright/test"
import { test, expect } from "../fixtures"
-import {
- defocus,
- createTestProject,
- cleanupTestProject,
- openSidebar,
- setWorkspacesEnabled,
- sessionIDFromUrl,
-} from "../actions"
+import { defocus, createTestProject, cleanupTestProject, openSidebar, sessionIDFromUrl } from "../actions"
import { projectSwitchSelector, promptSelector, workspaceItemSelector, workspaceNewSessionSelector } from "../selectors"
import { createSdk, dirSlug, sessionPath } from "../utils"
@@ -15,6 +9,37 @@ function slugFromUrl(url: string) {
return /\/([^/]+)\/session(?:\/|$)/.exec(url)?.[1] ?? ""
}
+async function workspaces(page: Page, directory: string, enabled: boolean) {
+ await page.evaluate(
+ ({ directory, enabled }: { directory: string; enabled: boolean }) => {
+ const key = "opencode.global.dat:layout"
+ const raw = localStorage.getItem(key)
+ const data = raw ? JSON.parse(raw) : {}
+ const sidebar = data.sidebar && typeof data.sidebar === "object" ? data.sidebar : {}
+ const current =
+ sidebar.workspaces && typeof sidebar.workspaces === "object" && !Array.isArray(sidebar.workspaces)
+ ? sidebar.workspaces
+ : {}
+ const next = { ...current }
+
+ if (enabled) next[directory] = true
+ if (!enabled) delete next[directory]
+
+ localStorage.setItem(
+ key,
+ JSON.stringify({
+ ...data,
+ sidebar: {
+ ...sidebar,
+ workspaces: next,
+ },
+ }),
+ )
+ },
+ { directory, enabled },
+ )
+}
+
test("can switch between projects from sidebar", async ({ page, withProject }) => {
await page.setViewportSize({ width: 1400, height: 800 })
@@ -60,8 +85,11 @@ test("switching back to a project opens the latest workspace session", async ({
async ({ directory, slug }) => {
rootDir = directory
await defocus(page)
+ await workspaces(page, directory, true)
+ await page.reload()
+ await expect(page.locator(promptSelector)).toBeVisible()
await openSidebar(page)
- await setWorkspacesEnabled(page, slug, true)
+ await expect(page.getByRole("button", { name: "New workspace" }).first()).toBeVisible()
await page.getByRole("button", { name: "New workspace" }).first().click()
diff --git a/packages/app/e2e/projects/workspaces.spec.ts b/packages/app/e2e/projects/workspaces.spec.ts
index 386739526..41c6bea8f 100644
--- a/packages/app/e2e/projects/workspaces.spec.ts
+++ b/packages/app/e2e/projects/workspaces.spec.ts
@@ -336,9 +336,6 @@ test("can reorder workspaces by drag and drop", async ({ page, withProject }) =>
const src = page.locator(workspaceItemSelector(from)).first()
const dst = page.locator(workspaceItemSelector(to)).first()
- await src.scrollIntoViewIfNeeded()
- await dst.scrollIntoViewIfNeeded()
-
const a = await src.boundingBox()
const b = await dst.boundingBox()
if (!a || !b) throw new Error("Failed to resolve workspace drag bounds")
diff --git a/packages/app/e2e/settings/settings-keybinds.spec.ts b/packages/app/e2e/settings/settings-keybinds.spec.ts
index 5e98bd158..e0d590b31 100644
--- a/packages/app/e2e/settings/settings-keybinds.spec.ts
+++ b/packages/app/e2e/settings/settings-keybinds.spec.ts
@@ -32,22 +32,19 @@ test("changing sidebar toggle keybind works", async ({ page, gotoSession }) => {
await closeDialog(page, dialog)
- const main = page.locator("main")
- const initialClasses = (await main.getAttribute("class")) ?? ""
- const initiallyClosed = initialClasses.includes("xl:border-l")
+ const button = page.getByRole("button", { name: /toggle sidebar/i }).first()
+ const initiallyClosed = (await button.getAttribute("aria-expanded")) !== "true"
await page.keyboard.press(`${modKey}+Shift+H`)
- await page.waitForTimeout(100)
+ await expect(button).toHaveAttribute("aria-expanded", initiallyClosed ? "true" : "false")
- const afterToggleClasses = (await main.getAttribute("class")) ?? ""
- const afterToggleClosed = afterToggleClasses.includes("xl:border-l")
+ const afterToggleClosed = (await button.getAttribute("aria-expanded")) !== "true"
expect(afterToggleClosed).toBe(!initiallyClosed)
await page.keyboard.press(`${modKey}+Shift+H`)
- await page.waitForTimeout(100)
+ await expect(button).toHaveAttribute("aria-expanded", initiallyClosed ? "false" : "true")
- const finalClasses = (await main.getAttribute("class")) ?? ""
- const finalClosed = finalClasses.includes("xl:border-l")
+ const finalClosed = (await button.getAttribute("aria-expanded")) !== "true"
expect(finalClosed).toBe(initiallyClosed)
})
diff --git a/packages/app/e2e/sidebar/sidebar-popover-actions.spec.ts b/packages/app/e2e/sidebar/sidebar-popover-actions.spec.ts
index e37f94f3a..09701f3f9 100644
--- a/packages/app/e2e/sidebar/sidebar-popover-actions.spec.ts
+++ b/packages/app/e2e/sidebar/sidebar-popover-actions.spec.ts
@@ -1,6 +1,6 @@
import { test, expect } from "../fixtures"
import { closeSidebar, hoverSessionItem } from "../actions"
-import { projectSwitchSelector, sessionItemSelector } from "../selectors"
+import { projectSwitchSelector } from "../selectors"
test("collapsed sidebar popover stays open when archiving a session", async ({ page, slug, sdk, gotoSession }) => {
const stamp = Date.now()
@@ -15,12 +15,15 @@ test("collapsed sidebar popover stays open when archiving a session", async ({ p
await gotoSession(one.id)
await closeSidebar(page)
+ const oneItem = page.locator(`[data-session-id="${one.id}"]`).last()
+ const twoItem = page.locator(`[data-session-id="${two.id}"]`).last()
+
const project = page.locator(projectSwitchSelector(slug)).first()
await expect(project).toBeVisible()
await project.hover()
- await expect(page.locator(sessionItemSelector(one.id)).first()).toBeVisible()
- await expect(page.locator(sessionItemSelector(two.id)).first()).toBeVisible()
+ await expect(oneItem).toBeVisible()
+ await expect(twoItem).toBeVisible()
const item = await hoverSessionItem(page, one.id)
await item
@@ -28,7 +31,7 @@ test("collapsed sidebar popover stays open when archiving a session", async ({ p
.first()
.click()
- await expect(page.locator(sessionItemSelector(two.id)).first()).toBeVisible()
+ await expect(twoItem).toBeVisible()
} finally {
await sdk.session.delete({ sessionID: one.id }).catch(() => undefined)
await sdk.session.delete({ sessionID: two.id }).catch(() => undefined)
diff --git a/packages/app/e2e/sidebar/sidebar-session-links.spec.ts b/packages/app/e2e/sidebar/sidebar-session-links.spec.ts
index cda2278a9..052b7cb84 100644
--- a/packages/app/e2e/sidebar/sidebar-session-links.spec.ts
+++ b/packages/app/e2e/sidebar/sidebar-session-links.spec.ts
@@ -18,7 +18,6 @@ test("sidebar session links navigate to the selected session", async ({ page, sl
const target = page.locator(`[data-session-id="${two.id}"] a`).first()
await expect(target).toBeVisible()
- await target.scrollIntoViewIfNeeded()
await target.click()
await expect(page).toHaveURL(new RegExp(`/${slug}/session/${two.id}(?:\\?|#|$)`))
diff --git a/packages/app/e2e/sidebar/sidebar.spec.ts b/packages/app/e2e/sidebar/sidebar.spec.ts
index 5c78c2220..c6bf3fa9a 100644
--- a/packages/app/e2e/sidebar/sidebar.spec.ts
+++ b/packages/app/e2e/sidebar/sidebar.spec.ts
@@ -5,12 +5,14 @@ test("sidebar can be collapsed and expanded", async ({ page, gotoSession }) => {
await gotoSession()
await openSidebar(page)
+ const button = page.getByRole("button", { name: /toggle sidebar/i }).first()
+ await expect(button).toHaveAttribute("aria-expanded", "true")
await toggleSidebar(page)
- await expect(page.locator("main")).toHaveClass(/xl:border-l/)
+ await expect(button).toHaveAttribute("aria-expanded", "false")
await toggleSidebar(page)
- await expect(page.locator("main")).not.toHaveClass(/xl:border-l/)
+ await expect(button).toHaveAttribute("aria-expanded", "true")
})
test("sidebar collapsed state persists across navigation and reload", async ({ page, sdk, gotoSession }) => {
@@ -19,14 +21,15 @@ test("sidebar collapsed state persists across navigation and reload", async ({ p
await gotoSession(session1.id)
await openSidebar(page)
+ const button = page.getByRole("button", { name: /toggle sidebar/i }).first()
await toggleSidebar(page)
- await expect(page.locator("main")).toHaveClass(/xl:border-l/)
+ await expect(button).toHaveAttribute("aria-expanded", "false")
await gotoSession(session2.id)
- await expect(page.locator("main")).toHaveClass(/xl:border-l/)
+ await expect(button).toHaveAttribute("aria-expanded", "false")
await page.reload()
- await expect(page.locator("main")).toHaveClass(/xl:border-l/)
+ await expect(button).toHaveAttribute("aria-expanded", "false")
const opened = await page.evaluate(
() => JSON.parse(localStorage.getItem("opencode.global.dat:layout") ?? "{}").sidebar?.opened,
diff --git a/packages/app/src/pages/layout.tsx b/packages/app/src/pages/layout.tsx
index cf2c3b6c4..c9f6ae26f 100644
--- a/packages/app/src/pages/layout.tsx
+++ b/packages/app/src/pages/layout.tsx
@@ -155,6 +155,8 @@ export default function Layout(props: ParentProps) {
const isBusy = (directory: string) => !!state.busyWorkspaces[workspaceKey(directory)]
const navLeave = { current: undefined as number | undefined }
const [sortNow, setSortNow] = createSignal(Date.now())
+ const [sizing, setSizing] = createSignal(false)
+ let sizet: number | undefined
let sortNowInterval: ReturnType<typeof setInterval> | undefined
const sortNowTimeout = setTimeout(
() => {
@@ -167,7 +169,7 @@ export default function Layout(props: ParentProps) {
const aim = createAim({
enabled: () => !layout.sidebar.opened(),
active: () => state.hoverProject,
- el: () => state.nav,
+ el: () => state.nav?.querySelector<HTMLElement>("[data-component='sidebar-rail']") ?? state.nav,
onActivate: (directory) => {
globalSync.child(directory)
setState("hoverProject", directory)
@@ -179,9 +181,23 @@ export default function Layout(props: ParentProps) {
if (navLeave.current !== undefined) clearTimeout(navLeave.current)
clearTimeout(sortNowTimeout)
if (sortNowInterval) clearInterval(sortNowInterval)
+ if (sizet !== undefined) clearTimeout(sizet)
+ if (peekt !== undefined) clearTimeout(peekt)
aim.reset()
})
+ onMount(() => {
+ const stop = () => setSizing(false)
+ window.addEventListener("pointerup", stop)
+ window.addEventListener("pointercancel", stop)
+ window.addEventListener("blur", stop)
+ onCleanup(() => {
+ window.removeEventListener("pointerup", stop)
+ window.removeEventListener("pointercancel", stop)
+ window.removeEventListener("blur", stop)
+ })
+ })
+
const sidebarHovering = createMemo(() => !layout.sidebar.opened() && state.hoverProject !== undefined)
const sidebarExpanded = createMemo(() => layout.sidebar.opened() || sidebarHovering())
const setHoverProject = (value: string | undefined) => {
@@ -192,6 +208,27 @@ export default function Layout(props: ParentProps) {
const clearHoverProjectSoon = () => queueMicrotask(() => setHoverProject(undefined))
const setHoverSession = (id: string | undefined) => setState("hoverSession", id)
+ const disarm = () => {
+ if (navLeave.current === undefined) return
+ clearTimeout(navLeave.current)
+ navLeave.current = undefined
+ }
+
+ const arm = () => {
+ if (layout.sidebar.opened()) return
+ if (state.hoverProject === undefined) return
+ disarm()
+ navLeave.current = window.setTimeout(() => {
+ navLeave.current = undefined
+ setHoverProject(undefined)
+ setState("hoverSession", undefined)
+ }, 300)
+ }
+
+ const [peek, setPeek] = createSignal<LocalProject | undefined>(undefined)
+ const [peeked, setPeeked] = createSignal(false)
+ let peekt: number | undefined
+
const hoverProjectData = createMemo(() => {
const id = state.hoverProject
if (!id) return
@@ -199,6 +236,27 @@ export default function Layout(props: ParentProps) {
})
createEffect(() => {
+ const p = hoverProjectData()
+ if (p) {
+ if (peekt !== undefined) {
+ clearTimeout(peekt)
+ peekt = undefined
+ }
+ setPeek(p)
+ setPeeked(true)
+ return
+ }
+
+ setPeeked(false)
+ if (peek() === undefined) return
+ if (peekt !== undefined) clearTimeout(peekt)
+ peekt = window.setTimeout(() => {
+ peekt = undefined
+ setPeek(undefined)
+ }, 180)
+ })
+
+ createEffect(() => {
if (!layout.sidebar.opened()) return
setHoverProject(undefined)
})
@@ -1123,6 +1181,12 @@ export default function Layout(props: ParentProps) {
}
const openSession = async (target: { directory: string; id: string }) => {
if (!canOpen(target.directory)) return false
+ const [data] = globalSync.child(target.directory, { bootstrap: false })
+ if (data.session.some((item) => item.id === target.id)) {
+ setStore("lastProjectSession", root, { directory: target.directory, id: target.id, at: Date.now() })
+ navigateWithSidebarReset(`/${base64Encode(target.directory)}/session/${target.id}`)
+ return true
+ }
const resolved = await globalSDK.client.session
.get({ sessionID: target.id })
.then((x) => x.data)
@@ -1813,7 +1877,8 @@ export default function Layout(props: ParentProps) {
setHoverSession,
}
- const SidebarPanel = (panelProps: { project: LocalProject | undefined; mobile?: boolean }) => {
+ const SidebarPanel = (panelProps: { project: LocalProject | undefined; mobile?: boolean; merged?: boolean }) => {
+ const merged = createMemo(() => panelProps.mobile || (panelProps.merged ?? layout.sidebar.opened()))
const projectName = createMemo(() => {
const project = panelProps.project
if (!project) return ""
@@ -1839,10 +1904,17 @@ export default function Layout(props: ParentProps) {
return (
<div
classList={{
- "flex flex-col min-h-0 bg-background-stronger border border-b-0 border-border-weak-base rounded-tl-[12px]": true,
+ "flex flex-col min-h-0 min-w-0 rounded-tl-[12px] px-2": true,
+ "border border-b-0 border-border-weak-base": !merged(),
+ "border-l border-t border-border-weaker-base": merged(),
+ "bg-background-base": merged(),
+ "bg-background-stronger": !merged(),
"flex-1 min-w-0": panelProps.mobile,
+ "max-w-full overflow-hidden": panelProps.mobile,
+ }}
+ style={{
+ width: panelProps.mobile ? undefined : `${Math.max(Math.max(layout.sidebar.width(), 244) - 64, 0)}px`,
}}
- style={{ width: panelProps.mobile ? undefined : `${Math.max(layout.sidebar.width() - 64, 0)}px` }}
>
<Show when={panelProps.project}>
{(p) => (
@@ -2041,33 +2113,27 @@ export default function Layout(props: ParentProps) {
return (
<div class="relative bg-background-base flex-1 min-h-0 flex flex-col select-none [&_input]:select-text [&_textarea]:select-text [&_[contenteditable]]:select-text">
<Titlebar />
- <div class="flex-1 min-h-0 flex">
+ <div class="flex-1 min-h-0 relative overflow-x-hidden">
<nav
aria-label={language.t("sidebar.nav.projectsAndSessions")}
data-component="sidebar-nav-desktop"
classList={{
"hidden xl:block": true,
- "relative shrink-0": true,
+ "absolute inset-y-0 left-0": true,
+ "z-10": true,
}}
- style={{ width: layout.sidebar.opened() ? `${Math.max(layout.sidebar.width(), 244)}px` : "64px" }}
+ style={{ width: `${Math.max(layout.sidebar.width(), 244)}px` }}
ref={(el) => {
setState("nav", el)
}}
onMouseEnter={() => {
- if (navLeave.current === undefined) return
- clearTimeout(navLeave.current)
- navLeave.current = undefined
+ disarm()
}}
onMouseLeave={() => {
aim.reset()
if (!sidebarHovering()) return
- if (navLeave.current !== undefined) clearTimeout(navLeave.current)
- navLeave.current = window.setTimeout(() => {
- navLeave.current = undefined
- setHoverProject(undefined)
- setState("hoverSession", undefined)
- }, 300)
+ arm()
}}
>
<div class="@container w-full h-full contain-strict">
@@ -2094,28 +2160,36 @@ export default function Layout(props: ParentProps) {
onOpenHelp={() => platform.openLink("https://opencode.ai/desktop-feedback")}
renderPanel={() => (
<Show when={currentProject()} keyed>
- {(project) => <SidebarPanel project={project} />}
+ {(project) => <SidebarPanel project={project} merged />}
</Show>
)}
/>
</div>
- <Show when={!layout.sidebar.opened() ? hoverProjectData()?.worktree : undefined} keyed>
- <div class="absolute inset-y-0 left-16 z-50 flex" onMouseEnter={aim.reset}>
- <SidebarPanel project={hoverProjectData()} />
- </div>
- </Show>
<Show when={layout.sidebar.opened()}>
- <ResizeHandle
- direction="horizontal"
- size={layout.sidebar.width()}
- min={244}
- max={typeof window === "undefined" ? 1000 : window.innerWidth * 0.3 + 64}
- collapseThreshold={244}
- onResize={layout.sidebar.resize}
- onCollapse={layout.sidebar.close}
- />
+ <div onPointerDown={() => setSizing(true)}>
+ <ResizeHandle
+ direction="horizontal"
+ size={layout.sidebar.width()}
+ min={244}
+ max={typeof window === "undefined" ? 1000 : window.innerWidth * 0.3 + 64}
+ collapseThreshold={244}
+ onResize={(w) => {
+ setSizing(true)
+ if (sizet !== undefined) clearTimeout(sizet)
+ sizet = window.setTimeout(() => setSizing(false), 120)
+ layout.sidebar.resize(w)
+ }}
+ onCollapse={layout.sidebar.close}
+ />
+ </div>
</Show>
</nav>
+
+ <div
+ class="hidden xl:block pointer-events-none absolute top-0 right-0 z-0 border-t border-border-weaker-base"
+ style={{ left: "calc(4rem + 12px)" }}
+ />
+
<div class="xl:hidden">
<div
classList={{
@@ -2131,7 +2205,7 @@ export default function Layout(props: ParentProps) {
aria-label={language.t("sidebar.nav.projectsAndSessions")}
data-component="sidebar-nav-mobile"
classList={{
- "@container fixed top-10 bottom-0 left-0 z-50 w-72 bg-background-base transition-transform duration-200 ease-out": true,
+ "@container fixed top-10 bottom-0 left-0 z-50 w-full max-w-[400px] overflow-hidden border-r border-border-weaker-base bg-background-base transition-transform duration-200 ease-out": true,
"translate-x-0": layout.mobileSidebar.opened(),
"-translate-x-full": !layout.mobileSidebar.opened(),
}}
@@ -2164,16 +2238,66 @@ export default function Layout(props: ParentProps) {
</nav>
</div>
- <main
+ <div
classList={{
- "size-full overflow-x-hidden flex flex-col items-start contain-strict border-t border-border-weak-base": true,
- "xl:border-l xl:rounded-tl-[12px]": !layout.sidebar.opened(),
+ "absolute inset-0": true,
+ "xl:inset-y-0 xl:right-0 xl:left-[var(--main-left)]": true,
+ "z-20": true,
+ "transition-[left] duration-200 ease-[cubic-bezier(0.22,1,0.36,1)] will-change-[left] motion-reduce:transition-none":
+ !sizing(),
+ }}
+ style={{
+ "--main-left": layout.sidebar.opened() ? `${Math.max(layout.sidebar.width(), 244)}px` : "4rem",
}}
>
- <Show when={!autoselecting()} fallback={<div class="size-full" />}>
- {props.children}
+ <main
+ classList={{
+ "size-full overflow-x-hidden flex flex-col items-start contain-strict border-t border-border-weak-base xl:border-l xl:rounded-tl-[12px]": true,
+ }}
+ >
+ <Show when={!autoselecting()} fallback={<div class="size-full" />}>
+ {props.children}
+ </Show>
+ </main>
+ </div>
+
+ <div
+ classList={{
+ "hidden xl:flex absolute inset-y-0 left-16 z-30": true,
+ "opacity-100 translate-x-0 pointer-events-auto": peeked() && !layout.sidebar.opened(),
+ "opacity-0 -translate-x-2 pointer-events-none": !peeked() || layout.sidebar.opened(),
+ "transition-[opacity,transform] motion-reduce:transition-none": true,
+ "duration-180 ease-out": peeked() && !layout.sidebar.opened(),
+ "duration-120 ease-in": !peeked() || layout.sidebar.opened(),
+ }}
+ onMouseMove={disarm}
+ onMouseEnter={() => {
+ disarm()
+ aim.reset()
+ }}
+ onPointerDown={disarm}
+ onMouseLeave={() => {
+ arm()
+ }}
+ >
+ <Show when={peek()} keyed>
+ {(project) => <SidebarPanel project={project} merged={false} />}
</Show>
- </main>
+ </div>
+
+ <div
+ classList={{
+ "hidden xl:block pointer-events-none absolute inset-y-0 right-0 z-25 overflow-hidden": true,
+ "opacity-100 translate-x-0": peeked() && !layout.sidebar.opened(),
+ "opacity-0 -translate-x-2": !peeked() || layout.sidebar.opened(),
+ "transition-[opacity,transform] motion-reduce:transition-none": true,
+ "duration-180 ease-out": peeked() && !layout.sidebar.opened(),
+ "duration-120 ease-in": !peeked() || layout.sidebar.opened(),
+ }}
+ style={{ left: `calc(4rem + ${Math.max(Math.max(layout.sidebar.width(), 244) - 64, 0)}px)` }}
+ >
+ <div class="h-full w-px" style={{ "box-shadow": "var(--shadow-sidebar-overlay)" }} />
+ </div>
</div>
<Toast.Region />
</div>
diff --git a/packages/app/src/pages/layout/sidebar-shell.tsx b/packages/app/src/pages/layout/sidebar-shell.tsx
index d813ef3e1..d3070e374 100644
--- a/packages/app/src/pages/layout/sidebar-shell.tsx
+++ b/packages/app/src/pages/layout/sidebar-shell.tsx
@@ -1,4 +1,4 @@
-import { createMemo, For, Show, type Accessor, type JSX } from "solid-js"
+import { createEffect, createMemo, For, Show, type Accessor, type JSX } from "solid-js"
import {
DragDropProvider,
DragDropSensors,
@@ -35,10 +35,22 @@ export const SidebarContent = (props: {
}): JSX.Element => {
const expanded = createMemo(() => sidebarExpanded(props.mobile, props.opened()))
const placement = () => (props.mobile ? "bottom" : "right")
+ let panel: HTMLDivElement | undefined
+
+ createEffect(() => {
+ const el = panel
+ if (!el) return
+ if (expanded()) {
+ el.removeAttribute("inert")
+ return
+ }
+ el.setAttribute("inert", "")
+ })
return (
- <div class="flex h-full w-full overflow-hidden">
+ <div class="flex h-full w-full min-w-0 overflow-hidden">
<div
+ data-component="sidebar-rail"
class="w-16 shrink-0 bg-background-base flex flex-col items-center overflow-hidden"
onMouseMove={props.aimMove}
>
@@ -100,7 +112,15 @@ export const SidebarContent = (props: {
</div>
</div>
- <Show when={expanded()}>{props.renderPanel()}</Show>
+ <div
+ ref={(el) => {
+ panel = el
+ }}
+ classList={{ "flex h-full min-h-0 min-w-0 overflow-hidden": true, "pointer-events-none": !expanded() }}
+ aria-hidden={!expanded()}
+ >
+ {props.renderPanel()}
+ </div>
</div>
)
}
diff --git a/packages/app/src/pages/layout/sidebar-workspace.tsx b/packages/app/src/pages/layout/sidebar-workspace.tsx
index 43d99cf89..f2fd3af2a 100644
--- a/packages/app/src/pages/layout/sidebar-workspace.tsx
+++ b/packages/app/src/pages/layout/sidebar-workspace.tsx
@@ -249,7 +249,7 @@ const WorkspaceSessionList = (props: {
loadMore: () => Promise<void>
language: ReturnType<typeof useLanguage>
}): JSX.Element => (
- <nav class="flex flex-col gap-1 px-2">
+ <nav class="flex flex-col gap-1 px-3">
<Show when={props.showNew()}>
<NewSessionItem
slug={props.slug()}
@@ -490,7 +490,7 @@ export const LocalWorkspace = (props: {
ref={(el) => props.ctx.setScrollContainerRef(el, props.mobile)}
class="size-full flex flex-col py-2 overflow-y-auto no-scrollbar [overflow-anchor:none]"
>
- <nav class="flex flex-col gap-1 px-2">
+ <nav class="flex flex-col gap-1 px-3">
<Show when={loading()}>
<SessionSkeleton />
</Show>
diff --git a/packages/app/src/pages/session/session-side-panel.tsx b/packages/app/src/pages/session/session-side-panel.tsx
index 66d4382c0..927461a2a 100644
--- a/packages/app/src/pages/session/session-side-panel.tsx
+++ b/packages/app/src/pages/session/session-side-panel.tsx
@@ -208,7 +208,7 @@ export function SessionSidePanel(props: {
<aside
id="review-panel"
aria-label={language.t("session.panel.reviewAndFiles")}
- class="relative min-w-0 h-full border-l border-border-weak-base flex"
+ class="relative min-w-0 h-full border-l border-border-weaker-base flex"
classList={{
"flex-1": reviewOpen(),
"shrink-0": !reviewOpen(),
@@ -346,7 +346,7 @@ export function SessionSidePanel(props: {
<div id="file-tree-panel" class="relative shrink-0 h-full" style={{ width: `${layout.fileTree.width()}px` }}>
<div
class="h-full flex flex-col overflow-hidden group/filetree"
- classList={{ "border-l border-border-weak-base": reviewOpen() }}
+ classList={{ "border-l border-border-weaker-base": reviewOpen() }}
>
<Tabs
variant="pill"
diff --git a/packages/app/src/pages/session/terminal-panel.tsx b/packages/app/src/pages/session/terminal-panel.tsx
index cc4c17ee2..69c8aefcc 100644
--- a/packages/app/src/pages/session/terminal-panel.tsx
+++ b/packages/app/src/pages/session/terminal-panel.tsx
@@ -154,7 +154,7 @@ export function TerminalPanel() {
when={terminal.ready()}
fallback={
<div class="flex flex-col h-full pointer-events-none">
- <div class="h-10 flex items-center gap-2 px-2 border-b border-border-weak-base bg-background-stronger overflow-hidden">
+ <div class="h-10 flex items-center gap-2 px-2 border-b border-border-weaker-base bg-background-stronger overflow-hidden">
<For each={handoff()}>
{(title) => (
<div class="px-2 py-1 rounded-md bg-surface-base text-14-regular text-text-weak truncate max-w-40">
@@ -187,7 +187,7 @@ export function TerminalPanel() {
onChange={(id) => terminal.open(id)}
class="!h-auto !flex-none"
>
- <Tabs.List class="h-10">
+ <Tabs.List class="h-10 border-b border-border-weaker-base">
<SortableProvider ids={ids()}>
<For each={ids()}>
{(id) => (