diff options
Diffstat (limited to 'internal/llm/tools')
| -rw-r--r-- | internal/llm/tools/bash.go | 47 | ||||
| -rw-r--r-- | internal/llm/tools/bash_test.go | 37 |
2 files changed, 67 insertions, 17 deletions
diff --git a/internal/llm/tools/bash.go b/internal/llm/tools/bash.go index 1481bdd88..a78c03215 100644 --- a/internal/llm/tools/bash.go +++ b/internal/llm/tools/bash.go @@ -38,8 +38,38 @@ var BannedCommands = []string{ } var SafeReadOnlyCommands = []string{ + // Basic shell commands "ls", "echo", "pwd", "date", "cal", "uptime", "whoami", "id", "groups", "env", "printenv", "set", "unset", "which", "type", "whereis", - "whatis", //... + "whatis", "uname", "hostname", "df", "du", "free", "top", "ps", "kill", "killall", "nice", "nohup", "time", "timeout", + + // Git read-only commands + "git status", "git log", "git diff", "git show", "git branch", "git tag", "git remote", "git ls-files", "git ls-remote", + "git rev-parse", "git config --get", "git config --list", "git describe", "git blame", "git grep", "git shortlog", + + // Go commands + "go version", "go list", "go env", "go doc", "go vet", "go fmt", "go mod", "go test", "go build", "go run", "go install", "go clean", + + // Node.js commands + "node", "npm", "npx", "yarn", "pnpm", + + // Python commands + "python", "python3", "pip", "pip3", "pytest", "pylint", "mypy", "black", "isort", "flake8", "ruff", + + // Docker commands + "docker ps", "docker images", "docker volume", "docker network", "docker info", "docker version", + "docker-compose ps", "docker-compose config", + + // Kubernetes commands + "kubectl get", "kubectl describe", "kubectl logs", "kubectl version", "kubectl config", + + // Rust commands + "cargo", "rustc", "rustup", + + // Java commands + "java", "javac", "mvn", "gradle", + + // Misc development tools + "make", "cmake", "bazel", "terraform plan", "terraform validate", "ansible", } func (b *bashTool) Info() ToolInfo { @@ -77,17 +107,26 @@ func (b *bashTool) Run(ctx context.Context, call ToolCall) (ToolResponse, error) return NewTextErrorResponse("missing command"), nil } + // Check for banned commands (first word only) baseCmd := strings.Fields(params.Command)[0] for _, banned := range BannedCommands { if strings.EqualFold(baseCmd, banned) { return NewTextErrorResponse(fmt.Sprintf("command '%s' is not allowed", baseCmd)), nil } } + + // Check for safe commands (can be multi-word) isSafeReadOnly := false + cmdLower := strings.ToLower(params.Command) + for _, safe := range SafeReadOnlyCommands { - if strings.EqualFold(baseCmd, safe) { - isSafeReadOnly = true - break + // Check if command starts with the safe command pattern + if strings.HasPrefix(cmdLower, strings.ToLower(safe)) { + // Make sure it's either an exact match or followed by a space or flag + if len(cmdLower) == len(safe) || cmdLower[len(safe)] == ' ' || cmdLower[len(safe)] == '-' { + isSafeReadOnly = true + break + } } } if !isSafeReadOnly { diff --git a/internal/llm/tools/bash_test.go b/internal/llm/tools/bash_test.go index b7b5c5ee5..9eadc227c 100644 --- a/internal/llm/tools/bash_test.go +++ b/internal/llm/tools/bash_test.go @@ -119,27 +119,38 @@ func TestBashTool_Run(t *testing.T) { } }) - t.Run("handles safe read-only commands without permission check", func(t *testing.T) { + t.Run("handles multi-word safe commands without permission check", func(t *testing.T) { permission.Default = newMockPermissionService(false) tool := NewBashTool() - // Test with a safe read-only command - params := BashParams{ - Command: "echo 'test'", + // Test with multi-word safe commands + multiWordCommands := []string{ + "git status", + "git log -n 5", + "docker ps", + "go test ./...", + "kubectl get pods", } - paramsJSON, err := json.Marshal(params) - require.NoError(t, err) + for _, cmd := range multiWordCommands { + params := BashParams{ + Command: cmd, + } - call := ToolCall{ - Name: BashToolName, - Input: string(paramsJSON), - } + paramsJSON, err := json.Marshal(params) + require.NoError(t, err) - response, err := tool.Run(context.Background(), call) - require.NoError(t, err) - assert.Equal(t, "test\n", response.Content) + call := ToolCall{ + Name: BashToolName, + Input: string(paramsJSON), + } + + response, err := tool.Run(context.Background(), call) + require.NoError(t, err) + assert.NotContains(t, response.Content, "permission denied", + "Command %s should be allowed without permission", cmd) + } }) t.Run("handles permission denied", func(t *testing.T) { |
