summaryrefslogtreecommitdiffhomepage
path: root/packages/app
diff options
context:
space:
mode:
Diffstat (limited to 'packages/app')
-rw-r--r--packages/app/src/context/global-sync/bootstrap.ts2
-rw-r--r--packages/app/src/context/global-sync/event-reducer.test.ts10
-rw-r--r--packages/app/src/context/global-sync/event-reducer.ts4
-rw-r--r--packages/app/src/i18n/en.ts2
-rw-r--r--packages/app/src/pages/session.tsx272
-rw-r--r--packages/app/src/pages/session/session-side-panel.tsx58
-rw-r--r--packages/app/src/pages/session/use-session-commands.tsx6
7 files changed, 88 insertions, 266 deletions
diff --git a/packages/app/src/context/global-sync/bootstrap.ts b/packages/app/src/context/global-sync/bootstrap.ts
index 4790011a5..6eec688b7 100644
--- a/packages/app/src/context/global-sync/bootstrap.ts
+++ b/packages/app/src/context/global-sync/bootstrap.ts
@@ -190,7 +190,7 @@ export async function bootstrapDirectory(input: {
input.sdk.vcs.get().then((x) => {
const next = x.data ?? input.store.vcs
input.setStore("vcs", next)
- if (next) input.vcsCache.setStore("value", next)
+ if (next?.branch) input.vcsCache.setStore("value", next)
}),
),
() => retry(() => input.sdk.command.list().then((x) => input.setStore("command", x.data ?? []))),
diff --git a/packages/app/src/context/global-sync/event-reducer.test.ts b/packages/app/src/context/global-sync/event-reducer.test.ts
index 892129788..cf2da135c 100644
--- a/packages/app/src/context/global-sync/event-reducer.test.ts
+++ b/packages/app/src/context/global-sync/event-reducer.test.ts
@@ -494,10 +494,8 @@ describe("applyDirectoryEvent", () => {
})
test("updates vcs branch in store and cache", () => {
- const [store, setStore] = createStore(baseState({ vcs: { branch: "main", default_branch: "main" } }))
- const [cacheStore, setCacheStore] = createStore({
- value: { branch: "main", default_branch: "main" } as State["vcs"],
- })
+ const [store, setStore] = createStore(baseState())
+ const [cacheStore, setCacheStore] = createStore({ value: undefined as State["vcs"] })
applyDirectoryEvent({
event: { type: "vcs.branch.updated", properties: { branch: "feature/test" } },
@@ -513,8 +511,8 @@ describe("applyDirectoryEvent", () => {
},
})
- expect(store.vcs).toEqual({ branch: "feature/test", default_branch: "main" })
- expect(cacheStore.value).toEqual({ branch: "feature/test", default_branch: "main" })
+ expect(store.vcs).toEqual({ branch: "feature/test" })
+ expect(cacheStore.value).toEqual({ branch: "feature/test" })
})
test("routes disposal and lsp events to side-effect handlers", () => {
diff --git a/packages/app/src/context/global-sync/event-reducer.ts b/packages/app/src/context/global-sync/event-reducer.ts
index 4af636553..5d8b7c4e3 100644
--- a/packages/app/src/context/global-sync/event-reducer.ts
+++ b/packages/app/src/context/global-sync/event-reducer.ts
@@ -271,9 +271,9 @@ export function applyDirectoryEvent(input: {
break
}
case "vcs.branch.updated": {
- const props = event.properties as { branch?: string }
+ const props = event.properties as { branch: string }
if (input.store.vcs?.branch === props.branch) break
- const next = { ...input.store.vcs, branch: props.branch }
+ const next = { branch: props.branch }
input.setStore("vcs", next)
if (input.vcsCache) input.vcsCache.setStore("value", next)
break
diff --git a/packages/app/src/i18n/en.ts b/packages/app/src/i18n/en.ts
index bdf97ec0f..dde092511 100644
--- a/packages/app/src/i18n/en.ts
+++ b/packages/app/src/i18n/en.ts
@@ -535,8 +535,6 @@ export const dict = {
"session.review.noVcs.createGit.action": "Create Git repository",
"session.review.noSnapshot": "Snapshot tracking is disabled in config, so session changes are unavailable",
"session.review.noChanges": "No changes",
- "session.review.noUncommittedChanges": "No uncommitted changes yet",
- "session.review.noBranchChanges": "No branch changes yet",
"session.files.selectToOpen": "Select a file to open",
"session.files.all": "All files",
diff --git a/packages/app/src/pages/session.tsx b/packages/app/src/pages/session.tsx
index 8c32a7237..2d3e31355 100644
--- a/packages/app/src/pages/session.tsx
+++ b/packages/app/src/pages/session.tsx
@@ -1,4 +1,4 @@
-import type { FileDiff, Project, UserMessage } from "@opencode-ai/sdk/v2"
+import type { Project, UserMessage } from "@opencode-ai/sdk/v2"
import { useDialog } from "@opencode-ai/ui/context/dialog"
import { useMutation } from "@tanstack/solid-query"
import {
@@ -64,9 +64,6 @@ import { formatServerError } from "@/utils/server-errors"
const emptyUserMessages: UserMessage[] = []
const emptyFollowups: (FollowupDraft & { id: string })[] = []
-type ChangeMode = "git" | "branch" | "session" | "turn"
-type VcsMode = "git" | "branch"
-
type SessionHistoryWindowInput = {
sessionID: () => string | undefined
messagesReady: () => boolean
@@ -427,16 +424,15 @@ export default function Page() {
const info = createMemo(() => (params.id ? sync.session.get(params.id) : undefined))
const diffs = createMemo(() => (params.id ? (sync.data.session_diff[params.id] ?? []) : []))
- const sessionCount = createMemo(() => Math.max(info()?.summary?.files ?? 0, diffs().length))
- const hasSessionReview = createMemo(() => sessionCount() > 0)
- const canReview = createMemo(() => !!params.id)
+ const reviewCount = createMemo(() => Math.max(info()?.summary?.files ?? 0, diffs().length))
+ const hasReview = createMemo(() => reviewCount() > 0)
const reviewTab = createMemo(() => isDesktop())
const tabState = createSessionTabs({
tabs,
pathFromTab: file.pathFromTab,
normalizeTab,
review: reviewTab,
- hasReview: canReview,
+ hasReview,
})
const contextOpen = tabState.contextOpen
const openedTabs = tabState.openedTabs
@@ -459,12 +455,6 @@ export default function Page() {
if (!id) return false
return sync.session.history.loading(id)
})
- const diffsReady = createMemo(() => {
- const id = params.id
- if (!id) return true
- if (!hasSessionReview()) return true
- return sync.data.session_diff[id] !== undefined
- })
const userMessages = createMemo(
() => messages().filter((m) => m.role === "user") as UserMessage[],
@@ -518,22 +508,11 @@ export default function Page() {
const [store, setStore] = createStore({
messageId: undefined as string | undefined,
mobileTab: "session" as "session" | "changes",
- changes: "git" as ChangeMode,
+ changes: "session" as "session" | "turn",
newSessionWorktree: "main",
deferRender: false,
})
- const [vcs, setVcs] = createStore({
- diff: {
- git: [] as FileDiff[],
- branch: [] as FileDiff[],
- },
- ready: {
- git: false,
- branch: false,
- },
- })
-
const [followup, setFollowup] = createStore({
items: {} as Record<string, (FollowupDraft & { id: string })[] | undefined>,
failed: {} as Record<string, string | undefined>,
@@ -560,68 +539,6 @@ export default function Page() {
let refreshTimer: number | undefined
let diffFrame: number | undefined
let diffTimer: number | undefined
- const vcsTask = new Map<VcsMode, Promise<void>>()
- const vcsRun = new Map<VcsMode, number>()
-
- const bumpVcs = (mode: VcsMode) => {
- const next = (vcsRun.get(mode) ?? 0) + 1
- vcsRun.set(mode, next)
- return next
- }
-
- const resetVcs = (mode?: VcsMode) => {
- const list = mode ? [mode] : (["git", "branch"] as const)
- list.forEach((item) => {
- bumpVcs(item)
- vcsTask.delete(item)
- setVcs("diff", item, [])
- setVcs("ready", item, false)
- })
- }
-
- const loadVcs = (mode: VcsMode, force = false) => {
- if (sync.project?.vcs !== "git") return Promise.resolve()
- if (!force && vcs.ready[mode]) return Promise.resolve()
-
- if (force) {
- if (vcsTask.has(mode)) bumpVcs(mode)
- vcsTask.delete(mode)
- setVcs("ready", mode, false)
- }
-
- const current = vcsTask.get(mode)
- if (current) return current
-
- const run = bumpVcs(mode)
-
- const task = sdk.client.vcs
- .diff({ mode })
- .then((result) => {
- if (vcsRun.get(mode) !== run) return
- setVcs("diff", mode, result.data ?? [])
- setVcs("ready", mode, true)
- })
- .catch((error) => {
- if (vcsRun.get(mode) !== run) return
- console.debug("[session-review] failed to load vcs diff", { mode, error })
- setVcs("diff", mode, [])
- setVcs("ready", mode, true)
- })
- .finally(() => {
- if (vcsTask.get(mode) === task) vcsTask.delete(mode)
- })
-
- vcsTask.set(mode, task)
- return task
- }
-
- const refreshVcs = () => {
- resetVcs()
- const mode = untrack(vcsMode)
- if (!mode) return
- if (!untrack(wantsReview)) return
- void loadVcs(mode, true)
- }
createComputed((prev) => {
const open = desktopReviewOpen()
@@ -637,42 +554,7 @@ export default function Page() {
}, desktopReviewOpen())
const turnDiffs = createMemo(() => lastUserMessage()?.summary?.diffs ?? [])
- const changesOptions = createMemo<ChangeMode[]>(() => {
- const list: ChangeMode[] = []
- if (sync.project?.vcs === "git") list.push("git")
- if (
- sync.project?.vcs === "git" &&
- sync.data.vcs?.branch &&
- sync.data.vcs?.default_branch &&
- sync.data.vcs.branch !== sync.data.vcs.default_branch
- ) {
- list.push("branch")
- }
- list.push("session", "turn")
- return list
- })
- const vcsMode = createMemo<VcsMode | undefined>(() => {
- if (store.changes === "git" || store.changes === "branch") return store.changes
- })
- const reviewDiffs = createMemo(() => {
- if (store.changes === "git") return vcs.diff.git
- if (store.changes === "branch") return vcs.diff.branch
- if (store.changes === "session") return diffs()
- return turnDiffs()
- })
- const reviewCount = createMemo(() => {
- if (store.changes === "git") return vcs.diff.git.length
- if (store.changes === "branch") return vcs.diff.branch.length
- if (store.changes === "session") return sessionCount()
- return turnDiffs().length
- })
- const hasReview = createMemo(() => reviewCount() > 0)
- const reviewReady = createMemo(() => {
- if (store.changes === "git") return vcs.ready.git
- if (store.changes === "branch") return vcs.ready.branch
- if (store.changes === "session") return !hasSessionReview() || diffsReady()
- return true
- })
+ const reviewDiffs = createMemo(() => (store.changes === "session" ? diffs() : turnDiffs()))
const newSessionWorktree = createMemo(() => {
if (store.newSessionWorktree === "create") return "create"
@@ -738,7 +620,13 @@ export default function Page() {
scrollToMessage(msgs[targetIndex], "auto")
}
- const sessionEmptyKey = createMemo(() => {
+ const diffsReady = createMemo(() => {
+ const id = params.id
+ if (!id) return true
+ if (!hasReview()) return true
+ return sync.data.session_diff[id] !== undefined
+ })
+ const reviewEmptyKey = createMemo(() => {
const project = sync.project
if (project && !project.vcs) return "session.review.noVcs"
if (sync.data.config.snapshot === false) return "session.review.noSnapshot"
@@ -860,7 +748,7 @@ export default function Page() {
sessionKey,
() => {
setStore("messageId", undefined)
- setStore("changes", "git")
+ setStore("changes", "session")
setUi("pendingMessage", undefined)
},
{ defer: true },
@@ -869,39 +757,6 @@ export default function Page() {
createEffect(
on(
- () => sdk.directory,
- () => {
- resetVcs()
- },
- { defer: true },
- ),
- )
-
- createEffect(
- on(
- () => [sync.data.vcs?.branch, sync.data.vcs?.default_branch] as const,
- (next, prev) => {
- if (prev === undefined || same(next, prev)) return
- refreshVcs()
- },
- { defer: true },
- ),
- )
-
- const stopVcs = sdk.event.listen((evt) => {
- if (evt.details.type !== "file.watcher.updated") return
- const props =
- typeof evt.details.properties === "object" && evt.details.properties
- ? (evt.details.properties as Record<string, unknown>)
- : undefined
- const file = typeof props?.file === "string" ? props.file : undefined
- if (!file || file.startsWith(".git/")) return
- refreshVcs()
- })
- onCleanup(stopVcs)
-
- createEffect(
- on(
() => params.dir,
(dir) => {
if (!dir) return
@@ -1022,40 +877,6 @@ export default function Page() {
}
const mobileChanges = createMemo(() => !isDesktop() && store.mobileTab === "changes")
- const wantsReview = createMemo(() =>
- isDesktop()
- ? desktopFileTreeOpen() || (desktopReviewOpen() && activeTab() === "review")
- : store.mobileTab === "changes",
- )
-
- createEffect(() => {
- const list = changesOptions()
- if (list.includes(store.changes)) return
- const next = list[0]
- if (!next) return
- setStore("changes", next)
- })
-
- createEffect(() => {
- const mode = vcsMode()
- if (!mode) return
- if (!wantsReview()) return
- void loadVcs(mode)
- })
-
- createEffect(
- on(
- () => sync.data.session_status[params.id ?? ""]?.type,
- (next, prev) => {
- const mode = vcsMode()
- if (!mode) return
- if (!wantsReview()) return
- if (next !== "idle" || prev === undefined || prev === "idle") return
- void loadVcs(mode, true)
- },
- { defer: true },
- ),
- )
const fileTreeTab = () => layout.fileTree.tab()
const setFileTreeTab = (value: "changes" | "all") => layout.fileTree.setTab(value)
@@ -1102,23 +923,21 @@ export default function Page() {
loadFile: file.load,
})
+ const changesOptions = ["session", "turn"] as const
+ const changesOptionsList = [...changesOptions]
+
const changesTitle = () => {
- if (!canReview()) {
+ if (!hasReview()) {
return null
}
- const label = (option: ChangeMode) => {
- if (option === "git") return language.t("ui.sessionReview.title.git")
- if (option === "branch") return language.t("ui.sessionReview.title.branch")
- if (option === "session") return language.t("ui.sessionReview.title")
- return language.t("ui.sessionReview.title.lastTurn")
- }
-
return (
<Select
- options={changesOptions()}
+ options={changesOptionsList}
current={store.changes}
- label={label}
+ label={(option) =>
+ option === "session" ? language.t("ui.sessionReview.title") : language.t("ui.sessionReview.title.lastTurn")
+ }
onSelect={(option) => option && setStore("changes", option)}
variant="ghost"
size="small"
@@ -1127,34 +946,20 @@ export default function Page() {
)
}
- const empty = (text: string) => (
+ const emptyTurn = () => (
<div class="h-full pb-64 -mt-4 flex flex-col items-center justify-center text-center gap-6">
- <div class="text-14-regular text-text-weak max-w-56">{text}</div>
+ <div class="text-14-regular text-text-weak max-w-56">{language.t("session.review.noChanges")}</div>
</div>
)
- const reviewEmptyText = createMemo(() => {
- if (store.changes === "git") return language.t("session.review.noUncommittedChanges")
- if (store.changes === "branch") return language.t("session.review.noBranchChanges")
- if (store.changes === "turn") return language.t("session.review.noChanges")
- return language.t(sessionEmptyKey())
- })
-
const reviewEmpty = (input: { loadingClass: string; emptyClass: string }) => {
- if (store.changes === "git" || store.changes === "branch") {
- if (!reviewReady()) return <div class={input.loadingClass}>{language.t("session.review.loadingChanges")}</div>
- return empty(reviewEmptyText())
- }
+ if (store.changes === "turn") return emptyTurn()
- if (store.changes === "turn") {
- return empty(reviewEmptyText())
- }
-
- if (hasSessionReview() && !diffsReady()) {
+ if (hasReview() && !diffsReady()) {
return <div class={input.loadingClass}>{language.t("session.review.loadingChanges")}</div>
}
- if (sessionEmptyKey() === "session.review.noVcs") {
+ if (reviewEmptyKey() === "session.review.noVcs") {
return (
<div class={input.emptyClass}>
<div class="flex flex-col gap-3">
@@ -1174,7 +979,7 @@ export default function Page() {
return (
<div class={input.emptyClass}>
- <div class="text-14-regular text-text-weak max-w-56">{reviewEmptyText()}</div>
+ <div class="text-14-regular text-text-weak max-w-56">{language.t(reviewEmptyKey())}</div>
</div>
)
}
@@ -1278,7 +1083,7 @@ export default function Page() {
const pending = tree.pendingDiff
if (!pending) return
if (!tree.reviewScroll) return
- if (!reviewReady()) return
+ if (!diffsReady()) return
const attempt = (count: number) => {
if (tree.pendingDiff !== pending) return
@@ -1319,7 +1124,10 @@ export default function Page() {
const id = params.id
if (!id) return
- if (!wantsReview()) return
+ const wants = isDesktop()
+ ? desktopFileTreeOpen() || (desktopReviewOpen() && activeTab() === "review")
+ : store.mobileTab === "changes"
+ if (!wants) return
if (sync.data.session_diff[id] !== undefined) return
if (sync.status === "loading") return
@@ -1328,7 +1136,13 @@ export default function Page() {
createEffect(
on(
- () => [sessionKey(), wantsReview()] as const,
+ () =>
+ [
+ sessionKey(),
+ isDesktop()
+ ? desktopFileTreeOpen() || (desktopReviewOpen() && activeTab() === "review")
+ : store.mobileTab === "changes",
+ ] as const,
([key, wants]) => {
if (diffFrame !== undefined) cancelAnimationFrame(diffFrame)
if (diffTimer !== undefined) window.clearTimeout(diffTimer)
@@ -2014,12 +1828,6 @@ export default function Page() {
</div>
<SessionSidePanel
- canReview={canReview}
- diffs={reviewDiffs}
- diffsReady={reviewReady}
- empty={reviewEmptyText}
- hasReview={hasReview}
- reviewCount={reviewCount}
reviewPanel={reviewPanel}
activeDiff={tree.activeDiff}
focusReviewDiff={focusReviewDiff}
diff --git a/packages/app/src/pages/session/session-side-panel.tsx b/packages/app/src/pages/session/session-side-panel.tsx
index 400e7a60e..58c650fcd 100644
--- a/packages/app/src/pages/session/session-side-panel.tsx
+++ b/packages/app/src/pages/session/session-side-panel.tsx
@@ -8,7 +8,6 @@ import { ResizeHandle } from "@opencode-ai/ui/resize-handle"
import { Mark } from "@opencode-ai/ui/logo"
import { DragDropProvider, DragDropSensors, DragOverlay, SortableProvider, closestCenter } from "@thisbeyond/solid-dnd"
import type { DragEvent } from "@thisbeyond/solid-dnd"
-import type { FileDiff } from "@opencode-ai/sdk/v2"
import { ConstrainDragYAxis, getDraggableId } from "@/utils/solid-dnd"
import { useDialog } from "@opencode-ai/ui/context/dialog"
@@ -20,6 +19,7 @@ import { useCommand } from "@/context/command"
import { useFile, type SelectedLineRange } from "@/context/file"
import { useLanguage } from "@/context/language"
import { useLayout } from "@/context/layout"
+import { useSync } from "@/context/sync"
import { createFileTabListSync } from "@/pages/session/file-tab-scroll"
import { FileTabContent } from "@/pages/session/file-tabs"
import { createOpenSessionFileTab, createSessionTabs, getTabReorderIndex, type Sizing } from "@/pages/session/helpers"
@@ -27,12 +27,6 @@ import { setSessionHandoff } from "@/pages/session/handoff"
import { useSessionLayout } from "@/pages/session/session-layout"
export function SessionSidePanel(props: {
- canReview: () => boolean
- diffs: () => FileDiff[]
- diffsReady: () => boolean
- empty: () => string
- hasReview: () => boolean
- reviewCount: () => number
reviewPanel: () => JSX.Element
activeDiff?: string
focusReviewDiff: (path: string) => void
@@ -40,11 +34,12 @@ export function SessionSidePanel(props: {
size: Sizing
}) {
const layout = useLayout()
+ const sync = useSync()
const file = useFile()
const language = useLanguage()
const command = useCommand()
const dialog = useDialog()
- const { sessionKey, tabs, view } = useSessionLayout()
+ const { params, sessionKey, tabs, view } = useSessionLayout()
const isDesktop = createMediaQuery("(min-width: 768px)")
@@ -59,7 +54,24 @@ export function SessionSidePanel(props: {
})
const treeWidth = createMemo(() => (fileOpen() ? `${layout.fileTree.width()}px` : "0px"))
- const diffFiles = createMemo(() => props.diffs().map((d) => d.file))
+ const info = createMemo(() => (params.id ? sync.session.get(params.id) : undefined))
+ const diffs = createMemo(() => (params.id ? (sync.data.session_diff[params.id] ?? []) : []))
+ const reviewCount = createMemo(() => Math.max(info()?.summary?.files ?? 0, diffs().length))
+ const hasReview = createMemo(() => reviewCount() > 0)
+ const diffsReady = createMemo(() => {
+ const id = params.id
+ if (!id) return true
+ if (!hasReview()) return true
+ return sync.data.session_diff[id] !== undefined
+ })
+
+ const reviewEmptyKey = createMemo(() => {
+ if (sync.project && !sync.project.vcs) return "session.review.noVcs"
+ if (sync.data.config.snapshot === false) return "session.review.noSnapshot"
+ return "session.review.noChanges"
+ })
+
+ const diffFiles = createMemo(() => diffs().map((d) => d.file))
const kinds = createMemo(() => {
const merge = (a: "add" | "del" | "mix" | undefined, b: "add" | "del" | "mix") => {
if (!a) return b
@@ -70,7 +82,7 @@ export function SessionSidePanel(props: {
const normalize = (p: string) => p.replaceAll("\\\\", "/").replace(/\/+$/, "")
const out = new Map<string, "add" | "del" | "mix">()
- for (const diff of props.diffs()) {
+ for (const diff of diffs()) {
const file = normalize(diff.file)
const kind = diff.status === "added" ? "add" : diff.status === "deleted" ? "del" : "mix"
@@ -124,7 +136,7 @@ export function SessionSidePanel(props: {
pathFromTab: file.pathFromTab,
normalizeTab,
review: reviewTab,
- hasReview: props.canReview,
+ hasReview,
})
const contextOpen = tabState.contextOpen
const openedTabs = tabState.openedTabs
@@ -229,12 +241,12 @@ export function SessionSidePanel(props: {
onCleanup(stop)
}}
>
- <Show when={reviewTab() && props.canReview()}>
+ <Show when={reviewTab()}>
<Tabs.Trigger value="review">
<div class="flex items-center gap-1.5">
<div>{language.t("session.tab.review")}</div>
- <Show when={props.hasReview()}>
- <div>{props.reviewCount()}</div>
+ <Show when={hasReview()}>
+ <div>{reviewCount()}</div>
</Show>
</div>
</Tabs.Trigger>
@@ -291,7 +303,7 @@ export function SessionSidePanel(props: {
</Tabs.List>
</div>
- <Show when={reviewTab() && props.canReview()}>
+ <Show when={reviewTab()}>
<Tabs.Content value="review" class="flex flex-col h-full overflow-hidden contain-strict">
<Show when={activeTab() === "review"}>{props.reviewPanel()}</Show>
</Tabs.Content>
@@ -365,10 +377,8 @@ export function SessionSidePanel(props: {
>
<Tabs.List>
<Tabs.Trigger value="changes" class="flex-1" classes={{ button: "w-full" }}>
- {props.reviewCount()}{" "}
- {language.t(
- props.reviewCount() === 1 ? "session.review.change.one" : "session.review.change.other",
- )}
+ {reviewCount()}{" "}
+ {language.t(reviewCount() === 1 ? "session.review.change.one" : "session.review.change.other")}
</Tabs.Trigger>
<Tabs.Trigger value="all" class="flex-1" classes={{ button: "w-full" }}>
{language.t("session.files.all")}
@@ -376,9 +386,9 @@ export function SessionSidePanel(props: {
</Tabs.List>
<Tabs.Content value="changes" class="bg-background-stronger px-3 py-0">
<Switch>
- <Match when={props.hasReview() || !props.diffsReady()}>
+ <Match when={hasReview()}>
<Show
- when={props.diffsReady()}
+ when={diffsReady()}
fallback={
<div class="px-2 py-2 text-12-regular text-text-weak">
{language.t("common.loading")}
@@ -397,7 +407,11 @@ export function SessionSidePanel(props: {
/>
</Show>
</Match>
- <Match when={true}>{empty(props.empty())}</Match>
+ <Match when={true}>
+ {empty(
+ language.t(sync.project && !sync.project.vcs ? "session.review.noChanges" : reviewEmptyKey()),
+ )}
+ </Match>
</Switch>
</Tabs.Content>
<Tabs.Content value="all" class="bg-background-stronger px-3 py-0">
diff --git a/packages/app/src/pages/session/use-session-commands.tsx b/packages/app/src/pages/session/use-session-commands.tsx
index 344bf801d..7394765ae 100644
--- a/packages/app/src/pages/session/use-session-commands.tsx
+++ b/packages/app/src/pages/session/use-session-commands.tsx
@@ -56,7 +56,11 @@ export const useSessionCommands = (actions: SessionCommandContext) => {
if (!id) return
return sync.session.get(id)
}
- const hasReview = () => !!params.id
+ const hasReview = () => {
+ const id = params.id
+ if (!id) return false
+ return Math.max(info()?.summary?.files ?? 0, (sync.data.session_diff[id] ?? []).length) > 0
+ }
const normalizeTab = (tab: string) => {
if (!tab.startsWith("file://")) return tab
return file.tab(tab)
generated by cgit v1.2.3 (git 2.39.1) at 2026-07-25 11:50:58 +0000