summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorLe Juez Victor <[email protected]>2023-04-29 15:03:19 +0000
committerGitHub <[email protected]>2023-04-29 17:03:19 +0200
commit662dfad670eb634c1aa4cab2bfa31880cd995df3 (patch)
treea6898c1894274a252df6f75600be82296b8792d7
parent98cb7a19a1a444726eb31af34d4c25cd06c347cb (diff)
downloadraylib-662dfad670eb634c1aa4cab2bfa31880cd995df3.tar.gz
raylib-662dfad670eb634c1aa4cab2bfa31880cd995df3.zip
Correction of values ​​used only once in GenMeshCubicmap (#3032)
* Correction of values ​​used only once in GenMeshCubicmap The mapWidth and mapHeight values ​​were only used as a limit in the for loop when they could be used throughout the function. * mapWidth and mapHeight removed from GenMeshCubicmap mapWidth and mapHeight have been removed from GenMeshCubicmap in favor of using cubicmap.width and cubicmap.height
-rw-r--r--src/rmodels.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/src/rmodels.c b/src/rmodels.c
index 6b2b4b9f..9c4c3388 100644
--- a/src/rmodels.c
+++ b/src/rmodels.c
@@ -2940,11 +2940,8 @@ Mesh GenMeshCubicmap(Image cubicmap, Vector3 cubeSize)
Color *pixels = LoadImageColors(cubicmap);
- int mapWidth = cubicmap.width;
- int mapHeight = cubicmap.height;
-
// NOTE: Max possible number of triangles numCubes*(12 triangles by cube)
- int maxTriangles = cubicmap.width*cubicmap.height*12;
+ int maxTriangles = cubicmap.width * cubicmap.height * 12;
int vCounter = 0; // Used to count vertices
int tcCounter = 0; // Used to count texcoords
@@ -2981,9 +2978,9 @@ Mesh GenMeshCubicmap(Image cubicmap, Vector3 cubeSize)
RectangleF topTexUV = { 0.0f, 0.5f, 0.5f, 0.5f };
RectangleF bottomTexUV = { 0.5f, 0.5f, 0.5f, 0.5f };
- for (int z = 0; z < mapHeight; ++z)
+ for (int z = 0; z < cubicmap.height; ++z)
{
- for (int x = 0; x < mapWidth; ++x)
+ for (int x = 0; x < cubicmap.width; ++x)
{
// Define the 8 vertex of the cube, we will combine them accordingly later...
Vector3 v1 = { w*(x - 0.5f), h2, h*(z - 0.5f) };