1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
|
import type {
CutDraft,
RemovedSegmentDraft,
SegmentDraft,
SponsorCategory,
} from "@yt-music/contract";
import { describe, expect, it } from "vitest";
import {
categoryLabel,
durationLabel,
effectiveDuration,
formatRange,
newRemovedSegment,
newSegment,
reduce,
removedDuration,
removedRegions,
segmentDuration,
totalDuration,
validateDraft,
} from "./logic.js";
// ─── fixtures ────────────────────────────────────────────────────────────────
// All-required-fields objects (no Partial spreads — exactOptionalPropertyTypes
// is on). Tests spread a fresh base and override specific fields.
function baseDraft(): CutDraft {
return {
sourceVideoId: "vid",
sourceDuration: 600,
globalAlbum: "Album",
globalArtist: "Artist",
globalAlbumArt: { kind: "video-thumbnail" },
segments: [seg("s1", 1, 0, 200), seg("s2", 2, 200, 400), seg("s3", 3, 400, 600)],
};
}
function seg(
id: string,
track: number,
start: number,
end: number,
title = id.toUpperCase(),
): SegmentDraft {
return {
id,
title,
artist: "Artist",
album: "Album",
trackNumber: track,
albumArt: { kind: "video-thumbnail" },
start,
end,
removedSegments: [],
};
}
/** A SponsorBlock-category skip (the kind the backend's draft now delivers). */
function sponsSkip(
uuid: string,
start: number,
end: number,
category: SponsorCategory,
enabled = true,
label?: string,
): RemovedSegmentDraft {
return {
uuid,
start,
end,
category,
enabled,
label: label ?? categoryLabel(category),
};
}
describe("segment-editor logic (pure)", () => {
describe("per-segment field edits", () => {
it("editSegmentTitle sets the title", () => {
const d = reduce(baseDraft(), { type: "editSegmentTitle", segmentId: "s1", title: "New" });
expect(d.segments[0]?.title).toBe("New");
});
it("editSegmentArtist / Album / TrackNumber / AlbumArt update fields", () => {
let d = reduce(baseDraft(), { type: "editSegmentArtist", segmentId: "s2", artist: "X" });
expect(d.segments[1]?.artist).toBe("X");
d = reduce(d, { type: "editSegmentAlbum", segmentId: "s2", album: "Y" });
expect(d.segments[1]?.album).toBe("Y");
d = reduce(d, { type: "editSegmentTrackNumber", segmentId: "s2", trackNumber: 99 });
expect(d.segments[1]?.trackNumber).toBe(99);
d = reduce(d, {
type: "editSegmentAlbumArt",
segmentId: "s2",
albumArt: { kind: "url", url: "https://x/a.png" },
});
expect(d.segments[1]?.albumArt).toEqual({ kind: "url", url: "https://x/a.png" });
});
it("field edits on an unknown id are no-ops", () => {
const d = baseDraft();
expect(reduce(d, { type: "editSegmentTitle", segmentId: "nope", title: "x" })).toBe(d);
});
});
describe("trimSegment", () => {
it("sets the range ordered + clamped to source", () => {
const d = reduce(baseDraft(), {
type: "trimSegment",
segmentId: "s1",
start: 500,
end: -5,
});
expect(d.segments[0]?.start).toBe(0);
expect(d.segments[0]?.end).toBe(500);
});
it("refuses zero/negative length (no-op)", () => {
const d = baseDraft();
const out = reduce(d, { type: "trimSegment", segmentId: "s1", start: 100, end: 100 });
expect(out.segments[0]?.start).toBe(0);
expect(out.segments[0]?.end).toBe(200);
});
it("re-clamps existing skips into the new range and drops emptied ones", () => {
const draft: CutDraft = {
...baseDraft(),
segments: [
{
...seg("s1", 1, 0, 200),
removedSegments: [
{ uuid: "k1", start: 10, end: 20, category: "manual", enabled: true, label: "a" },
{ uuid: "k2", start: 150, end: 180, category: "manual", enabled: true, label: "b" },
],
},
],
};
const d = reduce(draft, { type: "trimSegment", segmentId: "s1", start: 0, end: 100 });
const rs = d.segments[0]?.removedSegments ?? [];
expect(rs).toHaveLength(1);
expect(rs[0]?.uuid).toBe("k1");
});
});
describe("addSegment", () => {
it("appends at the end by default and renumbers", () => {
const extra = newSegment("s4", 600, 700, {
artist: "A",
album: "L",
albumArt: { kind: "video-thumbnail" },
});
const d = reduce(baseDraft(), { type: "addSegment", segment: extra });
expect(d.segments.map((s) => s.id)).toEqual(["s1", "s2", "s3", "s4"]);
expect(d.segments[3]?.trackNumber).toBe(4);
});
it("inserts at an explicit index and renumbers", () => {
const extra = newSegment("s0", 0, 1, {
artist: "A",
album: "L",
albumArt: { kind: "video-thumbnail" },
});
const d = reduce(baseDraft(), { type: "addSegment", segment: extra, index: 0 });
expect(d.segments.map((s) => s.id)).toEqual(["s0", "s1", "s2", "s3"]);
expect(d.segments[0]?.trackNumber).toBe(1);
expect(d.segments[1]?.trackNumber).toBe(2);
});
});
describe("removeSegment", () => {
it("removes by id and renumbers", () => {
const d = reduce(baseDraft(), { type: "removeSegment", segmentId: "s2" });
expect(d.segments.map((s) => s.id)).toEqual(["s1", "s3"]);
expect(d.segments.map((s) => s.trackNumber)).toEqual([1, 2]);
});
it("unknown id is a no-op", () => {
const d = baseDraft();
expect(reduce(d, { type: "removeSegment", segmentId: "nope" })).toBe(d);
});
});
describe("splitSegment", () => {
it("splits at `at`, inserting a new segment after, and renumbers", () => {
const d = reduce(baseDraft(), {
type: "splitSegment",
segmentId: "s2",
at: 300,
newSegmentId: "s2b",
});
expect(d.segments.map((s) => s.id)).toEqual(["s1", "s2", "s2b", "s3"]);
expect(d.segments[1]?.start).toBe(200);
expect(d.segments[1]?.end).toBe(300);
expect(d.segments[2]?.start).toBe(300);
expect(d.segments[2]?.end).toBe(400);
expect(d.segments.map((s) => s.trackNumber)).toEqual([1, 2, 3, 4]);
});
it("clamps `at` into the segment", () => {
const d = reduce(baseDraft(), {
type: "splitSegment",
segmentId: "s2",
at: 9999,
newSegmentId: "s2b",
});
expect(d.segments[1]?.end).toBe(399);
expect(d.segments[2]?.start).toBe(399);
});
it("assigns skips to the half containing their midpoint", () => {
const draft: CutDraft = {
...baseDraft(),
segments: [
{
...seg("s1", 1, 0, 200),
removedSegments: [
{ uuid: "k1", start: 10, end: 20, category: "manual", enabled: true, label: "first" },
{
uuid: "k2",
start: 150,
end: 180,
category: "manual",
enabled: true,
label: "second",
},
],
},
],
};
const d = reduce(draft, {
type: "splitSegment",
segmentId: "s1",
at: 100,
newSegmentId: "s1b",
});
expect(d.segments[0]?.removedSegments.map((r) => r.uuid)).toEqual(["k1"]);
expect(d.segments[1]?.removedSegments.map((r) => r.uuid)).toEqual(["k2"]);
});
it("is a no-op when the segment is too short", () => {
const draft: CutDraft = { ...baseDraft(), segments: [seg("s1", 1, 0, 1)] };
const d = reduce(draft, { type: "splitSegment", segmentId: "s1", at: 0, newSegmentId: "x" });
expect(d).toBe(draft);
});
it("is a no-op on unknown id", () => {
const d = baseDraft();
expect(
reduce(d, { type: "splitSegment", segmentId: "nope", at: 10, newSegmentId: "x" }),
).toBe(d);
});
});
describe("mergeSegments", () => {
it("merges two adjacent segments into one spanning both, renumbers", () => {
const d = reduce(baseDraft(), { type: "mergeSegments", firstId: "s1", secondId: "s2" });
expect(d.segments.map((s) => s.id)).toEqual(["s1", "s3"]);
expect(d.segments[0]?.start).toBe(0);
expect(d.segments[0]?.end).toBe(400);
expect(d.segments.map((s) => s.trackNumber)).toEqual([1, 2]);
});
it("dedupes + clamps removed segments across the merge", () => {
const draft: CutDraft = {
...baseDraft(),
segments: [
{
...seg("s1", 1, 0, 200),
removedSegments: [
{ uuid: "k1", start: 10, end: 20, category: "manual", enabled: true, label: "a" },
],
},
{
...seg("s2", 2, 200, 400),
removedSegments: [
{ uuid: "k1", start: 10, end: 20, category: "manual", enabled: true, label: "dup" },
{ uuid: "k2", start: 250, end: 260, category: "manual", enabled: true, label: "b" },
],
},
],
};
const d = reduce(draft, { type: "mergeSegments", firstId: "s1", secondId: "s2" });
const rs = d.segments[0]?.removedSegments ?? [];
expect(rs.map((r) => r.uuid)).toEqual(["k1", "k2"]);
// k1 was clamped from [10,20] into [0,400] (unchanged here)
expect(rs[0]?.start).toBe(10);
});
it("refuses to merge non-adjacent segments", () => {
const d = baseDraft();
expect(reduce(d, { type: "mergeSegments", firstId: "s1", secondId: "s3" })).toBe(d);
});
it("refuses to merge unknown ids", () => {
const d = baseDraft();
expect(reduce(d, { type: "mergeSegments", firstId: "nope", secondId: "s2" })).toBe(d);
});
});
describe("moveSegment", () => {
it("moves a segment up and renumbers", () => {
const d = reduce(baseDraft(), { type: "moveSegment", segmentId: "s2", direction: "up" });
expect(d.segments.map((s) => s.id)).toEqual(["s2", "s1", "s3"]);
expect(d.segments.map((s) => s.trackNumber)).toEqual([1, 2, 3]);
});
it("moving the first segment up is a no-op", () => {
const d = baseDraft();
expect(reduce(d, { type: "moveSegment", segmentId: "s1", direction: "up" })).toBe(d);
});
it("moving the last segment down is a no-op", () => {
const d = baseDraft();
expect(reduce(d, { type: "moveSegment", segmentId: "s3", direction: "down" })).toBe(d);
});
});
describe("removed (skip) segments", () => {
const withSkip: CutDraft = {
...baseDraft(),
segments: [
{
...seg("s1", 1, 0, 200),
removedSegments: [
{ uuid: "k1", start: 10, end: 20, category: "manual", enabled: true, label: "Skip" },
],
},
],
};
it("toggleRemovedSegment flips enabled", () => {
const d = reduce(withSkip, {
type: "toggleRemovedSegment",
segmentId: "s1",
removedUuid: "k1",
});
expect(d.segments[0]?.removedSegments[0]?.enabled).toBe(false);
});
it("addRemovedSegment appends", () => {
const r = newRemovedSegment("k2", 30, 40, "Intro");
const d = reduce(withSkip, { type: "addRemovedSegment", segmentId: "s1", removed: r });
expect(d.segments[0]?.removedSegments.map((x) => x.uuid)).toEqual(["k1", "k2"]);
});
it("removeRemovedSegment filters by uuid", () => {
const d = reduce(withSkip, {
type: "removeRemovedSegment",
segmentId: "s1",
removedUuid: "k1",
});
expect(d.segments[0]?.removedSegments).toEqual([]);
});
it("skip actions on an unknown segment are no-ops", () => {
const d = withSkip;
expect(
reduce(d, { type: "toggleRemovedSegment", segmentId: "nope", removedUuid: "k1" }),
).toBe(d);
});
});
describe("SponsorBlock category handling", () => {
// The backend's split-by-chapters pipeline now injects skips with real
// SponsorBlock categories into the CutDraft. The reducers carry `category`
// through unchanged (they spread the skip), so a toggle must NOT drop it.
it("toggleRemovedSegment preserves the SponsorBlock category", () => {
const draft: CutDraft = {
...baseDraft(),
segments: [
{
...seg("s1", 1, 0, 200),
removedSegments: [sponsSkip("k1", 10, 30, "sponsor")],
},
],
};
const d = reduce(draft, {
type: "toggleRemovedSegment",
segmentId: "s1",
removedUuid: "k1",
});
const r = d.segments[0]?.removedSegments[0];
expect(r?.enabled).toBe(false);
expect(r?.category).toBe("sponsor"); // category survives the toggle
});
it("addRemovedSegment round-trips a SponsorBlock category", () => {
const draft: CutDraft = { ...baseDraft(), segments: [seg("s1", 1, 0, 200)] };
const d = reduce(draft, {
type: "addRemovedSegment",
segmentId: "s1",
removed: sponsSkip("k9", 5, 15, "music_offtopic"),
});
const r = d.segments[0]?.removedSegments[0];
expect(r).toMatchObject({ uuid: "k9", category: "music_offtopic", enabled: true });
});
it("removeRemovedSegment removes only the targeted SponsorBlock skip", () => {
const draft: CutDraft = {
...baseDraft(),
segments: [
{
...seg("s1", 1, 0, 200),
removedSegments: [sponsSkip("k1", 10, 20, "intro"), sponsSkip("k2", 30, 40, "outro")],
},
],
};
const d = reduce(draft, {
type: "removeRemovedSegment",
segmentId: "s1",
removedUuid: "k1",
});
expect(d.segments[0]?.removedSegments.map((r) => r.uuid)).toEqual(["k2"]);
});
});
describe("globals", () => {
it("setGlobal* set the global field only", () => {
let d = reduce(baseDraft(), { type: "setGlobalAlbum", album: "G1" });
expect(d.globalAlbum).toBe("G1");
expect(d.segments[0]?.album).toBe("Album"); // segments untouched
d = reduce(d, { type: "setGlobalArtist", artist: "GA" });
expect(d.globalArtist).toBe("GA");
d = reduce(d, { type: "setGlobalAlbumArt", albumArt: { kind: "url", url: "u" } });
expect(d.globalAlbumArt).toEqual({ kind: "url", url: "u" });
});
it("applyGlobalAlbum sets global + all segments", () => {
const d = reduce(baseDraft(), { type: "applyGlobalAlbum", album: "All" });
expect(d.globalAlbum).toBe("All");
expect(d.segments.every((s) => s.album === "All")).toBe(true);
});
it("applyGlobalArtist / applyGlobalAlbumArt apply to all", () => {
const art = { kind: "url" as const, url: "c" };
let d = reduce(baseDraft(), { type: "applyGlobalArtist", artist: "Ar" });
expect(d.segments.every((s) => s.artist === "Ar")).toBe(true);
d = reduce(d, { type: "applyGlobalAlbumArt", albumArt: art });
expect(d.segments.every((s) => s.albumArt === art)).toBe(true);
});
it("applyAllGlobals pushes current globals to every segment", () => {
let d = reduce(baseDraft(), { type: "setGlobalAlbum", album: "GA" });
d = reduce(d, { type: "setGlobalArtist", artist: "GAr" });
d = reduce(d, { type: "applyAllGlobals" });
expect(d.segments.every((s) => s.album === "GA" && s.artist === "GAr")).toBe(true);
});
});
describe("view-model helpers", () => {
it("segmentDuration / effectiveDuration / removedDuration", () => {
const s: SegmentDraft = {
...seg("s1", 1, 0, 100),
removedSegments: [
{ uuid: "k1", start: 10, end: 20, category: "manual", enabled: true, label: "a" },
{ uuid: "k2", start: 30, end: 40, category: "manual", enabled: false, label: "b" },
],
};
expect(segmentDuration(s)).toBe(100);
expect(removedDuration(s)).toBe(10); // only enabled k1
expect(effectiveDuration(s)).toBe(90);
});
it("formatRange / durationLabel format as m:ss", () => {
const s = seg("s1", 1, 65, 185);
expect(formatRange(s)).toBe("1:05 – 3:05");
expect(durationLabel(s)).toBe("2:00");
});
it("totalDuration sums effective durations", () => {
expect(totalDuration(baseDraft())).toBe(600);
});
});
describe("categoryLabel", () => {
it("maps every SponsorBlock category + manual to a friendly label", () => {
const cases: Array<[SponsorCategory | "manual", string]> = [
["sponsor", "Sponsor"],
["selfpromo", "Self-promo"],
["interaction", "Interaction"],
["intro", "Intro"],
["outro", "Outro"],
["preview", "Preview"],
["music_offtopic", "Non-music"],
["filler", "Filler"],
["manual", "Manual"],
];
for (const [cat, expected] of cases) {
expect(categoryLabel(cat)).toBe(expected);
}
});
});
describe("removedRegions (timeline view-model)", () => {
it("positions skips as percentages of the segment duration", () => {
const s: SegmentDraft = {
...seg("s1", 1, 0, 100),
removedSegments: [
sponsSkip("k1", 10, 30, "sponsor"), // first 10→30 → left 10%, width 20%
sponsSkip("k2", 60, 80, "intro"), // → left 60%, width 20%
],
};
const regions = removedRegions(s);
expect(regions).toHaveLength(2);
expect(regions[0]).toMatchObject({ uuid: "k1", leftPct: 10, widthPct: 20, enabled: true });
expect(regions[1]).toMatchObject({
uuid: "k2",
leftPct: 60,
widthPct: 20,
category: "intro",
});
});
it("clamps skips into the segment range", () => {
const s: SegmentDraft = {
...seg("s1", 1, 100, 200),
removedSegments: [
sponsSkip("k1", 50, 150, "sponsor"), // straddles start → clamped to [100,150]
sponsSkip("k2", 180, 300, "outro"), // straddles end → clamped to [180,200]
],
};
const regions = removedRegions(s);
expect(regions[0]).toMatchObject({ leftPct: 0, widthPct: 50 }); // 100→150 over dur 100
expect(regions[1]).toMatchObject({ leftPct: 80, widthPct: 20 }); // 180→200 over dur 100
});
it("drops skips with no overlap with the segment", () => {
const s: SegmentDraft = {
...seg("s1", 1, 100, 200),
removedSegments: [
sponsSkip("k1", 0, 50, "sponsor"), // entirely before
sponsSkip("k2", 250, 300, "intro"), // entirely after
sponsSkip("k3", 120, 130, "outro"), // valid, kept
],
};
expect(removedRegions(s).map((r) => r.uuid)).toEqual(["k3"]);
});
it("carries enabled state through to the region", () => {
const s: SegmentDraft = {
...seg("s1", 1, 0, 100),
removedSegments: [
sponsSkip("k1", 10, 20, "sponsor", true),
sponsSkip("k2", 30, 40, "intro", false),
],
};
const regions = removedRegions(s);
expect(regions.find((r) => r.uuid === "k1")?.enabled).toBe(true);
expect(regions.find((r) => r.uuid === "k2")?.enabled).toBe(false);
});
it("returns [] for a zero/negative-length segment", () => {
const s: SegmentDraft = {
...seg("s1", 1, 50, 50),
removedSegments: [sponsSkip("k1", 10, 20, "sponsor")],
};
expect(removedRegions(s)).toEqual([]);
});
});
describe("validateDraft", () => {
it("a clean draft is valid", () => {
expect(validateDraft(baseDraft())).toEqual([]);
});
it("flags an empty title", () => {
const d: CutDraft = { ...baseDraft(), segments: [seg("s1", 1, 0, 100, "")] };
expect(validateDraft(d).some((i) => i.message === "Title is empty")).toBe(true);
});
it("flags an inverted range", () => {
const d: CutDraft = { ...baseDraft(), segments: [seg("s1", 1, 100, 50)] };
expect(validateDraft(d).some((i) => i.message === "End must be after start")).toBe(true);
});
it("flags a range outside the source", () => {
const d: CutDraft = { ...baseDraft(), segments: [seg("s1", 1, 0, 9999)] };
expect(validateDraft(d).some((i) => i.message.includes("outside the source"))).toBe(true);
});
it("does not flag a skip extending past its segment (backend clips it)", () => {
const d: CutDraft = {
...baseDraft(),
segments: [
{
...seg("s1", 1, 0, 100),
removedSegments: [
{ uuid: "k1", start: 90, end: 150, category: "manual", enabled: true, label: "x" },
],
},
],
};
expect(validateDraft(d).some((i) => i.message.includes("outside the segment"))).toBe(false);
});
});
describe("factories", () => {
it("newSegment builds a blank segment with defaults", () => {
const s = newSegment("id", 0, 10, {
artist: "A",
album: "L",
albumArt: { kind: "video-thumbnail" },
});
expect(s).toMatchObject({ id: "id", title: "", artist: "A", album: "L", trackNumber: 0 });
expect(s.removedSegments).toEqual([]);
});
it("newRemovedSegment builds an enabled skip", () => {
const r = newRemovedSegment("u", 1, 2, "Intro");
expect(r).toMatchObject({
uuid: "u",
start: 1,
end: 2,
enabled: true,
label: "Intro",
category: "manual",
});
});
});
});
|