diff options
| author | Zsolt Kozaroczy <[email protected]> | 2023-05-24 09:28:36 +0200 |
|---|---|---|
| committer | GitHub <[email protected]> | 2023-05-24 09:28:36 +0200 |
| commit | 4437b909792909cfc677484d963c9af2bfa91edd (patch) | |
| tree | 1e4fd39a28cf7af2b4a641335aba2222e5cb118e | |
| parent | 0fa9d7523bff020b92c2a548b493ad3fb05ebed9 (diff) | |
| parent | 1eb9c45c20f2b459ffdb562507e2b6793196dec9 (diff) | |
| download | caxlsx-4437b909792909cfc677484d963c9af2bfa91edd.tar.gz caxlsx-4437b909792909cfc677484d963c9af2bfa91edd.zip | |
Merge pull request #254 from tagliala/chore/performance-redundant-block-call
Fix Performance/RedundantBlockCall offense
| -rw-r--r-- | .rubocop_todo.yml | 5 | ||||
| -rw-r--r-- | lib/axlsx/util/zip_command.rb | 4 |
2 files changed, 2 insertions, 7 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a7427d9b..a0260f2e 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -84,11 +84,6 @@ Performance/CollectionLiteralInLoop: - 'lib/axlsx/workbook/worksheet/page_margins.rb' # This cop supports safe autocorrection (--autocorrect). -Performance/RedundantBlockCall: - Exclude: - - 'lib/axlsx/util/zip_command.rb' - -# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: separated, grouped Style/AccessorGrouping: diff --git a/lib/axlsx/util/zip_command.rb b/lib/axlsx/util/zip_command.rb index bc098a92..44e06af5 100644 --- a/lib/axlsx/util/zip_command.rb +++ b/lib/axlsx/util/zip_command.rb @@ -25,10 +25,10 @@ module Axlsx # Create a temporary directory for writing files to. # # The directory and its contents are removed at the end of the block. - def open(output, &block) + def open(output) Dir.mktmpdir do |dir| @dir = dir - block.call(self) + yield(self) write_file zip_parts(output) end |